8590942c84
tldr: This adds an on-demand comparison with x64 when a difference to a non-x64 build is detected. Normally foozzie compares the baseline build (just ignition), with two secondary builds. One, the default, always uses the shipping configuration, the second passes additional flags. Both can use a different architecture than the baseline build as well. Differences between ignition and turbofan are then often detected independent of the architectures used, but reported several times (for each compared architecture). This makes the reporting more specific, by running another build on demand that uses the baseline architecture, but otherwise the same configuration that showed a difference. If it shows the difference as well, the baseline architecture is used for the report. As a result only pure architecture differences will be reported with an architecture other than x64. This also adds some minor refactorings to reduce the code complexity when looping over comparisons. For testing this, the fake-d8s are extended with different behavior for different flags passed. We add two test cases for testing: x64 vs. ia32 with difference in x64 and ia32 x64 vs. ia32 with difference only in ia32 Bug: chromium:1196633 No-Try: true Test: tools/clusterfuzz/v8_foozzie_test.py Change-Id: Ic470ae8f0b37fb1628b32e4fafc0c39377e16f8c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2897099 Reviewed-by: Liviu Rau <liviurau@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#74612}
51 lines
1.3 KiB
Plaintext
51 lines
1.3 KiB
Plaintext
#
|
|
# V8 correctness failure
|
|
# V8 correctness configs: x64,ignition:ia32,ignition_turbo
|
|
# V8 correctness sources: f60
|
|
# V8 correctness suppression:
|
|
#
|
|
# CHECK
|
|
#
|
|
# Compared x64,ignition with ia32,ignition_turbo
|
|
#
|
|
# Flags of x64,ignition:
|
|
--correctness-fuzzer-suppressions --expose-gc --fuzzing --allow-natives-for-differential-fuzzing --invoke-weak-callbacks --omit-quit --es-staging --wasm-staging --no-wasm-async-compilation --suppress-asm-messages --random-seed 12345 --turbo-filter=~ --noopt --liftoff --no-wasm-tier-up
|
|
# Flags of ia32,ignition_turbo:
|
|
--correctness-fuzzer-suppressions --expose-gc --fuzzing --allow-natives-for-differential-fuzzing --invoke-weak-callbacks --omit-quit --es-staging --wasm-staging --no-wasm-async-compilation --suppress-asm-messages --random-seed 12345 --very-bad-flag
|
|
#
|
|
# Difference:
|
|
+ very bad behavior
|
|
#
|
|
# Source file:
|
|
name/to/file.js
|
|
#
|
|
### Start of configuration x64,ignition:
|
|
|
|
1
|
|
v8-foozzie source: name/to/a/file.js
|
|
2
|
|
v8-foozzie source: name/to/file.js
|
|
weird error
|
|
^
|
|
3
|
|
unknown
|
|
|
|
|
|
### End of configuration x64,ignition
|
|
#
|
|
### Start of configuration ia32,ignition_turbo:
|
|
|
|
1
|
|
v8-foozzie source: name/to/a/file.js
|
|
2
|
|
v8-foozzie source: name/to/file.js
|
|
weird other error
|
|
^
|
|
3
|
|
unknown
|
|
|
|
very bad behavior
|
|
|
|
### End of configuration ia32,ignition_turbo
|
|
|