5dee5ade75
SharedFunctionInfos store their original function literal's id. This is also their index in the Script's SFI list. The function literal id is only needed for lazy compilation and live edit, and access only has to be fast in the former. So, we can move the SFI function literal id field to UncompiledData, and if patching with live edit, or discarding compiled code, we can perform a slower linear search through the Script's SFI list. This is a reland of 1) https://chromium-review.googlesource.com/1082480 and 2) https://chromium-review.googlesource.com/1128854 the differences being: 1) caching the literal id on UncompiledData rather than always linearly searching the SFI list, and removing the unused runtime-liveedit.cc file instead of fixing it to support this change. 2) clearing padding on UncompiledData now that it has 3 int32 fields, making its end unaligned on x64. TBR=yangguo@chromium.org,marja@chromium.org,ulan@chromium.org,cbruni@chromium.org Bug: chromium:818642 Change-Id: I58dcb12a2a60a680f662568da428e01189c62638 Reviewed-on: https://chromium-review.googlesource.com/1138325 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#54473}
56 lines
1.9 KiB
C++
56 lines
1.9 KiB
C++
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "test/unittests/test-helpers.h"
|
|
|
|
#include "include/v8.h"
|
|
#include "src/api.h"
|
|
#include "src/handles.h"
|
|
#include "src/isolate.h"
|
|
#include "src/objects-inl.h"
|
|
#include "src/objects.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
namespace test {
|
|
|
|
Handle<String> CreateSource(Isolate* isolate,
|
|
ExternalOneByteString::Resource* maybe_resource) {
|
|
static const char test_script[] = "(x) { x*x; }";
|
|
if (maybe_resource) {
|
|
return isolate->factory()
|
|
->NewExternalStringFromOneByte(maybe_resource)
|
|
.ToHandleChecked();
|
|
}
|
|
return isolate->factory()->NewStringFromAsciiChecked(test_script);
|
|
}
|
|
|
|
Handle<SharedFunctionInfo> CreateSharedFunctionInfo(
|
|
Isolate* isolate,
|
|
v8::String::ExternalOneByteStringResource* maybe_resource) {
|
|
HandleScope scope(isolate);
|
|
Handle<String> source = CreateSource(isolate, maybe_resource);
|
|
Handle<Script> script = isolate->factory()->NewScript(source);
|
|
Handle<WeakFixedArray> infos = isolate->factory()->NewWeakFixedArray(3);
|
|
script->set_shared_function_infos(*infos);
|
|
Handle<SharedFunctionInfo> shared =
|
|
isolate->factory()->NewSharedFunctionInfoForBuiltin(
|
|
isolate->factory()->NewStringFromAsciiChecked("f"),
|
|
Builtins::kCompileLazy);
|
|
int function_literal_id = 1;
|
|
// Ensure that the function can be compiled lazily.
|
|
shared->set_uncompiled_data(
|
|
*isolate->factory()->NewUncompiledDataWithoutPreParsedScope(
|
|
0, source->length(), function_literal_id));
|
|
// Make sure we have an outer scope info, even though it's empty
|
|
shared->set_raw_outer_scope_info_or_feedback_metadata(
|
|
ScopeInfo::Empty(isolate));
|
|
SharedFunctionInfo::SetScript(shared, script, function_literal_id);
|
|
return scope.CloseAndEscape(shared);
|
|
}
|
|
|
|
} // namespace test
|
|
} // namespace internal
|
|
} // namespace v8
|