ffabcbe8c0
SaveFlags previously worked by re-setting the flags using the command line. Unfortunately, this could reset flags being used by concurrent processes, which would cause TSAN issues. Now, SaveFlags stores a copy of the state of all flags on creation, and only resets changed flags in its destructor. It does this by (ab)using the flag-definitions.h pseudo-header, adding a new mode to that header which applies an includer-defined macro to each flag definition. Change-Id: I4c156ecb36b4b7c05402138088266465d31e33b6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1530809 Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#60350}
66 lines
2.0 KiB
C++
66 lines
2.0 KiB
C++
// Copyright 2014 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "test/unittests/test-utils.h"
|
|
|
|
#include "include/libplatform/libplatform.h"
|
|
#include "include/v8.h"
|
|
#include "src/api-inl.h"
|
|
#include "src/base/platform/time.h"
|
|
#include "src/flags.h"
|
|
#include "src/isolate.h"
|
|
#include "src/objects-inl.h"
|
|
#include "src/v8.h"
|
|
|
|
namespace v8 {
|
|
|
|
IsolateWrapper::IsolateWrapper(bool enforce_pointer_compression)
|
|
: array_buffer_allocator_(
|
|
v8::ArrayBuffer::Allocator::NewDefaultAllocator()) {
|
|
v8::Isolate::CreateParams create_params;
|
|
create_params.array_buffer_allocator = array_buffer_allocator_;
|
|
if (enforce_pointer_compression) {
|
|
isolate_ = reinterpret_cast<v8::Isolate*>(
|
|
i::Isolate::New(i::IsolateAllocationMode::kInV8Heap));
|
|
v8::Isolate::Initialize(isolate_, create_params);
|
|
} else {
|
|
isolate_ = v8::Isolate::New(create_params);
|
|
}
|
|
CHECK_NOT_NULL(isolate_);
|
|
}
|
|
|
|
IsolateWrapper::~IsolateWrapper() {
|
|
v8::Platform* platform = internal::V8::GetCurrentPlatform();
|
|
CHECK_NOT_NULL(platform);
|
|
while (platform::PumpMessageLoop(platform, isolate_)) continue;
|
|
isolate_->Dispose();
|
|
delete array_buffer_allocator_;
|
|
}
|
|
|
|
// static
|
|
v8::IsolateWrapper* SharedIsolateHolder::isolate_wrapper_ = nullptr;
|
|
|
|
namespace internal {
|
|
|
|
SaveFlags::SaveFlags() {
|
|
// For each flag, save the current flag value.
|
|
#define FLAG_MODE_APPLY(ftype, ctype, nam, def, cmt) SAVED_##nam = FLAG_##nam;
|
|
#include "src/flag-definitions.h" // NOLINT
|
|
#undef FLAG_MODE_APPLY
|
|
}
|
|
|
|
SaveFlags::~SaveFlags() {
|
|
// For each flag, set back the old flag value if it changed (don't write the
|
|
// flag if it didn't change, to keep TSAN happy).
|
|
#define FLAG_MODE_APPLY(ftype, ctype, nam, def, cmt) \
|
|
if (SAVED_##nam != FLAG_##nam) { \
|
|
FLAG_##nam = SAVED_##nam; \
|
|
}
|
|
#include "src/flag-definitions.h" // NOLINT
|
|
#undef FLAG_MODE_APPLY
|
|
}
|
|
|
|
} // namespace internal
|
|
} // namespace v8
|