a81e8d16f4
Previously the `Debugger.CallFrame`s in `Debugger.paused` events would report locations relative to the surrounding document in case of inline scripts with `//@ sourceURL` annotations (while `Runtime.CallFrame` was already fixed previously as part of crrev.com/c/3069289). With this CL the locations in `Debugger.CallFrame` are also appropriately adjusted. Drive-by-fix: Several inspector tests were (incorrectly) relying on this wrong treatment, and were also unnecessarily using //# sourceURL annotations. So part of this CL also addresses that problem and makes the tests more robust, using addInlineScript() helper. Fixed: chromium:1283049 Bug: chromium:1183990, chromium:578269 Change-Id: I6e3b215d951c3453c0a9cfc9bccf3dc3d5e92fd6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3359619 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/main@{#78450}
54 lines
1.4 KiB
JavaScript
54 lines
1.4 KiB
JavaScript
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
let {session, contextGroup, Protocol} = InspectorTest.start('Debugger breaks in next script after stepOut from previous one.');
|
|
|
|
contextGroup.addInlineScript(
|
|
`
|
|
function test() {
|
|
setTimeout('var a = 1;//# sourceURL=timeout1.js', 0);
|
|
setTimeout(foo, 0);
|
|
setTimeout('var a = 3;//# sourceURL=timeout3.js', 0);
|
|
debugger;
|
|
}`,
|
|
'foo.js');
|
|
|
|
contextGroup.addInlineScript(
|
|
`
|
|
function foo() {
|
|
return 42;
|
|
}`,
|
|
'timeout2.js');
|
|
|
|
session.setupScriptMap();
|
|
var stepAction;
|
|
Protocol.Debugger.onPaused(message => {
|
|
session.logCallFrames(message.params.callFrames);
|
|
InspectorTest.log('');
|
|
Protocol.Debugger[stepAction]();
|
|
});
|
|
Protocol.Debugger.enable()
|
|
InspectorTest.runTestSuite([
|
|
function testStepOut(next) {
|
|
stepAction = 'stepOut';
|
|
Protocol.Runtime.evaluate({ expression: 'test()' })
|
|
.then(() => InspectorTest.waitForPendingTasks())
|
|
.then(next);
|
|
},
|
|
|
|
function testStepOver(next) {
|
|
stepAction = 'stepOver';
|
|
Protocol.Runtime.evaluate({ expression: 'test()' })
|
|
.then(() => InspectorTest.waitForPendingTasks())
|
|
.then(next);
|
|
},
|
|
|
|
function testStepInto(next) {
|
|
stepAction = 'stepInto';
|
|
Protocol.Runtime.evaluate({ expression: 'test()' })
|
|
.then(() => InspectorTest.waitForPendingTasks())
|
|
.then(next);
|
|
}
|
|
]);
|