29ee62443d
Reason for revert: Seems to cause compile errors on Android. Will investigate on Monday. Original issue's description: > [base] Pass scalar arguments by value in CHECK/DCHECK > > This not only potentially improves performance, but also avoids weird > linker errors, like the one below, where I used Smi::kMinValue in a > DCHECK_EQ. > > > [421/649] LINK ./mksnapshot > > FAILED: mksnapshot > > src/base/logging.h|178| error: undefined reference to > 'v8::internal::Smi::kMinValue' > > R=bmeurer@chromium.org, ishell@chromium.org > > Committed: https://crrev.com/76723502528c5af003fdffc3520632ea2a13fef3 > Cr-Commit-Position: refs/heads/master@{#41273} TBR=bmeurer@chromium.org,ishell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2527883004 Cr-Commit-Position: refs/heads/master@{#41278}
20 lines
543 B
C++
20 lines
543 B
C++
// Copyright 2015 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "src/base/logging.h"
|
|
#include "testing/gtest-support.h"
|
|
|
|
namespace v8 {
|
|
namespace base {
|
|
|
|
TEST(LoggingTest, CheckEQImpl) {
|
|
EXPECT_EQ(nullptr, CheckEQImpl(0.0, 0.0, ""));
|
|
EXPECT_EQ(nullptr, CheckEQImpl(0.0, -0.0, ""));
|
|
EXPECT_EQ(nullptr, CheckEQImpl(-0.0, 0.0, ""));
|
|
EXPECT_EQ(nullptr, CheckEQImpl(-0.0, -0.0, ""));
|
|
}
|
|
|
|
} // namespace base
|
|
} // namespace v8
|