2c0a49f39c
- Add gcert/gcertstatus support for chrome helper - Skip pprof uploading for non-googlers - Print better local results instructions for multiple chromium results files - Fix docs link in --help text - Exit silently when a keyboard interrupt ocurred Drive-by-fix: - format files - sort imports Change-Id: I88bae27102dbf3d560c4203774d9746e96fdbdc5 No-Try: True No-CQ: True Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3878166 Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#83069}
266 lines
8.0 KiB
Python
Executable File
266 lines
8.0 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright 2022 the V8 project authors. All rights reserved.
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
# found in the LICENSE file.
|
|
|
|
from datetime import datetime
|
|
from datetime import timedelta
|
|
import optparse
|
|
import os
|
|
from pathlib import Path
|
|
import shlex
|
|
import shutil
|
|
import signal
|
|
import subprocess
|
|
import sys
|
|
import time
|
|
|
|
import psutil
|
|
|
|
# ==============================================================================
|
|
|
|
usage = """Usage: %prog [OPTION]... $D8_BIN [D8_OPTION]... [FILE]
|
|
|
|
This script runs linux-perf with custom V8 logging to get support to resolve
|
|
JS function names.
|
|
|
|
The perf data is written to OUT_DIR separate by renderer process.
|
|
|
|
See https://v8.dev/docs/linux-perf for more detailed instructions.
|
|
See $D8_BIN --help for more flags/options
|
|
"""
|
|
parser = optparse.OptionParser(usage=usage)
|
|
# Stop parsing options after D8_BIN
|
|
parser.disable_interspersed_args()
|
|
|
|
parser.add_option(
|
|
'--perf-data-dir',
|
|
default=None,
|
|
metavar="OUT_DIR",
|
|
help="Output directory for linux perf profile files")
|
|
parser.add_option("--timeout", type=float, help="Stop d8 after N seconds")
|
|
|
|
d8_options = optparse.OptionGroup(
|
|
parser, "d8-forwarded Options",
|
|
"THese options are for a better script experience that are forward directly"
|
|
"to d8. Any other d8 option can be passed after the '--' arguments"
|
|
"separator.")
|
|
d8_options.add_option(
|
|
"--perf-prof-annotate-wasm",
|
|
help="Load wasm source map and provide annotate wasm code.",
|
|
action="store_true",
|
|
default=False)
|
|
d8_options.add_option(
|
|
"--no-interpreted-frames-native-stack",
|
|
help="For profiling v8 copies the interpreter entry trampoline for every "
|
|
"interpreted function. This makes interpreted functions identifiable on the "
|
|
"native stack at cost of a slight performance and memory overhead.",
|
|
action="store_true",
|
|
default=False)
|
|
parser.add_option_group(d8_options)
|
|
|
|
perf_options = optparse.OptionGroup(
|
|
parser, "perf-forward options", """
|
|
These options are forward directly to the `perf record` command and can be
|
|
used to manually tweak how profiling works.
|
|
|
|
See `perf record --help for more` informationn
|
|
""")
|
|
|
|
perf_options.add_option(
|
|
"--freq",
|
|
default="max",
|
|
help="Sampling frequency, either 'max' or a number in herz. "
|
|
"Might be reduced depending on the platform.")
|
|
perf_options.add_option("--call-graph", default="fp", help="Defaults tp 'fp'")
|
|
perf_options.add_option("--event", default=None, help="Not set by default.")
|
|
perf_options.add_option(
|
|
"--raw-samples",
|
|
default=None,
|
|
help="Collect raw samples. Not set by default")
|
|
perf_options.add_option(
|
|
"--count", default=None, help="Event period to sample. Not set by default.")
|
|
perf_options.add_option(
|
|
"--no-inherit",
|
|
action="store_true",
|
|
default=False,
|
|
help=" Child tasks do not inherit counters.")
|
|
parser.add_option_group(perf_options)
|
|
|
|
|
|
# ==============================================================================
|
|
def log(*args):
|
|
print("")
|
|
print("=" * 80)
|
|
print(*args)
|
|
print("=" * 80)
|
|
|
|
|
|
# ==============================================================================
|
|
(options, args) = parser.parse_args()
|
|
|
|
if len(args) == 0:
|
|
parser.error("No d8 binary provided")
|
|
|
|
d8_bin = Path(args.pop(0)).absolute()
|
|
if not d8_bin.exists():
|
|
parser.error(f"D8 '{d8_bin}' does not exist")
|
|
|
|
if options.perf_data_dir is None:
|
|
options.perf_data_dir = Path.cwd()
|
|
else:
|
|
options.perf_data_dir = Path(options.perf_data_dir).absolute()
|
|
|
|
if not options.perf_data_dir.is_dir():
|
|
parser.error(f"--perf-data-dir={options.perf_data_dir} "
|
|
"is not an directory or does not exist.")
|
|
|
|
if options.timeout and options.timeout < 0:
|
|
parser.error("--timeout should be a positive number")
|
|
|
|
|
|
# ==============================================================================
|
|
def make_path_absolute(maybe_path):
|
|
if maybe_path.startswith("-"):
|
|
return maybe_path
|
|
path = Path(maybe_path)
|
|
if path.exists():
|
|
return str(path.absolute())
|
|
return maybe_path
|
|
|
|
|
|
def make_args_paths_absolute(args):
|
|
return list(map(make_path_absolute, args))
|
|
|
|
|
|
# Preprocess args if we change CWD to get cleaner output
|
|
if options.perf_data_dir != Path.cwd():
|
|
args = make_args_paths_absolute(args)
|
|
|
|
# ==============================================================================
|
|
old_cwd = Path.cwd()
|
|
os.chdir(options.perf_data_dir)
|
|
|
|
# ==============================================================================
|
|
|
|
cmd = [str(d8_bin), "--perf-prof"]
|
|
|
|
if not options.no_interpreted_frames_native_stack:
|
|
cmd += ["--interpreted-frames-native-stack"]
|
|
if options.perf_prof_annotate_wasm:
|
|
cmd += ["--perf-prof-annotate-wasm"]
|
|
|
|
cmd += args
|
|
log("D8 CMD: ", shlex.join(cmd))
|
|
|
|
datetime_str = datetime.now().strftime("%Y-%m-%d_%H%M%S")
|
|
perf_data_file = Path.cwd() / f"d8_{datetime_str}.perf.data"
|
|
perf_cmd = [
|
|
"perf", "record", f"--call-graph={options.call_graph}",
|
|
f"--freq={options.freq}", "--clockid=mono", f"--output={perf_data_file}"
|
|
]
|
|
if options.count:
|
|
perf_cmd += [f"--count={options.count}"]
|
|
if options.raw_samples:
|
|
perf_cmd += [f"--raw_samples={options.raw_samples}"]
|
|
if options.event:
|
|
perf_cmd += [f"--event={options.event}"]
|
|
if options.no_inherit:
|
|
perf_cmd += [f"--no-inherit"]
|
|
|
|
cmd = perf_cmd + ["--"] + cmd
|
|
log("LINUX PERF CMD: ", shlex.join(cmd))
|
|
|
|
|
|
def wait_for_process_timeout(process):
|
|
delta = timedelta(seconds=options.timeout)
|
|
start_time = datetime.now()
|
|
while True:
|
|
if (datetime.now() - start_time) >= delta:
|
|
return False
|
|
processHasStopped = process.poll() is not None
|
|
if processHasStopped:
|
|
return True
|
|
time.sleep(0.1)
|
|
return False
|
|
|
|
|
|
if options.timeout is None:
|
|
try:
|
|
subprocess.check_call(cmd)
|
|
log("Waiting for linux-perf to flush all perf data")
|
|
time.sleep(1)
|
|
except:
|
|
log("ERROR running perf record")
|
|
else:
|
|
process = subprocess.Popen(cmd)
|
|
if not wait_for_process_timeout(process):
|
|
log(f"QUITING d8 processes after {options.timeout}s timeout")
|
|
current_process = psutil.Process()
|
|
children = current_process.children(recursive=True)
|
|
for child in children:
|
|
if "d8" in child.name():
|
|
print(f" quitting PID={child.pid}")
|
|
child.send_signal(signal.SIGQUIT)
|
|
log("Waiting for linux-perf to flush all perf data")
|
|
time.sleep(1)
|
|
return_status = process.poll()
|
|
if return_status is None:
|
|
log("Force quitting linux-perf")
|
|
process.send_signal(signal.SIGQUIT)
|
|
process.wait()
|
|
elif return_status != 0:
|
|
log("ERROR running perf record")
|
|
|
|
# ==============================================================================
|
|
log("POST PROCESSING: Injecting JS symbols")
|
|
|
|
def inject_v8_symbols(perf_dat_file):
|
|
output_file = perf_dat_file.with_suffix(".data.jitted")
|
|
cmd = [
|
|
"perf", "inject", "--jit", f"--input={perf_dat_file}",
|
|
f"--output={output_file}"
|
|
]
|
|
try:
|
|
subprocess.check_call(cmd)
|
|
print(f"Processed: {output_file}")
|
|
except:
|
|
print(shlex.join(cmd))
|
|
return None
|
|
return output_file
|
|
|
|
result = inject_v8_symbols(perf_data_file)
|
|
if result is None:
|
|
print("No perf files were successfully processed"
|
|
" Check for errors or partial results in '{options.perf_data_dir}'")
|
|
exit(1)
|
|
log(f"RESULTS in '{options.perf_data_dir}'")
|
|
BYTES_TO_MIB = 1 / 1024 / 1024
|
|
print(f"{result.name:67}{(result.stat().st_size*BYTES_TO_MIB):10.2f}MiB")
|
|
|
|
# ==============================================================================
|
|
if not shutil.which('gcertstatus'):
|
|
log("ANALYSIS")
|
|
print(f"perf report --input='{result}'")
|
|
print(f"pprof '{result}'")
|
|
exit(0)
|
|
|
|
log("PPROF")
|
|
has_gcert = False
|
|
try:
|
|
print("# Checking gcert status for googlers")
|
|
subprocess.check_call("gcertstatus >&/dev/null || gcert", shell=True)
|
|
has_gcert = True
|
|
|
|
cmd = ["pprof", "-flame", f"-add_comment={shlex.join(sys.argv)}", str(result)]
|
|
print("# Processing and uploading to pprofresult")
|
|
url = subprocess.check_output(cmd).decode('utf-8').strip()
|
|
print(url)
|
|
except subprocess.CalledProcessError as e:
|
|
if has_gcert:
|
|
raise Exception("Could not generate pprof results") from e
|
|
print("# Please run `gcert` for generating pprof results")
|
|
print(f"pprof -flame {result}")
|
|
except KeyboardInterrupt:
|
|
exit(1)
|