4743426571
We used to check the size of tables at compile time, and threw a CompilationError if a given size exceeded the implementation-defined limit. However, the spec defines that an error should only be thrown when the implementation-defined limit is reached, which is either at instantiation time of during runtime at a table.grow. With this CL the V8 implementation becomes spec compliant in this regard. R=jkummerow@chromium.org Bug: v8:10556 Change-Id: I7d0e688b385a65e4060a569e5ab1dec68947ceea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2326331 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#69267}
43 lines
1.3 KiB
JavaScript
43 lines
1.3 KiB
JavaScript
// Copyright 2018 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --wasm-max-table-size=10
|
|
|
|
load("test/mjsunit/wasm/wasm-module-builder.js");
|
|
|
|
// With the flags we set the maximum table size to 10, so 11 is out-of-bounds.
|
|
const oob = 11;
|
|
|
|
(function TestJSTableInitialAboveTheLimit() {
|
|
print(arguments.callee.name);
|
|
assertThrows(
|
|
() => new WebAssembly.Table({ initial: oob, element: "anyfunc" }),
|
|
RangeError, /above the upper bound/);
|
|
})();
|
|
|
|
(function TestJSTableMaximumAboveTheLimit() {
|
|
print(arguments.callee.name);
|
|
let table =
|
|
new WebAssembly.Table({initial: 1, maximum: oob, element: 'anyfunc'});
|
|
assertThrows(() => table.grow(oob - 1), RangeError, /failed to grow table/);
|
|
})();
|
|
|
|
(function TestDecodeTableInitialAboveTheLimit() {
|
|
print(arguments.callee.name);
|
|
const builder = new WasmModuleBuilder();
|
|
builder.setTableBounds(oob);
|
|
assertThrows(
|
|
() => builder.instantiate(),
|
|
RangeError, /is larger than implementation limit/);
|
|
})();
|
|
|
|
(function TestDecodeTableMaximumAboveTheLimit() {
|
|
print(arguments.callee.name);
|
|
const builder = new WasmModuleBuilder();
|
|
builder.setTableBounds(1, oob);
|
|
// Should not throw, as the table does not exceed the limit at instantiation
|
|
// time.
|
|
builder.instantiate();
|
|
})();
|