27fd921a28
This fixes debug-evaluate in the presence of a de-materialized function object. The creation of an arguments object is now requested based on a given frame (potentially inlined) instead of a target function. It makes sure that multiple calls to {StandardFrame::Summarize} don't cause any confusion when they give back non-identical function objects. R=jgruber@chromium.org TEST=debugger/debug/debug-evaluate-arguments BUG=chromium:788647 Change-Id: I575bb6cb20b4657dc09019e631b5d6e36c1b5189 Reviewed-on: https://chromium-review.googlesource.com/796474 Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#49721}
61 lines
1.3 KiB
JavaScript
61 lines
1.3 KiB
JavaScript
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --allow-natives-syntax
|
|
|
|
Debug = debug.Debug;
|
|
var listened = false;
|
|
|
|
function listener(event, exec_state, event_data, data) {
|
|
if (event != Debug.DebugEvent.Break) return;
|
|
try {
|
|
var foo_arguments = exec_state.frame(1).evaluate("arguments").value();
|
|
var bar_arguments = exec_state.frame(0).evaluate("arguments").value();
|
|
assertArrayEquals(foo_expected, foo_arguments);
|
|
assertArrayEquals(bar_expected, bar_arguments);
|
|
listened = true;
|
|
} catch (e) {
|
|
print(e);
|
|
print(e.stack);
|
|
}
|
|
}
|
|
|
|
Debug.setListener(listener);
|
|
|
|
function foo(a) {
|
|
function bar(a,b,c) {
|
|
debugger;
|
|
return a + b + c;
|
|
}
|
|
return bar(1,2,a);
|
|
}
|
|
|
|
listened = false;
|
|
foo_expected = [3];
|
|
bar_expected = [1,2,3];
|
|
assertEquals(6, foo(3));
|
|
assertTrue(listened);
|
|
|
|
listened = false;
|
|
foo_expected = [3];
|
|
bar_expected = [1,2,3];
|
|
assertEquals(6, foo(3));
|
|
assertTrue(listened);
|
|
|
|
listened = false;
|
|
foo_expected = [3];
|
|
bar_expected = [1,2,3];
|
|
%OptimizeFunctionOnNextCall(foo);
|
|
assertEquals(6, foo(3));
|
|
assertTrue(listened);
|
|
|
|
listened = false;
|
|
foo_expected = [3,4,5];
|
|
bar_expected = [1,2,3];
|
|
%OptimizeFunctionOnNextCall(foo);
|
|
assertEquals(6, foo(3,4,5));
|
|
assertTrue(listened);
|
|
|
|
Debug.setListener(null);
|