07011cc4f0
This replaces Runtime_RunMicrotasks with Runtime_PerformMicrotaskCheckpoint.
RunMicrotasks forcibly runs Microtasks even when the microtasks are suppressed,
and may causes nested Microtasks in a problematic way. E.g. that confuses
v8::MicrotasksScope::IsRunningMicrotasks() and GetEnteredOrMicrotaskContext().
OTOH, PerformMicrotaskCheckpoint() doesn't run cause the failure as it
respects the microtask suppressions.
As all existing tests don't call RunMicrotasks() in the suppressed situation
(like Promise.resolve().then(()=>{%RunMicrotasks();})), this change should
not affect to these tests.
Change-Id: Ib043a0cc8e482e022d375084d65ea98a6f54ef3d
Reviewed-on: https://chromium-review.googlesource.com/c/1360095
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58068}
92 lines
1.5 KiB
JavaScript
92 lines
1.5 KiB
JavaScript
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --allow-natives-syntax --harmony-dynamic-import
|
|
|
|
var ran = false;
|
|
|
|
var x = {
|
|
get toString() { return undefined; }
|
|
};
|
|
import(x);
|
|
|
|
var x = {
|
|
toString() {
|
|
throw new Error('42 is the answer');
|
|
}
|
|
};
|
|
import(x);
|
|
|
|
var x = {
|
|
get toString() {
|
|
throw new Error('42 is the answer');
|
|
}
|
|
};
|
|
import(x);
|
|
|
|
async function test1() {
|
|
try {
|
|
let x = {
|
|
toString() {
|
|
throw new Error('42 is the answer');
|
|
}
|
|
};
|
|
|
|
let namespace = await import(x);
|
|
%AbortJS('failure: this should throw');
|
|
} catch(e) {
|
|
assertEquals(e.message, '42 is the answer');
|
|
ran = true;
|
|
}
|
|
}
|
|
|
|
test1();
|
|
|
|
%PerformMicrotaskCheckpoint();
|
|
|
|
assertTrue(ran);
|
|
|
|
ran = false;
|
|
async function test2() {
|
|
try {
|
|
let x = {
|
|
get toString() {
|
|
throw new Error('42 is the answer');
|
|
}
|
|
};
|
|
|
|
let namespace = await import(x);
|
|
%AbortJS('failure: this should throw');
|
|
} catch(e) {
|
|
assertEquals(e.message, '42 is the answer');
|
|
ran = true;
|
|
}
|
|
}
|
|
|
|
test2();
|
|
|
|
%PerformMicrotaskCheckpoint();
|
|
|
|
assertTrue(ran);
|
|
|
|
ran = false;
|
|
async function test3() {
|
|
try {
|
|
let x = {
|
|
get toString() { return undefined; }
|
|
};
|
|
let namespace = await import(x);
|
|
%AbortJS('failure: this should throw');
|
|
} catch(e) {
|
|
assertEquals(e.message, 'Cannot convert object to primitive value');
|
|
ran = true;
|
|
}
|
|
}
|
|
|
|
test3();
|
|
|
|
%PerformMicrotaskCheckpoint();
|
|
|
|
assertTrue(ran);
|