8617b3acf8
Those floating point constant operators require bitwise handling of their parameters, otherwise 0.0 equals -0.0. This is solved in a general way by adding new base::bit_equal_to and base::bit_hash function objects. TEST=unittests R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/636953002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24450 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
253 lines
8.8 KiB
C++
253 lines
8.8 KiB
C++
// Copyright 2014 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "src/compiler/common-operator.h"
|
|
|
|
#include <limits>
|
|
|
|
#include "src/compiler/operator-properties-inl.h"
|
|
#include "test/unittests/test-utils.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
namespace compiler {
|
|
|
|
|
|
// -----------------------------------------------------------------------------
|
|
// Shared operators.
|
|
|
|
|
|
namespace {
|
|
|
|
struct SharedOperator {
|
|
const Operator* (CommonOperatorBuilder::*constructor)();
|
|
IrOpcode::Value opcode;
|
|
Operator::Properties properties;
|
|
int value_input_count;
|
|
int effect_input_count;
|
|
int control_input_count;
|
|
int effect_output_count;
|
|
int control_output_count;
|
|
};
|
|
|
|
|
|
std::ostream& operator<<(std::ostream& os, const SharedOperator& fop) {
|
|
return os << IrOpcode::Mnemonic(fop.opcode);
|
|
}
|
|
|
|
|
|
const SharedOperator kSharedOperators[] = {
|
|
#define SHARED(Name, properties, value_input_count, effect_input_count, \
|
|
control_input_count, effect_output_count, control_output_count) \
|
|
{ \
|
|
&CommonOperatorBuilder::Name, IrOpcode::k##Name, properties, \
|
|
value_input_count, effect_input_count, control_input_count, \
|
|
effect_output_count, control_output_count \
|
|
}
|
|
SHARED(Dead, Operator::kFoldable, 0, 0, 0, 0, 1),
|
|
SHARED(End, Operator::kFoldable, 0, 0, 1, 0, 0),
|
|
SHARED(Branch, Operator::kFoldable, 1, 0, 1, 0, 2),
|
|
SHARED(IfTrue, Operator::kFoldable, 0, 0, 1, 0, 1),
|
|
SHARED(IfFalse, Operator::kFoldable, 0, 0, 1, 0, 1),
|
|
SHARED(Throw, Operator::kFoldable, 1, 0, 1, 0, 1),
|
|
SHARED(Return, Operator::kNoProperties, 1, 1, 1, 1, 1)
|
|
#undef SHARED
|
|
};
|
|
|
|
|
|
class CommonSharedOperatorTest
|
|
: public TestWithZone,
|
|
public ::testing::WithParamInterface<SharedOperator> {};
|
|
|
|
} // namespace
|
|
|
|
|
|
TEST_P(CommonSharedOperatorTest, InstancesAreGloballyShared) {
|
|
const SharedOperator& sop = GetParam();
|
|
CommonOperatorBuilder common1(zone());
|
|
CommonOperatorBuilder common2(zone());
|
|
EXPECT_EQ((common1.*sop.constructor)(), (common2.*sop.constructor)());
|
|
}
|
|
|
|
|
|
TEST_P(CommonSharedOperatorTest, NumberOfInputsAndOutputs) {
|
|
CommonOperatorBuilder common(zone());
|
|
const SharedOperator& sop = GetParam();
|
|
const Operator* op = (common.*sop.constructor)();
|
|
|
|
EXPECT_EQ(sop.value_input_count, OperatorProperties::GetValueInputCount(op));
|
|
EXPECT_EQ(sop.effect_input_count,
|
|
OperatorProperties::GetEffectInputCount(op));
|
|
EXPECT_EQ(sop.control_input_count,
|
|
OperatorProperties::GetControlInputCount(op));
|
|
EXPECT_EQ(
|
|
sop.value_input_count + sop.effect_input_count + sop.control_input_count,
|
|
OperatorProperties::GetTotalInputCount(op));
|
|
|
|
EXPECT_EQ(0, OperatorProperties::GetValueOutputCount(op));
|
|
EXPECT_EQ(sop.effect_output_count,
|
|
OperatorProperties::GetEffectOutputCount(op));
|
|
EXPECT_EQ(sop.control_output_count,
|
|
OperatorProperties::GetControlOutputCount(op));
|
|
}
|
|
|
|
|
|
TEST_P(CommonSharedOperatorTest, OpcodeIsCorrect) {
|
|
CommonOperatorBuilder common(zone());
|
|
const SharedOperator& sop = GetParam();
|
|
const Operator* op = (common.*sop.constructor)();
|
|
EXPECT_EQ(sop.opcode, op->opcode());
|
|
}
|
|
|
|
|
|
TEST_P(CommonSharedOperatorTest, Properties) {
|
|
CommonOperatorBuilder common(zone());
|
|
const SharedOperator& sop = GetParam();
|
|
const Operator* op = (common.*sop.constructor)();
|
|
EXPECT_EQ(sop.properties, op->properties());
|
|
}
|
|
|
|
|
|
INSTANTIATE_TEST_CASE_P(CommonOperatorTest, CommonSharedOperatorTest,
|
|
::testing::ValuesIn(kSharedOperators));
|
|
|
|
|
|
// -----------------------------------------------------------------------------
|
|
// Other operators.
|
|
|
|
|
|
namespace {
|
|
|
|
class CommonOperatorTest : public TestWithZone {
|
|
public:
|
|
CommonOperatorTest() : common_(zone()) {}
|
|
virtual ~CommonOperatorTest() {}
|
|
|
|
CommonOperatorBuilder* common() { return &common_; }
|
|
|
|
private:
|
|
CommonOperatorBuilder common_;
|
|
};
|
|
|
|
|
|
const int kArguments[] = {1, 5, 6, 42, 100, 10000, kMaxInt};
|
|
|
|
|
|
const float kFloatValues[] = {-std::numeric_limits<float>::infinity(),
|
|
std::numeric_limits<float>::min(),
|
|
-1.0f,
|
|
-0.0f,
|
|
0.0f,
|
|
1.0f,
|
|
std::numeric_limits<float>::max(),
|
|
std::numeric_limits<float>::infinity(),
|
|
std::numeric_limits<float>::quiet_NaN(),
|
|
std::numeric_limits<float>::signaling_NaN()};
|
|
|
|
|
|
const double kDoubleValues[] = {-std::numeric_limits<double>::infinity(),
|
|
std::numeric_limits<double>::min(),
|
|
-1.0,
|
|
-0.0,
|
|
0.0,
|
|
1.0,
|
|
std::numeric_limits<double>::max(),
|
|
std::numeric_limits<double>::infinity(),
|
|
std::numeric_limits<double>::quiet_NaN(),
|
|
std::numeric_limits<double>::signaling_NaN()};
|
|
|
|
} // namespace
|
|
|
|
|
|
TEST_F(CommonOperatorTest, Float32Constant) {
|
|
TRACED_FOREACH(float, value, kFloatValues) {
|
|
const Operator* op = common()->Float32Constant(value);
|
|
EXPECT_PRED2(base::bit_equal_to<float>(), value, OpParameter<float>(op));
|
|
EXPECT_EQ(0, OperatorProperties::GetValueInputCount(op));
|
|
EXPECT_EQ(0, OperatorProperties::GetTotalInputCount(op));
|
|
EXPECT_EQ(0, OperatorProperties::GetControlOutputCount(op));
|
|
EXPECT_EQ(0, OperatorProperties::GetEffectOutputCount(op));
|
|
EXPECT_EQ(1, OperatorProperties::GetValueOutputCount(op));
|
|
}
|
|
TRACED_FOREACH(float, v1, kFloatValues) {
|
|
TRACED_FOREACH(float, v2, kFloatValues) {
|
|
const Operator* op1 = common()->Float32Constant(v1);
|
|
const Operator* op2 = common()->Float32Constant(v2);
|
|
EXPECT_EQ(bit_cast<uint32_t>(v1) == bit_cast<uint32_t>(v2),
|
|
op1->Equals(op2));
|
|
}
|
|
}
|
|
}
|
|
|
|
|
|
TEST_F(CommonOperatorTest, Float64Constant) {
|
|
TRACED_FOREACH(double, value, kFloatValues) {
|
|
const Operator* op = common()->Float64Constant(value);
|
|
EXPECT_PRED2(base::bit_equal_to<double>(), value, OpParameter<double>(op));
|
|
EXPECT_EQ(0, OperatorProperties::GetValueInputCount(op));
|
|
EXPECT_EQ(0, OperatorProperties::GetTotalInputCount(op));
|
|
EXPECT_EQ(0, OperatorProperties::GetControlOutputCount(op));
|
|
EXPECT_EQ(0, OperatorProperties::GetEffectOutputCount(op));
|
|
EXPECT_EQ(1, OperatorProperties::GetValueOutputCount(op));
|
|
}
|
|
TRACED_FOREACH(double, v1, kFloatValues) {
|
|
TRACED_FOREACH(double, v2, kFloatValues) {
|
|
const Operator* op1 = common()->Float64Constant(v1);
|
|
const Operator* op2 = common()->Float64Constant(v2);
|
|
EXPECT_EQ(bit_cast<uint64_t>(v1) == bit_cast<uint64_t>(v2),
|
|
op1->Equals(op2));
|
|
}
|
|
}
|
|
}
|
|
|
|
|
|
TEST_F(CommonOperatorTest, NumberConstant) {
|
|
TRACED_FOREACH(double, value, kFloatValues) {
|
|
const Operator* op = common()->NumberConstant(value);
|
|
EXPECT_PRED2(base::bit_equal_to<double>(), value, OpParameter<double>(op));
|
|
EXPECT_EQ(0, OperatorProperties::GetValueInputCount(op));
|
|
EXPECT_EQ(0, OperatorProperties::GetTotalInputCount(op));
|
|
EXPECT_EQ(0, OperatorProperties::GetControlOutputCount(op));
|
|
EXPECT_EQ(0, OperatorProperties::GetEffectOutputCount(op));
|
|
EXPECT_EQ(1, OperatorProperties::GetValueOutputCount(op));
|
|
}
|
|
TRACED_FOREACH(double, v1, kFloatValues) {
|
|
TRACED_FOREACH(double, v2, kFloatValues) {
|
|
const Operator* op1 = common()->NumberConstant(v1);
|
|
const Operator* op2 = common()->NumberConstant(v2);
|
|
EXPECT_EQ(bit_cast<uint64_t>(v1) == bit_cast<uint64_t>(v2),
|
|
op1->Equals(op2));
|
|
}
|
|
}
|
|
}
|
|
|
|
|
|
TEST_F(CommonOperatorTest, ValueEffect) {
|
|
TRACED_FOREACH(int, arguments, kArguments) {
|
|
const Operator* op = common()->ValueEffect(arguments);
|
|
EXPECT_EQ(arguments, OperatorProperties::GetValueInputCount(op));
|
|
EXPECT_EQ(arguments, OperatorProperties::GetTotalInputCount(op));
|
|
EXPECT_EQ(0, OperatorProperties::GetControlOutputCount(op));
|
|
EXPECT_EQ(1, OperatorProperties::GetEffectOutputCount(op));
|
|
EXPECT_EQ(0, OperatorProperties::GetValueOutputCount(op));
|
|
}
|
|
}
|
|
|
|
|
|
TEST_F(CommonOperatorTest, Finish) {
|
|
TRACED_FOREACH(int, arguments, kArguments) {
|
|
const Operator* op = common()->Finish(arguments);
|
|
EXPECT_EQ(1, OperatorProperties::GetValueInputCount(op));
|
|
EXPECT_EQ(arguments, OperatorProperties::GetEffectInputCount(op));
|
|
EXPECT_EQ(arguments + 1, OperatorProperties::GetTotalInputCount(op));
|
|
EXPECT_EQ(0, OperatorProperties::GetControlOutputCount(op));
|
|
EXPECT_EQ(0, OperatorProperties::GetEffectOutputCount(op));
|
|
EXPECT_EQ(1, OperatorProperties::GetValueOutputCount(op));
|
|
}
|
|
}
|
|
|
|
} // namespace compiler
|
|
} // namespace internal
|
|
} // namespace v8
|