6e700b7f76
In commit b3bfc0bd58, I corrected the source
position of yield-exceptions by not setting the "return position" on returns
that correspond to yields. It turns out that this caused a bug with debug
stepping. The proper fix is to keep the return position on those returns but
additionally attach the yield's source position to the Throw emitted in
VisitYield.
R=rmcilroy@chromium.org, yangguo@chromium.org
BUG=v8:4907
Review-Url: https://codereview.chromium.org/2051783002
Cr-Commit-Position: refs/heads/master@{#36896}
46 lines
948 B
JavaScript
46 lines
948 B
JavaScript
// Copyright 2014 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --expose-debug-as debug --ignition-generators
|
|
|
|
Debug = debug.Debug
|
|
var exception = null;
|
|
var yields = 0;
|
|
|
|
function listener(event, exec_state, event_data, data) {
|
|
if (event != Debug.DebugEvent.Break) return;
|
|
try {
|
|
var source = exec_state.frame(0).sourceLineText();
|
|
print(source);
|
|
if (/stop stepping/.test(source)) return;
|
|
if (/yield/.test(source)) yields++;
|
|
exec_state.prepareStep(Debug.StepAction.StepIn);
|
|
} catch (e) {
|
|
print(e, e.stack);
|
|
exception = e;
|
|
}
|
|
};
|
|
|
|
Debug.setListener(listener);
|
|
|
|
function* g() {
|
|
for (var i = 0; i < 3; ++i) {
|
|
yield i;
|
|
}
|
|
}
|
|
|
|
var i = g();
|
|
debugger;
|
|
for (var num of g()) {}
|
|
i.next();
|
|
|
|
print(); // stop stepping
|
|
|
|
// Not stepped into.
|
|
i.next();
|
|
i.next();
|
|
|
|
assertNull(exception);
|
|
assertEquals(4, yields);
|