2b4c9c100b
The GetStackPointer() routine in test-platform uses an inline
assembly code to store the current stack pointer value into a static
variable sp_addr. The existing asm code for S390 uses an ST/STG
instruction, with the memory operand associated with the general ('=g')
constraint to sp_addr.
On GCC 4.8.5, the GCC compiler got confused and treated sp_addr as
an integer operand instead of memory operand, resulting in a store
being emitted that writes to an invalid meory location.
Given the specific store instructions being inlined here, we should
restict the sp_addr operand to explicitly be a memory operand using '=m'
instead of '=g'.
R=bmeurer@chromium.org,jkummerow@chormium.org,rmcilroy@chromium.org,yangguo@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/2158523002
Cr-Commit-Position: refs/heads/master@{#37809}
71 lines
2.4 KiB
C++
71 lines
2.4 KiB
C++
// Copyright 2013 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include <stdint.h>
|
|
#include "src/base/build_config.h"
|
|
#include "src/base/platform/platform.h"
|
|
#include "test/cctest/cctest.h"
|
|
|
|
#ifdef V8_CC_GNU
|
|
|
|
static uintptr_t sp_addr = 0;
|
|
|
|
void GetStackPointer(const v8::FunctionCallbackInfo<v8::Value>& args) {
|
|
#if V8_HOST_ARCH_X64
|
|
__asm__ __volatile__("mov %%rsp, %0" : "=g"(sp_addr));
|
|
#elif V8_HOST_ARCH_IA32
|
|
__asm__ __volatile__("mov %%esp, %0" : "=g"(sp_addr));
|
|
#elif V8_HOST_ARCH_ARM
|
|
__asm__ __volatile__("str sp, %0" : "=g"(sp_addr));
|
|
#elif V8_HOST_ARCH_ARM64
|
|
__asm__ __volatile__("mov x16, sp; str x16, %0" : "=g"(sp_addr));
|
|
#elif V8_HOST_ARCH_MIPS
|
|
__asm__ __volatile__("sw $sp, %0" : "=g"(sp_addr));
|
|
#elif V8_HOST_ARCH_MIPS64
|
|
__asm__ __volatile__("sd $sp, %0" : "=g"(sp_addr));
|
|
#elif defined(__s390x__) || defined(_ARCH_S390X)
|
|
__asm__ __volatile__("stg 15, %0" : "=m"(sp_addr));
|
|
#elif defined(__s390__) || defined(_ARCH_S390)
|
|
__asm__ __volatile__("st 15, %0" : "=m"(sp_addr));
|
|
#elif defined(__PPC64__) || defined(_ARCH_PPC64)
|
|
__asm__ __volatile__("std 1, %0" : "=g"(sp_addr));
|
|
#elif defined(__PPC__) || defined(_ARCH_PPC)
|
|
__asm__ __volatile__("stw 1, %0" : "=g"(sp_addr));
|
|
#else
|
|
#error Host architecture was not detected as supported by v8
|
|
#endif
|
|
|
|
args.GetReturnValue().Set(v8::Integer::NewFromUnsigned(
|
|
args.GetIsolate(), static_cast<uint32_t>(sp_addr)));
|
|
}
|
|
|
|
|
|
TEST(StackAlignment) {
|
|
v8::Isolate* isolate = CcTest::isolate();
|
|
v8::HandleScope handle_scope(isolate);
|
|
v8::Local<v8::ObjectTemplate> global_template =
|
|
v8::ObjectTemplate::New(isolate);
|
|
global_template->Set(v8_str("get_stack_pointer"),
|
|
v8::FunctionTemplate::New(isolate, GetStackPointer));
|
|
|
|
LocalContext env(NULL, global_template);
|
|
CompileRun(
|
|
"function foo() {"
|
|
" return get_stack_pointer();"
|
|
"}");
|
|
|
|
v8::Local<v8::Object> global_object = env->Global();
|
|
v8::Local<v8::Function> foo = v8::Local<v8::Function>::Cast(
|
|
global_object->Get(isolate->GetCurrentContext(), v8_str("foo"))
|
|
.ToLocalChecked());
|
|
|
|
v8::Local<v8::Value> result =
|
|
foo->Call(isolate->GetCurrentContext(), global_object, 0, NULL)
|
|
.ToLocalChecked();
|
|
CHECK_EQ(0u, result->Uint32Value(isolate->GetCurrentContext()).FromJust() %
|
|
v8::base::OS::ActivationFrameAlignment());
|
|
}
|
|
|
|
#endif // V8_CC_GNU
|