bcee140617
This adds a new InstanceOfIC where the TestInstanceOf bytecode collects constant feedback about the right-hand side of instanceof operators, including both JSFunction and JSBoundFunction instances. TurboFan then uses the feedback to optimize instanceof in places where the right-hand side is not a known constant (known to TurboFan). This addresses the odd performance cliff that we see with instanceof in functions with multiple closures. It was discovered as one of the main bottlenecks on the uglify-es test in the web-tooling-benchmark. The uglify-es test (run in separation) is ~18% faster with this change. On the micro-benchmark in the tracking bug we go from instanceofSingleClosure_Const: 69 ms. instanceofSingleClosure_Class: 246 ms. instanceofMultiClosure: 246 ms. instanceofParameter: 246 ms. to instanceofSingleClosure_Const: 70 ms. instanceofSingleClosure_Class: 75 ms. instanceofMultiClosure: 76 ms. instanceofParameter: 73 ms. boosting performance by roughly 3.6x and thus effectively removing the performance cliff around instanceof. Bug: v8:6936, v8:6971 Change-Id: Ib88dbb9eaef9cafa4a0e260fbbde73427a54046e Reviewed-on: https://chromium-review.googlesource.com/730686 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#48820}
164 lines
3.0 KiB
JavaScript
164 lines
3.0 KiB
JavaScript
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --allow-natives-syntax
|
|
|
|
function A() {}
|
|
var a = new A();
|
|
|
|
var B = {
|
|
[Symbol.hasInstance](o) {
|
|
return false;
|
|
}
|
|
};
|
|
%ToFastProperties(B.__proto__);
|
|
|
|
var C = Object.create({
|
|
[Symbol.hasInstance](o) {
|
|
return true;
|
|
}
|
|
});
|
|
%ToFastProperties(C.__proto__);
|
|
|
|
var D = Object.create({
|
|
[Symbol.hasInstance](o) {
|
|
return o === a;
|
|
}
|
|
});
|
|
%ToFastProperties(D.__proto__);
|
|
|
|
var E = Object.create({
|
|
[Symbol.hasInstance](o) {
|
|
if (o === a) throw o;
|
|
return true;
|
|
}
|
|
});
|
|
%ToFastProperties(E.__proto__);
|
|
|
|
function F() {}
|
|
F.__proto__ = null;
|
|
|
|
(function() {
|
|
function foo(o) { return o instanceof A; }
|
|
|
|
assertTrue(foo(a));
|
|
assertTrue(foo(a));
|
|
assertTrue(foo(new A()));
|
|
%OptimizeFunctionOnNextCall(foo);
|
|
assertTrue(foo(a));
|
|
assertTrue(foo(new A()));
|
|
})();
|
|
|
|
(function() {
|
|
function foo(o) {
|
|
try {
|
|
return o instanceof A;
|
|
} catch (e) {
|
|
return e;
|
|
}
|
|
}
|
|
|
|
assertTrue(foo(a));
|
|
assertTrue(foo(a));
|
|
assertTrue(foo(new A()));
|
|
assertEquals(1, foo(new Proxy({}, {getPrototypeOf() { throw 1; }})));
|
|
%OptimizeFunctionOnNextCall(foo);
|
|
assertTrue(foo(a));
|
|
assertTrue(foo(new A()));
|
|
assertEquals(1, foo(new Proxy({}, {getPrototypeOf() { throw 1; }})));
|
|
})();
|
|
|
|
(function() {
|
|
function foo(o) { return o instanceof B; }
|
|
|
|
assertFalse(foo(a));
|
|
assertFalse(foo(a));
|
|
assertFalse(foo(new A()));
|
|
%OptimizeFunctionOnNextCall(foo);
|
|
assertFalse(foo(a));
|
|
assertFalse(foo(new A()));
|
|
})();
|
|
|
|
(function() {
|
|
function foo(o) { return o instanceof C; }
|
|
|
|
assertTrue(foo(a));
|
|
assertTrue(foo(a));
|
|
assertTrue(foo(new A()));
|
|
%OptimizeFunctionOnNextCall(foo);
|
|
assertTrue(foo(a));
|
|
assertTrue(foo(new A()));
|
|
})();
|
|
|
|
(function() {
|
|
function foo(o) { return o instanceof D; }
|
|
|
|
assertTrue(foo(a));
|
|
assertTrue(foo(a));
|
|
assertFalse(foo(new A()));
|
|
%OptimizeFunctionOnNextCall(foo);
|
|
assertTrue(foo(a));
|
|
assertFalse(foo(new A()));
|
|
})();
|
|
|
|
(function() {
|
|
function foo(o) {
|
|
try {
|
|
return o instanceof E;
|
|
} catch (e) {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
assertFalse(foo(a));
|
|
assertTrue(foo(new A()));
|
|
%OptimizeFunctionOnNextCall(foo);
|
|
assertFalse(foo(a));
|
|
assertTrue(foo(new A()));
|
|
})();
|
|
|
|
(function() {
|
|
function foo(o) {
|
|
return o instanceof F;
|
|
}
|
|
|
|
assertFalse(foo(a));
|
|
assertFalse(foo(new A()));
|
|
assertTrue(foo(new F()));
|
|
%OptimizeFunctionOnNextCall(foo);
|
|
assertFalse(foo(a));
|
|
assertFalse(foo(new A()));
|
|
assertTrue(foo(new F()));
|
|
})();
|
|
|
|
(function() {
|
|
function foo() {
|
|
var a = new A();
|
|
return a instanceof A;
|
|
}
|
|
|
|
assertTrue(foo());
|
|
assertTrue(foo());
|
|
%OptimizeFunctionOnNextCall(foo);
|
|
assertTrue(foo());
|
|
})();
|
|
|
|
(function() {
|
|
class B extends A {};
|
|
|
|
function makeFoo() {
|
|
return function foo(b) {
|
|
return b instanceof B;
|
|
}
|
|
}
|
|
makeFoo();
|
|
const foo = makeFoo();
|
|
|
|
assertTrue(foo(new B));
|
|
assertFalse(foo(new A));
|
|
%OptimizeFunctionOnNextCall(foo);
|
|
assertTrue(foo(new B));
|
|
assertFalse(foo(new A));
|
|
})();
|