cebfde6769
The function-entry stack check should dominate all other
instructions in a function. Prior to this CL it was possible to create
paths not including a stack check due to SwitchOnGeneratorState: the
generator-creation branch had a stack check, while generator-resume
branches did not.
0 : af fb 00 01 SwitchOnGeneratorState r0, [0], [1] { 0: @22 }
4 : 27 fe fa Mov <closure>, r1
7 : 27 02 f9 Mov <this>, r2
10 : 64 0a fa 02 InvokeIntrinsic [_CreateJSGeneratorObject], r1-r2
14 : 26 fb Star r0
16 : a7 StackCheck
17 : b0 fb fb 01 00 SuspendGenerator r0, r0-r0, [0]
22 : b1 fb fb 01 ResumeGenerator r0, r0-r0
[... no stack check here ...]
This CL moves the stack check to the beginning of the bytecode array,
i.e. before SwitchOnGeneratorState.
Bug: chromium:1020031
Change-Id: I8ba8cba99611ddbe50c76023129d926cc84b1d5e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1903440
Reviewed-by: Georg Neis <neis@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64888}
350 lines
12 KiB
Plaintext
350 lines
12 KiB
Plaintext
#
|
|
# Autogenerated by generate-bytecode-expectations.
|
|
#
|
|
|
|
---
|
|
wrap: no
|
|
module: yes
|
|
top level: yes
|
|
top level await: yes
|
|
|
|
---
|
|
snippet: "
|
|
await 42;
|
|
"
|
|
frame size: 8
|
|
parameter count: 2
|
|
bytecode array length: 142
|
|
bytecodes: [
|
|
/* 0 E> */ B(StackCheck),
|
|
B(SwitchOnGeneratorState), R(0), U8(0), U8(2),
|
|
B(LdaConstant), U8(2),
|
|
B(Star), R(3),
|
|
B(Mov), R(arg0), R(2),
|
|
B(CallRuntime), U16(Runtime::kPushModuleContext), R(2), U8(2),
|
|
B(PushContext), R(2),
|
|
B(Mov), R(closure), R(3),
|
|
B(Mov), R(this), R(4),
|
|
B(InvokeIntrinsic), U8(Runtime::k_AsyncFunctionEnter), R(3), U8(2),
|
|
B(Star), R(0),
|
|
/* 0 E> */ B(SuspendGenerator), R(0), R(0), U8(3), U8(0),
|
|
B(ResumeGenerator), R(0), R(0), U8(3),
|
|
B(Star), R(3),
|
|
B(InvokeIntrinsic), U8(Runtime::k_GeneratorGetResumeMode), R(0), U8(1),
|
|
B(SwitchOnSmiNoFeedback), U8(3), U8(2), I8(0),
|
|
B(Ldar), R(3),
|
|
/* 0 E> */ B(Throw),
|
|
B(Ldar), R(3),
|
|
/* 10 S> */ B(Return),
|
|
B(Mov), R(3), R(1),
|
|
B(Ldar), R(1),
|
|
B(Mov), R(context), R(3),
|
|
/* 0 S> */ B(LdaSmi), I8(42),
|
|
B(Star), R(5),
|
|
B(Mov), R(0), R(4),
|
|
B(InvokeIntrinsic), U8(Runtime::k_AsyncFunctionAwaitUncaught), R(4), U8(2),
|
|
/* 0 E> */ B(SuspendGenerator), R(0), R(0), U8(4), U8(1),
|
|
B(ResumeGenerator), R(0), R(0), U8(4),
|
|
B(Star), R(4),
|
|
B(InvokeIntrinsic), U8(Runtime::k_GeneratorGetResumeMode), R(0), U8(1),
|
|
B(Star), R(5),
|
|
B(LdaZero),
|
|
B(TestReferenceEqual), R(5),
|
|
B(JumpIfTrue), U8(5),
|
|
B(Ldar), R(4),
|
|
B(ReThrow),
|
|
B(LdaUndefined),
|
|
B(Star), R(5),
|
|
B(LdaTrue),
|
|
B(Star), R(6),
|
|
B(Mov), R(0), R(4),
|
|
B(InvokeIntrinsic), U8(Runtime::k_AsyncFunctionResolve), R(4), U8(3),
|
|
/* 10 S> */ B(Return),
|
|
B(Star), R(4),
|
|
B(CreateCatchContext), R(4), U8(5),
|
|
B(Star), R(3),
|
|
B(LdaTheHole),
|
|
B(SetPendingMessage),
|
|
B(Ldar), R(3),
|
|
B(PushContext), R(4),
|
|
B(LdaImmutableCurrentContextSlot), U8(2),
|
|
B(Star), R(6),
|
|
B(LdaTrue),
|
|
B(Star), R(7),
|
|
B(Mov), R(0), R(5),
|
|
B(InvokeIntrinsic), U8(Runtime::k_AsyncFunctionReject), R(5), U8(3),
|
|
/* 10 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
Smi [35],
|
|
Smi [79],
|
|
SCOPE_INFO_TYPE,
|
|
Smi [10],
|
|
Smi [7],
|
|
SCOPE_INFO_TYPE,
|
|
]
|
|
handlers: [
|
|
[64, 114, 114],
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
await import(\"foo\");
|
|
"
|
|
frame size: 8
|
|
parameter count: 2
|
|
bytecode array length: 152
|
|
bytecodes: [
|
|
/* 0 E> */ B(StackCheck),
|
|
B(SwitchOnGeneratorState), R(0), U8(0), U8(2),
|
|
B(LdaConstant), U8(2),
|
|
B(Star), R(3),
|
|
B(Mov), R(arg0), R(2),
|
|
B(CallRuntime), U16(Runtime::kPushModuleContext), R(2), U8(2),
|
|
B(PushContext), R(2),
|
|
B(Mov), R(closure), R(3),
|
|
B(Mov), R(this), R(4),
|
|
B(InvokeIntrinsic), U8(Runtime::k_AsyncFunctionEnter), R(3), U8(2),
|
|
B(Star), R(0),
|
|
/* 0 E> */ B(SuspendGenerator), R(0), R(0), U8(3), U8(0),
|
|
B(ResumeGenerator), R(0), R(0), U8(3),
|
|
B(Star), R(3),
|
|
B(InvokeIntrinsic), U8(Runtime::k_GeneratorGetResumeMode), R(0), U8(1),
|
|
B(SwitchOnSmiNoFeedback), U8(3), U8(2), I8(0),
|
|
B(Ldar), R(3),
|
|
/* 0 E> */ B(Throw),
|
|
B(Ldar), R(3),
|
|
/* 21 S> */ B(Return),
|
|
B(Mov), R(3), R(1),
|
|
B(Ldar), R(1),
|
|
B(Mov), R(context), R(3),
|
|
/* 0 S> */ B(LdaConstant), U8(5),
|
|
B(Star), R(5),
|
|
B(Mov), R(closure), R(4),
|
|
B(CallRuntime), U16(Runtime::kDynamicImportCall), R(4), U8(2),
|
|
B(Star), R(5),
|
|
B(Mov), R(0), R(4),
|
|
B(InvokeIntrinsic), U8(Runtime::k_AsyncFunctionAwaitUncaught), R(4), U8(2),
|
|
/* 0 E> */ B(SuspendGenerator), R(0), R(0), U8(4), U8(1),
|
|
B(ResumeGenerator), R(0), R(0), U8(4),
|
|
B(Star), R(4),
|
|
B(InvokeIntrinsic), U8(Runtime::k_GeneratorGetResumeMode), R(0), U8(1),
|
|
B(Star), R(5),
|
|
B(LdaZero),
|
|
B(TestReferenceEqual), R(5),
|
|
B(JumpIfTrue), U8(5),
|
|
B(Ldar), R(4),
|
|
B(ReThrow),
|
|
B(LdaUndefined),
|
|
B(Star), R(5),
|
|
B(LdaTrue),
|
|
B(Star), R(6),
|
|
B(Mov), R(0), R(4),
|
|
B(InvokeIntrinsic), U8(Runtime::k_AsyncFunctionResolve), R(4), U8(3),
|
|
/* 21 S> */ B(Return),
|
|
B(Star), R(4),
|
|
B(CreateCatchContext), R(4), U8(6),
|
|
B(Star), R(3),
|
|
B(LdaTheHole),
|
|
B(SetPendingMessage),
|
|
B(Ldar), R(3),
|
|
B(PushContext), R(4),
|
|
B(LdaImmutableCurrentContextSlot), U8(2),
|
|
B(Star), R(6),
|
|
B(LdaTrue),
|
|
B(Star), R(7),
|
|
B(Mov), R(0), R(5),
|
|
B(InvokeIntrinsic), U8(Runtime::k_AsyncFunctionReject), R(5), U8(3),
|
|
/* 21 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
Smi [35],
|
|
Smi [89],
|
|
SCOPE_INFO_TYPE,
|
|
Smi [10],
|
|
Smi [7],
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["foo"],
|
|
SCOPE_INFO_TYPE,
|
|
]
|
|
handlers: [
|
|
[64, 124, 124],
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
await 42;
|
|
async function foo() {
|
|
await 42;
|
|
}
|
|
foo();
|
|
"
|
|
frame size: 9
|
|
parameter count: 2
|
|
bytecode array length: 153
|
|
bytecodes: [
|
|
/* 0 E> */ B(StackCheck),
|
|
B(SwitchOnGeneratorState), R(0), U8(0), U8(2),
|
|
B(LdaConstant), U8(2),
|
|
B(Star), R(4),
|
|
B(Mov), R(arg0), R(3),
|
|
B(CallRuntime), U16(Runtime::kPushModuleContext), R(3), U8(2),
|
|
B(PushContext), R(3),
|
|
B(Mov), R(closure), R(4),
|
|
B(Mov), R(this), R(5),
|
|
B(InvokeIntrinsic), U8(Runtime::k_AsyncFunctionEnter), R(4), U8(2),
|
|
B(Star), R(0),
|
|
B(CreateClosure), U8(3), U8(0), U8(0),
|
|
B(Star), R(1),
|
|
B(Ldar), R(0),
|
|
/* 0 E> */ B(SuspendGenerator), R(0), R(0), U8(4), U8(0),
|
|
B(ResumeGenerator), R(0), R(0), U8(4),
|
|
B(Star), R(4),
|
|
B(InvokeIntrinsic), U8(Runtime::k_GeneratorGetResumeMode), R(0), U8(1),
|
|
B(SwitchOnSmiNoFeedback), U8(4), U8(2), I8(0),
|
|
B(Ldar), R(4),
|
|
/* 0 E> */ B(Throw),
|
|
B(Ldar), R(4),
|
|
/* 54 S> */ B(Return),
|
|
B(Mov), R(4), R(2),
|
|
B(Ldar), R(2),
|
|
B(Mov), R(context), R(4),
|
|
/* 0 S> */ B(LdaSmi), I8(42),
|
|
B(Star), R(6),
|
|
B(Mov), R(0), R(5),
|
|
B(InvokeIntrinsic), U8(Runtime::k_AsyncFunctionAwaitUncaught), R(5), U8(2),
|
|
/* 0 E> */ B(SuspendGenerator), R(0), R(0), U8(5), U8(1),
|
|
B(ResumeGenerator), R(0), R(0), U8(5),
|
|
B(Star), R(5),
|
|
B(InvokeIntrinsic), U8(Runtime::k_GeneratorGetResumeMode), R(0), U8(1),
|
|
B(Star), R(6),
|
|
B(LdaZero),
|
|
B(TestReferenceEqual), R(6),
|
|
B(JumpIfTrue), U8(5),
|
|
B(Ldar), R(5),
|
|
B(ReThrow),
|
|
/* 47 S> */ B(CallUndefinedReceiver0), R(1), U8(0),
|
|
B(LdaUndefined),
|
|
B(Star), R(6),
|
|
B(LdaTrue),
|
|
B(Star), R(7),
|
|
B(Mov), R(0), R(5),
|
|
B(InvokeIntrinsic), U8(Runtime::k_AsyncFunctionResolve), R(5), U8(3),
|
|
/* 54 S> */ B(Return),
|
|
B(Star), R(5),
|
|
B(CreateCatchContext), R(5), U8(6),
|
|
B(Star), R(4),
|
|
B(LdaTheHole),
|
|
B(SetPendingMessage),
|
|
B(Ldar), R(4),
|
|
B(PushContext), R(5),
|
|
B(LdaImmutableCurrentContextSlot), U8(2),
|
|
B(Star), R(7),
|
|
B(LdaTrue),
|
|
B(Star), R(8),
|
|
B(Mov), R(0), R(6),
|
|
B(InvokeIntrinsic), U8(Runtime::k_AsyncFunctionReject), R(6), U8(3),
|
|
/* 54 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
Smi [43],
|
|
Smi [87],
|
|
SCOPE_INFO_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
Smi [10],
|
|
Smi [7],
|
|
SCOPE_INFO_TYPE,
|
|
]
|
|
handlers: [
|
|
[72, 125, 125],
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
import * as foo from \"bar\";
|
|
await import(\"goo\");
|
|
"
|
|
frame size: 9
|
|
parameter count: 2
|
|
bytecode array length: 164
|
|
bytecodes: [
|
|
/* 0 E> */ B(StackCheck),
|
|
B(SwitchOnGeneratorState), R(0), U8(0), U8(2),
|
|
B(LdaConstant), U8(2),
|
|
B(Star), R(4),
|
|
B(Mov), R(arg0), R(3),
|
|
B(CallRuntime), U16(Runtime::kPushModuleContext), R(3), U8(2),
|
|
B(PushContext), R(3),
|
|
B(Mov), R(closure), R(4),
|
|
B(Mov), R(this), R(5),
|
|
B(InvokeIntrinsic), U8(Runtime::k_AsyncFunctionEnter), R(4), U8(2),
|
|
B(Star), R(0),
|
|
B(LdaZero),
|
|
B(Star), R(4),
|
|
B(CallRuntime), U16(Runtime::kGetModuleNamespace), R(4), U8(1),
|
|
B(Star), R(1),
|
|
B(Ldar), R(0),
|
|
/* 0 E> */ B(SuspendGenerator), R(0), R(0), U8(4), U8(0),
|
|
B(ResumeGenerator), R(0), R(0), U8(4),
|
|
B(Star), R(4),
|
|
B(InvokeIntrinsic), U8(Runtime::k_GeneratorGetResumeMode), R(0), U8(1),
|
|
B(SwitchOnSmiNoFeedback), U8(3), U8(2), I8(0),
|
|
B(Ldar), R(4),
|
|
/* 0 E> */ B(Throw),
|
|
B(Ldar), R(4),
|
|
/* 49 S> */ B(Return),
|
|
B(Mov), R(4), R(2),
|
|
B(Ldar), R(2),
|
|
B(Mov), R(context), R(4),
|
|
/* 28 S> */ B(LdaConstant), U8(5),
|
|
B(Star), R(6),
|
|
B(Mov), R(closure), R(5),
|
|
B(CallRuntime), U16(Runtime::kDynamicImportCall), R(5), U8(2),
|
|
B(Star), R(6),
|
|
B(Mov), R(0), R(5),
|
|
B(InvokeIntrinsic), U8(Runtime::k_AsyncFunctionAwaitUncaught), R(5), U8(2),
|
|
/* 28 E> */ B(SuspendGenerator), R(0), R(0), U8(5), U8(1),
|
|
B(ResumeGenerator), R(0), R(0), U8(5),
|
|
B(Star), R(5),
|
|
B(InvokeIntrinsic), U8(Runtime::k_GeneratorGetResumeMode), R(0), U8(1),
|
|
B(Star), R(6),
|
|
B(LdaZero),
|
|
B(TestReferenceEqual), R(6),
|
|
B(JumpIfTrue), U8(5),
|
|
B(Ldar), R(5),
|
|
B(ReThrow),
|
|
B(LdaUndefined),
|
|
B(Star), R(6),
|
|
B(LdaTrue),
|
|
B(Star), R(7),
|
|
B(Mov), R(0), R(5),
|
|
B(InvokeIntrinsic), U8(Runtime::k_AsyncFunctionResolve), R(5), U8(3),
|
|
/* 49 S> */ B(Return),
|
|
B(Star), R(5),
|
|
B(CreateCatchContext), R(5), U8(6),
|
|
B(Star), R(4),
|
|
B(LdaTheHole),
|
|
B(SetPendingMessage),
|
|
B(Ldar), R(4),
|
|
B(PushContext), R(5),
|
|
B(LdaImmutableCurrentContextSlot), U8(2),
|
|
B(Star), R(7),
|
|
B(LdaTrue),
|
|
B(Star), R(8),
|
|
B(Mov), R(0), R(6),
|
|
B(InvokeIntrinsic), U8(Runtime::k_AsyncFunctionReject), R(6), U8(3),
|
|
/* 49 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
Smi [47],
|
|
Smi [101],
|
|
SCOPE_INFO_TYPE,
|
|
Smi [10],
|
|
Smi [7],
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["goo"],
|
|
SCOPE_INFO_TYPE,
|
|
]
|
|
handlers: [
|
|
[76, 136, 136],
|
|
]
|
|
|