cebfde6769
The function-entry stack check should dominate all other
instructions in a function. Prior to this CL it was possible to create
paths not including a stack check due to SwitchOnGeneratorState: the
generator-creation branch had a stack check, while generator-resume
branches did not.
0 : af fb 00 01 SwitchOnGeneratorState r0, [0], [1] { 0: @22 }
4 : 27 fe fa Mov <closure>, r1
7 : 27 02 f9 Mov <this>, r2
10 : 64 0a fa 02 InvokeIntrinsic [_CreateJSGeneratorObject], r1-r2
14 : 26 fb Star r0
16 : a7 StackCheck
17 : b0 fb fb 01 00 SuspendGenerator r0, r0-r0, [0]
22 : b1 fb fb 01 ResumeGenerator r0, r0-r0
[... no stack check here ...]
This CL moves the stack check to the beginning of the bytecode array,
i.e. before SwitchOnGeneratorState.
Bug: chromium:1020031
Change-Id: I8ba8cba99611ddbe50c76023129d926cc84b1d5e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1903440
Reviewed-by: Georg Neis <neis@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64888}
112 lines
2.5 KiB
Plaintext
112 lines
2.5 KiB
Plaintext
#
|
|
# Autogenerated by generate-bytecode-expectations.
|
|
#
|
|
|
|
---
|
|
wrap: yes
|
|
|
|
---
|
|
snippet: "
|
|
let x = 10; function f1() {return x;}
|
|
"
|
|
frame size: 1
|
|
parameter count: 1
|
|
bytecode array length: 15
|
|
bytecodes: [
|
|
/* 30 E> */ B(StackCheck),
|
|
B(CreateFunctionContext), U8(0), U8(1),
|
|
B(PushContext), R(0),
|
|
B(LdaTheHole),
|
|
B(StaCurrentContextSlot), U8(2),
|
|
/* 42 S> */ B(LdaSmi), I8(10),
|
|
/* 42 E> */ B(StaCurrentContextSlot), U8(2),
|
|
B(LdaUndefined),
|
|
/* 72 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
SCOPE_INFO_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
let x = 10; function f1() {return x;} return x;
|
|
"
|
|
frame size: 1
|
|
parameter count: 1
|
|
bytecode array length: 16
|
|
bytecodes: [
|
|
/* 30 E> */ B(StackCheck),
|
|
B(CreateFunctionContext), U8(0), U8(1),
|
|
B(PushContext), R(0),
|
|
B(LdaTheHole),
|
|
B(StaCurrentContextSlot), U8(2),
|
|
/* 42 S> */ B(LdaSmi), I8(10),
|
|
/* 42 E> */ B(StaCurrentContextSlot), U8(2),
|
|
/* 72 S> */ B(LdaImmutableCurrentContextSlot), U8(2),
|
|
/* 81 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
SCOPE_INFO_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
let x = (x = 20); function f1() {return x;}
|
|
"
|
|
frame size: 2
|
|
parameter count: 1
|
|
bytecode array length: 25
|
|
bytecodes: [
|
|
/* 30 E> */ B(StackCheck),
|
|
B(CreateFunctionContext), U8(0), U8(1),
|
|
B(PushContext), R(0),
|
|
B(LdaTheHole),
|
|
B(StaCurrentContextSlot), U8(2),
|
|
/* 42 S> */ B(LdaSmi), I8(20),
|
|
B(Star), R(1),
|
|
B(LdaCurrentContextSlot), U8(2),
|
|
/* 45 E> */ B(ThrowReferenceErrorIfHole), U8(1),
|
|
B(Ldar), R(1),
|
|
B(StaCurrentContextSlot), U8(2),
|
|
/* 42 E> */ B(StaCurrentContextSlot), U8(2),
|
|
B(LdaUndefined),
|
|
/* 78 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
SCOPE_INFO_TYPE,
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["x"],
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
let x = 10; x = 20; function f1() {return x;}
|
|
"
|
|
frame size: 1
|
|
parameter count: 1
|
|
bytecode array length: 19
|
|
bytecodes: [
|
|
/* 30 E> */ B(StackCheck),
|
|
B(CreateFunctionContext), U8(0), U8(1),
|
|
B(PushContext), R(0),
|
|
B(LdaTheHole),
|
|
B(StaCurrentContextSlot), U8(2),
|
|
/* 42 S> */ B(LdaSmi), I8(10),
|
|
/* 42 E> */ B(StaCurrentContextSlot), U8(2),
|
|
/* 46 S> */ B(LdaSmi), I8(20),
|
|
/* 48 E> */ B(StaCurrentContextSlot), U8(2),
|
|
B(LdaUndefined),
|
|
/* 80 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
SCOPE_INFO_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|