c1435b0832
BUG= R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/236203010 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20728 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
258 lines
9.5 KiB
C++
258 lines
9.5 KiB
C++
// Copyright 2011 the V8 project authors. All rights reserved.
|
|
// Redistribution and use in source and binary forms, with or without
|
|
// modification, are permitted provided that the following conditions are
|
|
// met:
|
|
//
|
|
// * Redistributions of source code must retain the above copyright
|
|
// notice, this list of conditions and the following disclaimer.
|
|
// * Redistributions in binary form must reproduce the above
|
|
// copyright notice, this list of conditions and the following
|
|
// disclaimer in the documentation and/or other materials provided
|
|
// with the distribution.
|
|
// * Neither the name of Google Inc. nor the names of its
|
|
// contributors may be used to endorse or promote products derived
|
|
// from this software without specific prior written permission.
|
|
//
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
#include <utility>
|
|
|
|
#include "v8.h"
|
|
|
|
#include "global-handles.h"
|
|
#include "snapshot.h"
|
|
#include "cctest.h"
|
|
|
|
using namespace v8::internal;
|
|
|
|
|
|
static Isolate* GetIsolateFrom(LocalContext* context) {
|
|
return reinterpret_cast<Isolate*>((*context)->GetIsolate());
|
|
}
|
|
|
|
|
|
static Handle<JSWeakSet> AllocateJSWeakSet(Isolate* isolate) {
|
|
Factory* factory = isolate->factory();
|
|
Heap* heap = isolate->heap();
|
|
Handle<Map> map = factory->NewMap(JS_WEAK_SET_TYPE, JSWeakSet::kSize);
|
|
Handle<JSObject> weakset_obj = factory->NewJSObjectFromMap(map);
|
|
Handle<JSWeakSet> weakset(JSWeakSet::cast(*weakset_obj));
|
|
// Do not use handles for the hash table, it would make entries strong.
|
|
Object* table_obj = ObjectHashTable::Allocate(heap, 1)->ToObjectChecked();
|
|
ObjectHashTable* table = ObjectHashTable::cast(table_obj);
|
|
weakset->set_table(table);
|
|
weakset->set_next(Smi::FromInt(0));
|
|
return weakset;
|
|
}
|
|
|
|
static void PutIntoWeakSet(Handle<JSWeakSet> weakset,
|
|
Handle<JSObject> key,
|
|
Handle<Object> value) {
|
|
Handle<ObjectHashTable> table = ObjectHashTable::Put(
|
|
Handle<ObjectHashTable>(ObjectHashTable::cast(weakset->table())),
|
|
Handle<JSObject>(JSObject::cast(*key)),
|
|
value);
|
|
weakset->set_table(*table);
|
|
}
|
|
|
|
static int NumberOfWeakCalls = 0;
|
|
static void WeakPointerCallback(
|
|
const v8::WeakCallbackData<v8::Value, void>& data) {
|
|
std::pair<v8::Persistent<v8::Value>*, int>* p =
|
|
reinterpret_cast<std::pair<v8::Persistent<v8::Value>*, int>*>(
|
|
data.GetParameter());
|
|
ASSERT_EQ(1234, p->second);
|
|
NumberOfWeakCalls++;
|
|
p->first->Reset();
|
|
}
|
|
|
|
|
|
TEST(WeakSet_Weakness) {
|
|
FLAG_incremental_marking = false;
|
|
LocalContext context;
|
|
Isolate* isolate = GetIsolateFrom(&context);
|
|
Factory* factory = isolate->factory();
|
|
Heap* heap = isolate->heap();
|
|
HandleScope scope(isolate);
|
|
Handle<JSWeakSet> weakset = AllocateJSWeakSet(isolate);
|
|
GlobalHandles* global_handles = isolate->global_handles();
|
|
|
|
// Keep global reference to the key.
|
|
Handle<Object> key;
|
|
{
|
|
HandleScope scope(isolate);
|
|
Handle<Map> map = factory->NewMap(JS_OBJECT_TYPE, JSObject::kHeaderSize);
|
|
Handle<JSObject> object = factory->NewJSObjectFromMap(map);
|
|
key = global_handles->Create(*object);
|
|
}
|
|
CHECK(!global_handles->IsWeak(key.location()));
|
|
|
|
// Put entry into weak set.
|
|
{
|
|
HandleScope scope(isolate);
|
|
PutIntoWeakSet(weakset,
|
|
Handle<JSObject>(JSObject::cast(*key)),
|
|
Handle<Smi>(Smi::FromInt(23), isolate));
|
|
}
|
|
CHECK_EQ(1, ObjectHashTable::cast(weakset->table())->NumberOfElements());
|
|
|
|
// Force a full GC.
|
|
heap->CollectAllGarbage(false);
|
|
CHECK_EQ(0, NumberOfWeakCalls);
|
|
CHECK_EQ(1, ObjectHashTable::cast(weakset->table())->NumberOfElements());
|
|
CHECK_EQ(
|
|
0, ObjectHashTable::cast(weakset->table())->NumberOfDeletedElements());
|
|
|
|
// Make the global reference to the key weak.
|
|
{
|
|
HandleScope scope(isolate);
|
|
std::pair<Handle<Object>*, int> handle_and_id(&key, 1234);
|
|
GlobalHandles::MakeWeak(key.location(),
|
|
reinterpret_cast<void*>(&handle_and_id),
|
|
&WeakPointerCallback);
|
|
}
|
|
CHECK(global_handles->IsWeak(key.location()));
|
|
|
|
// Force a full GC.
|
|
// Perform two consecutive GCs because the first one will only clear
|
|
// weak references whereas the second one will also clear weak sets.
|
|
heap->CollectAllGarbage(false);
|
|
CHECK_EQ(1, NumberOfWeakCalls);
|
|
CHECK_EQ(1, ObjectHashTable::cast(weakset->table())->NumberOfElements());
|
|
CHECK_EQ(
|
|
0, ObjectHashTable::cast(weakset->table())->NumberOfDeletedElements());
|
|
heap->CollectAllGarbage(false);
|
|
CHECK_EQ(1, NumberOfWeakCalls);
|
|
CHECK_EQ(0, ObjectHashTable::cast(weakset->table())->NumberOfElements());
|
|
CHECK_EQ(
|
|
1, ObjectHashTable::cast(weakset->table())->NumberOfDeletedElements());
|
|
}
|
|
|
|
|
|
TEST(WeakSet_Shrinking) {
|
|
LocalContext context;
|
|
Isolate* isolate = GetIsolateFrom(&context);
|
|
Factory* factory = isolate->factory();
|
|
Heap* heap = isolate->heap();
|
|
HandleScope scope(isolate);
|
|
Handle<JSWeakSet> weakset = AllocateJSWeakSet(isolate);
|
|
|
|
// Check initial capacity.
|
|
CHECK_EQ(32, ObjectHashTable::cast(weakset->table())->Capacity());
|
|
|
|
// Fill up weak set to trigger capacity change.
|
|
{
|
|
HandleScope scope(isolate);
|
|
Handle<Map> map = factory->NewMap(JS_OBJECT_TYPE, JSObject::kHeaderSize);
|
|
for (int i = 0; i < 32; i++) {
|
|
Handle<JSObject> object = factory->NewJSObjectFromMap(map);
|
|
PutIntoWeakSet(weakset, object, Handle<Smi>(Smi::FromInt(i), isolate));
|
|
}
|
|
}
|
|
|
|
// Check increased capacity.
|
|
CHECK_EQ(128, ObjectHashTable::cast(weakset->table())->Capacity());
|
|
|
|
// Force a full GC.
|
|
CHECK_EQ(32, ObjectHashTable::cast(weakset->table())->NumberOfElements());
|
|
CHECK_EQ(
|
|
0, ObjectHashTable::cast(weakset->table())->NumberOfDeletedElements());
|
|
heap->CollectAllGarbage(false);
|
|
CHECK_EQ(0, ObjectHashTable::cast(weakset->table())->NumberOfElements());
|
|
CHECK_EQ(
|
|
32, ObjectHashTable::cast(weakset->table())->NumberOfDeletedElements());
|
|
|
|
// Check shrunk capacity.
|
|
CHECK_EQ(32, ObjectHashTable::cast(weakset->table())->Capacity());
|
|
}
|
|
|
|
|
|
// Test that weak set values on an evacuation candidate which are not reachable
|
|
// by other paths are correctly recorded in the slots buffer.
|
|
TEST(WeakSet_Regress2060a) {
|
|
if (i::FLAG_never_compact) return;
|
|
FLAG_always_compact = true;
|
|
LocalContext context;
|
|
Isolate* isolate = GetIsolateFrom(&context);
|
|
Factory* factory = isolate->factory();
|
|
Heap* heap = isolate->heap();
|
|
HandleScope scope(isolate);
|
|
Handle<JSFunction> function =
|
|
factory->NewFunction(factory->function_string(), factory->null_value());
|
|
Handle<JSObject> key = factory->NewJSObject(function);
|
|
Handle<JSWeakSet> weakset = AllocateJSWeakSet(isolate);
|
|
|
|
// Start second old-space page so that values land on evacuation candidate.
|
|
Page* first_page = heap->old_pointer_space()->anchor()->next_page();
|
|
factory->NewFixedArray(900 * KB / kPointerSize, TENURED);
|
|
|
|
// Fill up weak set with values on an evacuation candidate.
|
|
{
|
|
HandleScope scope(isolate);
|
|
for (int i = 0; i < 32; i++) {
|
|
Handle<JSObject> object = factory->NewJSObject(function, TENURED);
|
|
CHECK(!heap->InNewSpace(object->address()));
|
|
CHECK(!first_page->Contains(object->address()));
|
|
PutIntoWeakSet(weakset, key, object);
|
|
}
|
|
}
|
|
|
|
// Force compacting garbage collection.
|
|
CHECK(FLAG_always_compact);
|
|
heap->CollectAllGarbage(Heap::kNoGCFlags);
|
|
}
|
|
|
|
|
|
// Test that weak set keys on an evacuation candidate which are reachable by
|
|
// other strong paths are correctly recorded in the slots buffer.
|
|
TEST(WeakSet_Regress2060b) {
|
|
if (i::FLAG_never_compact) return;
|
|
FLAG_always_compact = true;
|
|
#ifdef VERIFY_HEAP
|
|
FLAG_verify_heap = true;
|
|
#endif
|
|
|
|
LocalContext context;
|
|
Isolate* isolate = GetIsolateFrom(&context);
|
|
Factory* factory = isolate->factory();
|
|
Heap* heap = isolate->heap();
|
|
HandleScope scope(isolate);
|
|
Handle<JSFunction> function =
|
|
factory->NewFunction(factory->function_string(), factory->null_value());
|
|
|
|
// Start second old-space page so that keys land on evacuation candidate.
|
|
Page* first_page = heap->old_pointer_space()->anchor()->next_page();
|
|
factory->NewFixedArray(900 * KB / kPointerSize, TENURED);
|
|
|
|
// Fill up weak set with keys on an evacuation candidate.
|
|
Handle<JSObject> keys[32];
|
|
for (int i = 0; i < 32; i++) {
|
|
keys[i] = factory->NewJSObject(function, TENURED);
|
|
CHECK(!heap->InNewSpace(keys[i]->address()));
|
|
CHECK(!first_page->Contains(keys[i]->address()));
|
|
}
|
|
Handle<JSWeakSet> weakset = AllocateJSWeakSet(isolate);
|
|
for (int i = 0; i < 32; i++) {
|
|
PutIntoWeakSet(weakset,
|
|
keys[i],
|
|
Handle<Smi>(Smi::FromInt(i), isolate));
|
|
}
|
|
|
|
// Force compacting garbage collection. The subsequent collections are used
|
|
// to verify that key references were actually updated.
|
|
CHECK(FLAG_always_compact);
|
|
heap->CollectAllGarbage(Heap::kNoGCFlags);
|
|
heap->CollectAllGarbage(Heap::kNoGCFlags);
|
|
heap->CollectAllGarbage(Heap::kNoGCFlags);
|
|
}
|