f820041aba
This is a reland of 289b25765a
.
The fix for failures landed here:
https://chromium-review.googlesource.com/c/v8/v8/+/1599388
Original change's description:
> [Test] Update tests to work with lazy feedback allocation.
>
> This adds either %EnsureFeedbackVectorForFunction or
> %PrepareFunctionForOptimization to allocate feedback vectors when testing
> optimization, allocation sites, IC transitions etc.,
>
> Bug: v8:8394
> Change-Id: I6ad1b6d460e4abda693b326cddb87754e080a0a1
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1593303
> Commit-Queue: Mythri Alle <mythria@chromium.org>
> Auto-Submit: Mythri Alle <mythria@chromium.org>
> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#61212}
Bug: v8:8394
Change-Id: Idb5bba221d138e6fd73155f959b9e16fc948c709
TBR: rmcilroy@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599607
Reviewed-by: Mythri Alle <mythria@chromium.org>
Commit-Queue: Mythri Alle <mythria@chromium.org>
Auto-Submit: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#61332}
63 lines
1.6 KiB
JavaScript
63 lines
1.6 KiB
JavaScript
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --allow-natives-syntax
|
|
|
|
// This tests checks some possible wrong exception handling due to,
|
|
// for instance, the OSR loop peeling. If exception handlers are not updated
|
|
// correctly, when we run the second iteration of the outermost loop, which
|
|
// is the OSR optimised version, the try-catch will fail... which should not
|
|
// fail on a correct code.
|
|
|
|
function SingleLoop() {
|
|
for (var a = 0; a < 2; a++) {
|
|
try { throw 'The exception should have been caught.'; }
|
|
catch(e) {}
|
|
for (var b = 0; b < 1; b++) {
|
|
%OptimizeOsr();
|
|
}
|
|
}
|
|
}
|
|
%PrepareFunctionForOptimization(SingleLoop);
|
|
|
|
|
|
// These function could also fail if the exception handlers are not updated at
|
|
// the right time: a JSStackCheck gets created for the print, just after the
|
|
// bytecode for the while LoopHeader. If the OSR phase did not exit properly
|
|
// the exception before visiting the bytecode for the print, it will fail
|
|
// because some IfSuccess gets created for nothing (the IfException will
|
|
// become dead code and removed).
|
|
function EmptyBody() {
|
|
try {; } catch(e) {; }
|
|
var a = 0;
|
|
while (1) {
|
|
%OptimizeOsr();
|
|
print("foo");
|
|
|
|
if (a == 1) break;
|
|
a++;
|
|
}
|
|
}
|
|
%PrepareFunctionForOptimization(EmptyBody);
|
|
|
|
function NestedLoops() {
|
|
for (var a = 0; a < 2; a++) {
|
|
try {; } catch(e) {; }
|
|
%OptimizeOsr();
|
|
var b = 0;
|
|
while (1) {
|
|
print("bar");
|
|
|
|
if (b == 1) break;
|
|
b++;
|
|
}
|
|
}
|
|
}
|
|
%PrepareFunctionForOptimization(NestedLoops);
|
|
|
|
|
|
SingleLoop();
|
|
EmptyBody();
|
|
NestedLoops();
|