317fad950e
Extend the current OOB support for typed arrays to also handle the negative integer indices in the fast-path. This is safe because in ECMAScript we never look up integer indexed properties (including negative indices) on typed arrays in the prototype chain. This reduces the performance cliff shown in the benchmark on the relevant bug from console.timeEnd: Runtime deopt, 596.185000 console.timeEnd: Runtime deopt, 1444.289000 console.timeEnd: Runtime deopt, 1445.191000 console.timeEnd: Runtime deopt, 1443.008000 to console.timeEnd: Runtime deopt, 590.017000 console.timeEnd: Runtime deopt, 784.899000 console.timeEnd: Runtime deopt, 792.428000 console.timeEnd: Runtime deopt, 786.740000 which corresponds to a 2x improvement overall. It's not for free, especially not in this benchmark, but the cliff isn't as bad as it was previously. Bug: v8:7027 Change-Id: Icf8a7ee87bb7ebc54f82c1b9166fc5e78c12bc0e Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/911574 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#51222} |
||
---|---|---|
benchmarks | ||
build_overrides | ||
docs | ||
gni | ||
include | ||
infra | ||
samples | ||
src | ||
test | ||
testing | ||
third_party | ||
tools | ||
.clang-format | ||
.editorconfig | ||
.git-blame-ignore-revs | ||
.gitignore | ||
.gn | ||
.vpython | ||
.ycm_extra_conf.py | ||
AUTHORS | ||
BUILD.gn | ||
ChangeLog | ||
CODE_OF_CONDUCT.md | ||
codereview.settings | ||
DEPS | ||
LICENSE | ||
LICENSE.fdlibm | ||
LICENSE.strongtalk | ||
LICENSE.v8 | ||
LICENSE.valgrind | ||
OWNERS | ||
PRESUBMIT.py | ||
README.md | ||
snapshot_toolchain.gni | ||
WATCHLISTS |
V8 JavaScript Engine
V8 is Google's open source JavaScript engine.
V8 implements ECMAScript as specified in ECMA-262.
V8 is written in C++ and is used in Google Chrome, the open source browser from Google.
V8 can run standalone, or can be embedded into any C++ application.
V8 Project page: https://github.com/v8/v8/wiki
Getting the Code
Checkout depot tools, and run
fetch v8
This will checkout V8 into the directory v8
and fetch all of its dependencies.
To stay up to date, run
git pull origin
gclient sync
For fetching all branches, add the following into your remote
configuration in .git/config
:
fetch = +refs/branch-heads/*:refs/remotes/branch-heads/*
fetch = +refs/tags/*:refs/tags/*
Contributing
Please follow the instructions mentioned on the V8 wiki.