f6ce085a48
The fix is in 630b884f84 not f2223961. This reverts commit464ee4b7ad
. Reason for revert: roll to 67.1 after the landing of the fix Original change's description: > Revert "Roll ICU from 65.1 to 67.1 (f2223961) & correct tests" > > This reverts commite270b6d615
. > > Reason for revert: V8 DEPS roll stuck https://crbug.com/v8/10567#c1 > > Original change's description: > > Roll ICU from 65.1 to 67.1 (f2223961) & correct tests > > > > Rolling to chrome/src is in > > https://chromium-review.googlesource.com/c/chromium/src/+/2155530 > > > > Since auto rolling stop after 3/24/2020 and the rolling will cause > > change of test status, I get this cl ready (but not running trybot due > > to 1074260) and plan to hand roll after the submission of 2155530. > > > > Bug: chromium:1064326, v8:9515, v8:10379, v8:10380, v8:10437 > > Change-Id: I19554f68cfdc5b717dfc7fc4b1222e9dc25b8d69 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2158486 > > Auto-Submit: Frank Tang <ftang@chromium.org> > > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#67493} > > TBR=jkummerow@chromium.org,machenbach@chromium.org,jshin@chromium.org,ftang@chromium.org,syg@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: chromium:1064326, v8:9515, v8:10379, v8:10380, v8:10437 > Change-Id: I3f4233815ed7414f2cde3d4d996696575b5f6e3a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2219334 > Reviewed-by: Zhi An Ng <zhin@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68051} TBR=jkummerow@chromium.org,machenbach@chromium.org,jshin@chromium.org,zhin@chromium.org,ftang@chromium.org,syg@chromium.org # Not skipping CQ checks because this is a reland. Bug: chromium:1064326, v8:9515, v8:10379, v8:10380, v8:10437 Change-Id: I1de5eb36eff420482a12205682b153a2493d5249 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2220781 Reviewed-by: Frank Tang <ftang@chromium.org> Reviewed-by: Zhi An Ng <zhin@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#68160}
27 lines
921 B
JavaScript
27 lines
921 B
JavaScript
// Copyright 2019 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Test default.
|
|
let nf = new Intl.NumberFormat();
|
|
assertEquals("auto", nf.resolvedOptions().signDisplay);
|
|
|
|
nf = new Intl.NumberFormat("en");
|
|
assertEquals("auto", nf.resolvedOptions().signDisplay);
|
|
|
|
const testData = [
|
|
["auto", "-123", "-0", "0", "123"],
|
|
["always", "-123", "-0", "+0", "+123"],
|
|
["never", "123", "0", "0", "123"],
|
|
["exceptZero", "-123", "0", "0", "+123"],
|
|
];
|
|
|
|
for (const [signDisplay, neg, negZero, zero, pos] of testData) {
|
|
nf = new Intl.NumberFormat("en", {signDisplay});
|
|
assertEquals(signDisplay, nf.resolvedOptions().signDisplay);
|
|
assertEquals(neg, nf.format(-123));
|
|
assertEquals(negZero, nf.format(-0));
|
|
assertEquals(zero, nf.format(0));
|
|
assertEquals(pos, nf.format(123));
|
|
}
|