fa1a339777
AsyncGenerators, when resumed with a "return" completion, Await the sent value to provide consistency with syntactic return statements. This moves the await to during AsyncGeneratorResumeNext, shrinking the number of bytecodes. There's a minor change to BytecodeGenerator which removes a %_GeneratorClose() call, since it's inserted implicitly by the parser. BUG=v8:5855 TBR=neis@chromium.org Change-Id: I2965c610e5985ac24c713b481e62f6b97f96a3d8 Reviewed-on: https://chromium-review.googlesource.com/582218 Commit-Queue: Caitlin Potter <caitp@igalia.com> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#47253}
67 lines
2.8 KiB
C++
67 lines
2.8 KiB
C++
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef V8_BUILTINS_BUILTINS_ASYNC_H_
|
|
#define V8_BUILTINS_BUILTINS_ASYNC_H_
|
|
|
|
#include "src/builtins/builtins-promise-gen.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
|
|
class AsyncBuiltinsAssembler : public PromiseBuiltinsAssembler {
|
|
public:
|
|
explicit AsyncBuiltinsAssembler(compiler::CodeAssemblerState* state)
|
|
: PromiseBuiltinsAssembler(state) {}
|
|
|
|
protected:
|
|
typedef std::function<void(Node*)> ContextInitializer;
|
|
|
|
// Perform steps to resume generator after `value` is resolved.
|
|
// `on_reject_context_index` is an index into the Native Context, which should
|
|
// point to a SharedFunctioninfo instance used to create the closure. The
|
|
// value following the reject index should be a similar value for the resolve
|
|
// closure. Returns the Promise-wrapped `value`.
|
|
Node* Await(Node* context, Node* generator, Node* value, Node* outer_promise,
|
|
int context_length,
|
|
const ContextInitializer& init_closure_context,
|
|
Node* on_resolve_context_index, Node* on_reject_context_index,
|
|
Node* is_predicted_as_caught);
|
|
Node* Await(Node* context, Node* generator, Node* value, Node* outer_promise,
|
|
int context_length,
|
|
const ContextInitializer& init_closure_context,
|
|
int on_resolve_context_index, int on_reject_context_index,
|
|
Node* is_predicted_as_caught) {
|
|
return Await(context, generator, value, outer_promise, context_length,
|
|
init_closure_context, IntPtrConstant(on_resolve_context_index),
|
|
IntPtrConstant(on_reject_context_index),
|
|
is_predicted_as_caught);
|
|
}
|
|
Node* Await(Node* context, Node* generator, Node* value, Node* outer_promise,
|
|
int context_length,
|
|
const ContextInitializer& init_closure_context,
|
|
int on_resolve_context_index, int on_reject_context_index,
|
|
bool is_predicted_as_caught) {
|
|
return Await(context, generator, value, outer_promise, context_length,
|
|
init_closure_context, on_resolve_context_index,
|
|
on_reject_context_index,
|
|
BooleanConstant(is_predicted_as_caught));
|
|
}
|
|
|
|
// Return a new built-in function object as defined in
|
|
// Async Iterator Value Unwrap Functions
|
|
Node* CreateUnwrapClosure(Node* const native_context, Node* const done);
|
|
|
|
private:
|
|
void InitializeNativeClosure(Node* context, Node* native_context,
|
|
Node* function, Node* context_index);
|
|
Node* AllocateAsyncIteratorValueUnwrapContext(Node* native_context,
|
|
Node* done);
|
|
};
|
|
|
|
} // namespace internal
|
|
} // namespace v8
|
|
|
|
#endif // V8_BUILTINS_BUILTINS_ASYNC_H_
|