86a2720763
The typical use of assertThrowsEquals is to check that a specific object is thrown. However, assertEquals only does a proper equality check for primitive types, not for complex types. Using assertSame does a reference equality check on objects, which is more what you would expect from assertThrowsEquals. For exception kind testing, assertThrowsEquals actually did not work correctly, assertThrows is better for that case. R=clemensh@chromium.org, mythria@chromium.org Change-Id: I24fb22e75fa33ebe90eb4bae40825119a054bba5 Reviewed-on: https://chromium-review.googlesource.com/1087952 Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Mythri Alle <mythria@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#53556}
21 lines
481 B
JavaScript
21 lines
481 B
JavaScript
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --opt --allow-natives-syntax --no-always-opt
|
|
|
|
function f(b) {
|
|
if (b == 1) {
|
|
let a = a = 20;
|
|
}
|
|
}
|
|
|
|
f(0);
|
|
f(0);
|
|
%OptimizeFunctionOnNextCall(f);
|
|
f(0);
|
|
assertOptimized(f);
|
|
// Check that hole checks are handled correctly in optimized code.
|
|
assertThrows(() => {f(1)}, ReferenceError);
|
|
assertOptimized(f);
|