83a2f390f1
The fuzzer is expected to generate a lot of syntax and runtime errors,
and the respective messages just flood the fuzzer output. By always
putting a {TryCatch} scope around the execution, we prevent those
messages from being printed.
At the same time, inspector tests need to properly propagate uncaught
exceptions in the backend to the inspector, and fail on uncaught
exceptions in the frontend.
This CL allows for all these behaviours by extending the
{CatchExceptions} enum and the {TryCatch} logic in the task runner.
Drive-by: Use {base::OS::ExitProcess} instead of the explicit
{fflush} and {_exit}.
R=szuend@chromium.org
Bug: chromium:1142437
Change-Id: Ic2cb3b0de2399d25bd8c53090575308cb0e09ab0
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2529135
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#71152}
85 lines
2.4 KiB
C++
85 lines
2.4 KiB
C++
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef V8_TEST_INSPECTOR_PROTOCOL_TASK_RUNNER_H_
|
|
#define V8_TEST_INSPECTOR_PROTOCOL_TASK_RUNNER_H_
|
|
|
|
#include <map>
|
|
#include <memory>
|
|
|
|
#include "include/v8-inspector.h"
|
|
#include "include/v8-platform.h"
|
|
#include "include/v8.h"
|
|
#include "src/base/macros.h"
|
|
#include "src/base/platform/platform.h"
|
|
#include "src/utils/locked-queue-inl.h"
|
|
#include "src/utils/vector.h"
|
|
#include "test/inspector/isolate-data.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
|
|
enum CatchExceptions {
|
|
kFailOnUncaughtExceptions,
|
|
kStandardPropagateUncaughtExceptions,
|
|
kSuppressUncaughtExceptions
|
|
};
|
|
|
|
class TaskRunner : public v8::base::Thread {
|
|
public:
|
|
class Task {
|
|
public:
|
|
virtual ~Task() = default;
|
|
virtual bool is_priority_task() = 0;
|
|
virtual void Run(IsolateData* data) = 0;
|
|
};
|
|
|
|
TaskRunner(IsolateData::SetupGlobalTasks setup_global_tasks,
|
|
CatchExceptions catch_exceptions,
|
|
v8::base::Semaphore* ready_semaphore,
|
|
v8::StartupData* startup_data, WithInspector with_inspector);
|
|
~TaskRunner() override;
|
|
TaskRunner(const TaskRunner&) = delete;
|
|
TaskRunner& operator=(const TaskRunner&) = delete;
|
|
IsolateData* data() const { return data_.get(); }
|
|
|
|
// Thread implementation.
|
|
void Run() override;
|
|
|
|
// Should be called from the same thread and only from task.
|
|
void RunMessageLoop(bool only_protocol);
|
|
void QuitMessageLoop();
|
|
|
|
void Append(std::unique_ptr<Task>);
|
|
|
|
void Terminate();
|
|
|
|
private:
|
|
std::unique_ptr<Task> GetNext(bool only_protocol);
|
|
v8::Isolate* isolate() const { return data_->isolate(); }
|
|
|
|
IsolateData::SetupGlobalTasks setup_global_tasks_;
|
|
v8::StartupData* startup_data_;
|
|
WithInspector with_inspector_;
|
|
CatchExceptions catch_exceptions_;
|
|
v8::base::Semaphore* ready_semaphore_;
|
|
std::unique_ptr<IsolateData> data_;
|
|
|
|
// deferred_queue_ combined with queue_ (in this order) have all tasks in the
|
|
// correct order. Sometimes we skip non-protocol tasks by moving them from
|
|
// queue_ to deferred_queue_.
|
|
v8::internal::LockedQueue<std::unique_ptr<Task>> queue_;
|
|
v8::internal::LockedQueue<std::unique_ptr<Task>> deferred_queue_;
|
|
v8::base::Semaphore process_queue_semaphore_;
|
|
|
|
int nested_loop_count_;
|
|
|
|
std::atomic<int> is_terminated_;
|
|
};
|
|
|
|
} // namespace internal
|
|
} // namespace v8
|
|
|
|
#endif // V8_TEST_INSPECTOR_PROTOCOL_TASK_RUNNER_H_
|