07011cc4f0
This replaces Runtime_RunMicrotasks with Runtime_PerformMicrotaskCheckpoint.
RunMicrotasks forcibly runs Microtasks even when the microtasks are suppressed,
and may causes nested Microtasks in a problematic way. E.g. that confuses
v8::MicrotasksScope::IsRunningMicrotasks() and GetEnteredOrMicrotaskContext().
OTOH, PerformMicrotaskCheckpoint() doesn't run cause the failure as it
respects the microtask suppressions.
As all existing tests don't call RunMicrotasks() in the suppressed situation
(like Promise.resolve().then(()=>{%RunMicrotasks();})), this change should
not affect to these tests.
Change-Id: Ib043a0cc8e482e022d375084d65ea98a6f54ef3d
Reviewed-on: https://chromium-review.googlesource.com/c/1360095
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58068}
29 lines
577 B
JavaScript
29 lines
577 B
JavaScript
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --allow-natives-syntax
|
|
|
|
let log = [];
|
|
|
|
(async function() {
|
|
with ({get ['.promise']() { log.push('async') }}) {
|
|
return 10;
|
|
}
|
|
})();
|
|
%PerformMicrotaskCheckpoint();
|
|
|
|
(function() {
|
|
with ({get ['.new.target']() { log.push('new.target') }}) {
|
|
return new.target;
|
|
}
|
|
})();
|
|
|
|
(function() {
|
|
with ({get ['this']() { log.push('this') }}) {
|
|
return this;
|
|
}
|
|
})();
|
|
|
|
assertArrayEquals([], log);
|