a9846ad451
This code appears to have been wrong forever, as it only threw in strict mode (presumably predating ES2015 const). In order to get exactly the right behavior, special handling of sloppy named function expressions is required. Rather than polluting PropertyAttributes with another dummy value, this CL simply adds a bool output argument to Context::Lookup to indicate that case. Bug: v8:6677 Change-Id: I34daa5080d291808f10cbaefc91d716f0b22963b Reviewed-on: https://chromium-review.googlesource.com/602690 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#47207}
28 lines
848 B
JavaScript
28 lines
848 B
JavaScript
// Copyright 2017 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Assignment to const variable inside with-statement should fail.
|
|
const x = 0;
|
|
assertThrows(() => { with ({}) { x = 1; } }, TypeError);
|
|
assertEquals(0, x);
|
|
|
|
assertThrows(() => { with ({}) { eval("x = 1"); } }, TypeError);
|
|
assertEquals(0, x);
|
|
|
|
// Assignment to name of named function expression inside with-statement
|
|
// should not throw (but also not succeed).
|
|
assertEquals('function', function f() {
|
|
with ({}) { f = 1 }
|
|
return typeof f;
|
|
}());
|
|
|
|
// But we should throw an exception if the assignment is itself in strict
|
|
// code.
|
|
assertEquals('function', function f() {
|
|
with ({}) {
|
|
assertThrows(function() { "use strict"; f = 1 }, TypeError);
|
|
}
|
|
return typeof f;
|
|
}());
|