6dd3fbe40f
Some of the Array benchmarks were unintentionally spending a lot of time on Number-to-String conversions. This patch avoids that, by computing the dynamically-created strings only once. Bug: chromium:1240981 Change-Id: If10826813d555398b45c22c958dee27e17f35d3c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3106747 Reviewed-by: Michael Stanton <mvstanton@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#76387}
75 lines
1.9 KiB
JavaScript
75 lines
1.9 KiB
JavaScript
// Copyright 2018 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
(() => {
|
|
|
|
function Naive() {
|
|
let index = -1;
|
|
const length = array == null ? 0 : array.length;
|
|
|
|
for (let index = 0; index < length; index++) {
|
|
const value = array[index];
|
|
if (func(value, index, array)) {
|
|
result = value;
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
function NaiveSetup() {
|
|
// Prime Naive with polymorphic cases.
|
|
array = [1, 2, 3];
|
|
Naive();
|
|
Naive();
|
|
array = [3.4]; Naive();
|
|
array = new Array(10); array[0] = 'hello'; Naive();
|
|
SmiSetup();
|
|
delete array[1];
|
|
}
|
|
|
|
// Make sure we inline the callback, pick up all possible TurboFan
|
|
// optimizations.
|
|
function RunOptFast(value) {
|
|
// Use of variable {value} in the callback function forces
|
|
// context creation without escape analysis.
|
|
//
|
|
// Also, the arrow function requires inlining based on
|
|
// SharedFunctionInfo.
|
|
result = array.forEach((v, i, a) => v === value);
|
|
}
|
|
|
|
// Don't optimize because I want to optimize RunOptFast with a parameter
|
|
// to be used in the callback.
|
|
%NeverOptimizeFunction(OptFast);
|
|
function OptFast() { RunOptFast(max_index_value); }
|
|
|
|
function side_effect(a) { return a; }
|
|
%NeverOptimizeFunction(side_effect);
|
|
function OptUnreliable() {
|
|
result = array.forEach(func, side_effect(array));
|
|
}
|
|
|
|
DefineHigherOrderTests([
|
|
['NaiveForEachReplacement', Naive, NaiveSetup, v => v === max_index],
|
|
[
|
|
'DoubleForEach', newClosure('forEach'), DoubleSetup,
|
|
v => v === max_index + 0.5
|
|
],
|
|
['SmiForEach', newClosure('forEach'), SmiSetup, v => v === max_index],
|
|
[
|
|
'FastForEach', newClosure('forEach'), FastSetup,
|
|
v => v === max_index_value
|
|
],
|
|
[
|
|
'GenericForEach', newClosure('forEach', true), ObjectSetup,
|
|
v => v === max_index
|
|
],
|
|
['OptFastForEach', OptFast, FastSetup, undefined],
|
|
[
|
|
'OptUnreliableForEach', OptUnreliable, FastSetup,
|
|
v => v === max_index_value
|
|
]
|
|
]);
|
|
|
|
})();
|