338622d7ca
This is basically the minimum viable signal handler for Wasm bounds checks.
It includes the TLS check and the fine grained instructions checks. These
two checks provide most of the safety for the signal handler. Future CLs will
add code range and data range checks for more robustness.
The trap handling code and data structures are all in src/trap-handler, with
the code that actually runs in the signal handler confined to
src/trap-handler/signal-handler.cc.
This changes adds a new V8 API that the embedder should call from a signal
handler that will give V8 the chance to handle the fault first. For hosts that
do not want to implement their own signal handler, we include the option to
install a simple one. This simple handler is also used for the tests.
When a Wasm module is instantiated, information about each function is passed
to the trap handler, which is used to classify faults. These are removed during
the instance finalizer.
Several future enhancements are planned before turning this on by default.
Obviously, the additional checks will be added to MaybeHandleFault. We are
also planning to add a two-level CodeObjectData table that is grouped by
isolates to make cleanup easier and also reduce potential for contending on
a single data structure.
BUG= https://bugs.chromium.org/p/v8/issues/detail?id=5277
Review-Url: https://codereview.chromium.org/2371833007
Cr-Original-Commit-Position: refs/heads/master@{#43523}
Committed: a5af7fe9ee
Review-Url: https://codereview.chromium.org/2371833007
Cr-Commit-Position: refs/heads/master@{#43755}
38 lines
1.5 KiB
Python
38 lines
1.5 KiB
Python
# Copyright 2016 the V8 project authors. All rights reserved.
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
# found in the LICENSE file.
|
|
|
|
# Use this to run several variants of the tests.
|
|
ALL_VARIANT_FLAGS = {
|
|
"default": [[]],
|
|
"stress": [["--stress-opt", "--always-opt"]],
|
|
"turbofan": [["--turbo"]],
|
|
"turbofan_opt": [["--turbo", "--always-opt"]],
|
|
"noturbofan": [["--no-turbo"]],
|
|
"noturbofan_stress": [["--no-turbo", "--stress-opt", "--always-opt"]],
|
|
"nocrankshaft": [["--nocrankshaft"]],
|
|
"ignition": [["--ignition"]],
|
|
"ignition_turbofan": [["--ignition-staging", "--turbo"]],
|
|
"asm_wasm": [["--validate-asm"]],
|
|
"wasm_traps": [["--wasm_guard_pages", "--wasm_trap_handler", "--invoke-weak-callbacks"]],
|
|
}
|
|
|
|
# FAST_VARIANTS implies no --always-opt.
|
|
FAST_VARIANT_FLAGS = {
|
|
"default": [[]],
|
|
"stress": [["--stress-opt"]],
|
|
"turbofan": [["--turbo"]],
|
|
"noturbofan": [["--no-turbo"]],
|
|
"noturbofan_stress": [["--no-turbo", "--stress-opt"]],
|
|
"nocrankshaft": [["--nocrankshaft"]],
|
|
"ignition": [["--ignition"]],
|
|
"ignition_turbofan": [["--ignition-staging", "--turbo"]],
|
|
"asm_wasm": [["--validate-asm"]],
|
|
"wasm_traps": [["--wasm_guard_pages", "--wasm_trap_handler", "--invoke-weak-callbacks"]],
|
|
}
|
|
|
|
ALL_VARIANTS = set(["default", "stress", "turbofan", "turbofan_opt",
|
|
"noturbofan", "noturbofan_stress",
|
|
"nocrankshaft", "ignition",
|
|
"ignition_turbofan", "asm_wasm", "wasm_traps"])
|