4d07af1a34
Adds 2 counts to see how often this occurs on the web, both the throwing version (strict mode), and the no-op sloppy mode case, to help determine if the proposal at https://github.com/tc39/ecma262/pull/1307 is web compatible. This is the V8 side of required changes. The Chromium-side CL: https://crrev.com/c/1280618 BUG=v8:8175 R=littledan@chromium.org, cbruni@chromium.org, jkummerow@chromium.org, yangguo@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Id12336c2e566093bb554b6d4624c9301fbc4a0f7 Reviewed-on: https://chromium-review.googlesource.com/c/1255549 Commit-Queue: Caitlin Potter <caitp@igalia.com> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#56706}
170 lines
7.1 KiB
C++
170 lines
7.1 KiB
C++
// Copyright 2016 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "src/v8.h"
|
|
|
|
#include "test/cctest/cctest.h"
|
|
|
|
namespace v8 {
|
|
namespace internal {
|
|
namespace test_usecounters {
|
|
|
|
int* global_use_counts = nullptr;
|
|
|
|
void MockUseCounterCallback(v8::Isolate* isolate,
|
|
v8::Isolate::UseCounterFeature feature) {
|
|
++global_use_counts[feature];
|
|
}
|
|
|
|
TEST(AssigmentExpressionLHSIsCall) {
|
|
v8::Isolate* isolate = CcTest::isolate();
|
|
v8::HandleScope scope(isolate);
|
|
LocalContext env;
|
|
int use_counts[v8::Isolate::kUseCounterFeatureCount] = {};
|
|
global_use_counts = use_counts;
|
|
CcTest::isolate()->SetUseCounterCallback(MockUseCounterCallback);
|
|
|
|
// AssignmentExpressions whose LHS is not a call do not increment counters
|
|
CompileRun("function f(){ a = 0; a()[b] = 0; }");
|
|
CHECK_EQ(0, use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInSloppy]);
|
|
CHECK_EQ(0, use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInStrict]);
|
|
CompileRun("function f(){ ++a; ++a()[b]; }");
|
|
CHECK_EQ(0, use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInSloppy]);
|
|
CHECK_EQ(0, use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInStrict]);
|
|
CompileRun("function f(){ 'use strict'; a = 0; a()[b] = 0; }");
|
|
CHECK_EQ(0, use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInSloppy]);
|
|
CHECK_EQ(0, use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInStrict]);
|
|
CompileRun("function f(){ 'use strict'; ++a; ++a()[b]; }");
|
|
CHECK_EQ(0, use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInSloppy]);
|
|
CHECK_EQ(0, use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInStrict]);
|
|
|
|
// AssignmentExpressions whose LHS is a call increment appropriate counters
|
|
CompileRun("function f(){ a() = 0; }");
|
|
CHECK_NE(0, use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInSloppy]);
|
|
CHECK_EQ(0, use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInStrict]);
|
|
use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInSloppy] = 0;
|
|
CompileRun("function f(){ 'use strict'; a() = 0; }");
|
|
CHECK_EQ(0, use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInSloppy]);
|
|
CHECK_NE(0, use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInStrict]);
|
|
use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInStrict] = 0;
|
|
|
|
// UpdateExpressions whose LHS is a call increment appropriate counters
|
|
CompileRun("function f(){ ++a(); }");
|
|
CHECK_NE(0, use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInSloppy]);
|
|
CHECK_EQ(0, use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInStrict]);
|
|
use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInSloppy] = 0;
|
|
CompileRun("function f(){ 'use strict'; ++a(); }");
|
|
CHECK_EQ(0, use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInSloppy]);
|
|
CHECK_NE(0, use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInStrict]);
|
|
use_counts[v8::Isolate::kAssigmentExpressionLHSIsCallInStrict] = 0;
|
|
}
|
|
|
|
TEST(AtomicsWakeAndAtomicsNotify) {
|
|
v8::Isolate* isolate = CcTest::isolate();
|
|
v8::HandleScope scope(isolate);
|
|
LocalContext env;
|
|
int use_counts[v8::Isolate::kUseCounterFeatureCount] = {};
|
|
global_use_counts = use_counts;
|
|
i::FLAG_harmony_sharedarraybuffer = true;
|
|
CcTest::isolate()->SetUseCounterCallback(MockUseCounterCallback);
|
|
|
|
CompileRun("Atomics.wake(new Int32Array(new SharedArrayBuffer(16)), 0);");
|
|
CHECK_EQ(1, use_counts[v8::Isolate::kAtomicsWake]);
|
|
CHECK_EQ(0, use_counts[v8::Isolate::kAtomicsNotify]);
|
|
|
|
use_counts[v8::Isolate::kAtomicsWake] = 0;
|
|
use_counts[v8::Isolate::kAtomicsNotify] = 0;
|
|
|
|
CompileRun("Atomics.notify(new Int32Array(new SharedArrayBuffer(16)), 0);");
|
|
CHECK_EQ(0, use_counts[v8::Isolate::kAtomicsWake]);
|
|
CHECK_EQ(1, use_counts[v8::Isolate::kAtomicsNotify]);
|
|
}
|
|
|
|
TEST(OverrideReadOnlyPropertyOnPrototype) {
|
|
v8::Isolate* isolate = CcTest::isolate();
|
|
v8::HandleScope scope(isolate);
|
|
LocalContext env;
|
|
int use_counts[v8::Isolate::kUseCounterFeatureCount] = {};
|
|
global_use_counts = use_counts;
|
|
CcTest::isolate()->SetUseCounterCallback(MockUseCounterCallback);
|
|
using Isolate = v8::Isolate;
|
|
|
|
// Initial setup
|
|
CompileRun(
|
|
"Object.defineProperty(Object.prototype, 'readonly', "
|
|
"{ readonly: true, value: 'readonly', configurable: false });");
|
|
CHECK_EQ(0, use_counts[Isolate::kAttemptOverrideReadOnlyOnPrototypeSloppy]);
|
|
CHECK_EQ(0, use_counts[Isolate::kAttemptOverrideReadOnlyOnPrototypeStrict]);
|
|
|
|
// StoreIC Sloppy
|
|
CompileRun(
|
|
"function sloppy() { let sloppy = {}; sloppy.readonly = 'override'; }"
|
|
"sloppy();");
|
|
CHECK_EQ(1, use_counts[Isolate::kAttemptOverrideReadOnlyOnPrototypeSloppy]);
|
|
CHECK_EQ(0, use_counts[Isolate::kAttemptOverrideReadOnlyOnPrototypeStrict]);
|
|
use_counts[Isolate::kAttemptOverrideReadOnlyOnPrototypeSloppy] = 0;
|
|
use_counts[Isolate::kAttemptOverrideReadOnlyOnPrototypeStrict] = 0;
|
|
|
|
// StoreIC Sloppy (one-shot)
|
|
CompileRun("let sloppyob = {}; sloppyob.readonly = 'override';");
|
|
CHECK_EQ(1, use_counts[Isolate::kAttemptOverrideReadOnlyOnPrototypeSloppy]);
|
|
CHECK_EQ(0, use_counts[Isolate::kAttemptOverrideReadOnlyOnPrototypeStrict]);
|
|
use_counts[Isolate::kAttemptOverrideReadOnlyOnPrototypeSloppy] = 0;
|
|
use_counts[Isolate::kAttemptOverrideReadOnlyOnPrototypeStrict] = 0;
|
|
|
|
// StoreIC Strict
|
|
{
|
|
v8::TryCatch try_catch(isolate);
|
|
CompileRun(
|
|
"function strict() {"
|
|
" 'use strict'; let strict = {}; strict.readonly = 'override';"
|
|
"}"
|
|
"strict();");
|
|
CHECK_EQ(0, use_counts[Isolate::kAttemptOverrideReadOnlyOnPrototypeSloppy]);
|
|
CHECK_EQ(1, use_counts[Isolate::kAttemptOverrideReadOnlyOnPrototypeStrict]);
|
|
CHECK(try_catch.HasCaught());
|
|
}
|
|
use_counts[Isolate::kAttemptOverrideReadOnlyOnPrototypeSloppy] = 0;
|
|
use_counts[Isolate::kAttemptOverrideReadOnlyOnPrototypeStrict] = 0;
|
|
|
|
// StoreIC Strict (one-shot)
|
|
{
|
|
v8::TryCatch try_catch(isolate);
|
|
CompileRun(
|
|
"'use strict';"
|
|
"let strictob = {}; strictob.readonly = 'override';");
|
|
CHECK_EQ(0, use_counts[Isolate::kAttemptOverrideReadOnlyOnPrototypeSloppy]);
|
|
CHECK_EQ(1, use_counts[Isolate::kAttemptOverrideReadOnlyOnPrototypeStrict]);
|
|
CHECK(try_catch.HasCaught());
|
|
}
|
|
use_counts[Isolate::kAttemptOverrideReadOnlyOnPrototypeSloppy] = 0;
|
|
use_counts[Isolate::kAttemptOverrideReadOnlyOnPrototypeStrict] = 0;
|
|
|
|
// KeyedStoreIC Sloppy
|
|
CompileRun(
|
|
"function sloppy2() { let sloppy = {}; sloppy['readonly'] = 'override'; }"
|
|
"sloppy2();");
|
|
CHECK_EQ(1, use_counts[Isolate::kAttemptOverrideReadOnlyOnPrototypeSloppy]);
|
|
CHECK_EQ(0, use_counts[Isolate::kAttemptOverrideReadOnlyOnPrototypeStrict]);
|
|
use_counts[Isolate::kAttemptOverrideReadOnlyOnPrototypeSloppy] = 0;
|
|
use_counts[Isolate::kAttemptOverrideReadOnlyOnPrototypeStrict] = 0;
|
|
|
|
// KeyedStoreIC Strict
|
|
{
|
|
v8::TryCatch try_catch(isolate);
|
|
CompileRun(
|
|
"function strict2() {"
|
|
" 'use strict'; let strict = {}; strict['readonly'] = 'override';"
|
|
"}"
|
|
"strict2();");
|
|
CHECK_EQ(0, use_counts[Isolate::kAttemptOverrideReadOnlyOnPrototypeSloppy]);
|
|
CHECK_EQ(1, use_counts[Isolate::kAttemptOverrideReadOnlyOnPrototypeStrict]);
|
|
CHECK(try_catch.HasCaught());
|
|
}
|
|
}
|
|
|
|
} // namespace test_usecounters
|
|
} // namespace internal
|
|
} // namespace v8
|