v8/test/inspector/regress/regress-crbug-1352303-expected.txt
Simon Zünd 5d0b8b0ff1 [debugger] Throw exception if 'var x' fails in debug eval in module
This is an extension to the fix landed in https://crrev.com/c/3295348.

We should also throw the exception when we are paused in a module.
This is a constellation that can only happen with debug-evaluate as
'eval's in modules are always indirect, whereas debug-evaluate uses
direct, sloppy eval.

R=bmeurer@chromium.org, leszeks@chromium.org

Bug: chromium:1352303
Change-Id: I7373462dc6ae419e0a1a05a385ab81f204ff03ce
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3976510
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83917}
2022-10-26 05:39:32 +00:00

9 lines
415 B
Plaintext

Don't crash when creating a new var in a module via Debugger.evaluateOnCallFrame
{
className : EvalError
description : EvalError: Identifier 'test' cannot be declared with 'var' in current evaluation scope, consider trying 'let' instead at eval (eval at foo (module1:2:48), <anonymous>:1:1) at foo (module1:2:48) at module1:2:60
objectId : <objectId>
subtype : error
type : object
}