5d0b8b0ff1
This is an extension to the fix landed in https://crrev.com/c/3295348. We should also throw the exception when we are paused in a module. This is a constellation that can only happen with debug-evaluate as 'eval's in modules are always indirect, whereas debug-evaluate uses direct, sloppy eval. R=bmeurer@chromium.org, leszeks@chromium.org Bug: chromium:1352303 Change-Id: I7373462dc6ae419e0a1a05a385ab81f204ff03ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3976510 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#83917}
22 lines
771 B
JavaScript
22 lines
771 B
JavaScript
// Copyright 2022 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
const { Protocol, contextGroup } = InspectorTest.start('Don\'t crash when creating a new var in a module via Debugger.evaluateOnCallFrame');
|
|
|
|
(async () => {
|
|
await Protocol.Debugger.enable();
|
|
|
|
contextGroup.addModule(`
|
|
(function foo() { eval('var test2 = 42;'); debugger; })();
|
|
`, 'module1');
|
|
|
|
const { params: { callFrames: [{ callFrameId }] }} = await Protocol.Debugger.oncePaused();
|
|
const { result: { result }} = await Protocol.Debugger.evaluateOnCallFrame({
|
|
expression: 'var test = 1;',
|
|
callFrameId,
|
|
});
|
|
InspectorTest.logMessage(result);
|
|
InspectorTest.completeTest();
|
|
})();
|