v8/test/cctest/wasm/test-run-wasm-wrappers.cc
Igor Sheludko 4f4086dc34 [ext-code-space] Avoid Code <-> CodeT conversions in runtime, pt.4
This CL migrates the following objects' APIs to CodeT:
* WasmFunctionData,
* WasmInternalFunction.

Bug: v8:11880
Change-Id: Ib3f0eb41894cbd3c6b30430c4e5616eb45fbbaec
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3338701
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Dominik Inführ <dinfuehr@chromium.org>
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#78377}
2021-12-14 18:42:55 +00:00

360 lines
14 KiB
C++

// Copyright 2020 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "src/wasm/wasm-module-builder.h"
#include "src/wasm/wasm-objects-inl.h"
#include "test/cctest/cctest.h"
#include "test/common/wasm/flag-utils.h"
#include "test/common/wasm/test-signatures.h"
#include "test/common/wasm/wasm-macro-gen.h"
#include "test/common/wasm/wasm-module-runner.h"
namespace v8 {
namespace internal {
namespace wasm {
namespace test_run_wasm_wrappers {
using testing::CompileAndInstantiateForTesting;
#ifdef V8_TARGET_ARCH_X64
namespace {
Handle<WasmInstanceObject> CompileModule(Zone* zone, Isolate* isolate,
WasmModuleBuilder* builder) {
ZoneBuffer buffer(zone);
builder->WriteTo(&buffer);
testing::SetupIsolateForWasmModule(isolate);
ErrorThrower thrower(isolate, "CompileAndRunWasmModule");
MaybeHandle<WasmInstanceObject> maybe_instance =
CompileAndInstantiateForTesting(
isolate, &thrower, ModuleWireBytes(buffer.begin(), buffer.end()));
CHECK_WITH_MSG(!thrower.error(), thrower.error_msg());
return maybe_instance.ToHandleChecked();
}
bool IsGeneric(CodeT wrapper) {
return wrapper.is_builtin() &&
wrapper.builtin_id() == Builtin::kGenericJSToWasmWrapper;
}
bool IsSpecific(CodeT wrapper) {
return wrapper.kind() == CodeKind::JS_TO_WASM_FUNCTION;
}
Handle<Object> SmiHandle(Isolate* isolate, int value) {
return Handle<Object>(Smi::FromInt(value), isolate);
}
void SmiCall(Isolate* isolate, Handle<WasmExportedFunction> exported_function,
int argc, Handle<Object>* argv, int expected_result) {
Handle<Object> receiver = isolate->factory()->undefined_value();
Handle<Object> result =
Execution::Call(isolate, exported_function, receiver, argc, argv)
.ToHandleChecked();
CHECK(result->IsSmi() && Smi::ToInt(*result) == expected_result);
}
void Cleanup() {
// By sending a low memory notifications, we will try hard to collect all
// garbage and will therefore also invoke all weak callbacks of actually
// unreachable persistent handles.
Isolate* isolate = CcTest::InitIsolateOnce();
reinterpret_cast<v8::Isolate*>(isolate)->LowMemoryNotification();
}
} // namespace
TEST(WrapperBudget) {
{
// This test assumes use of the generic wrapper.
FlagScope<bool> use_wasm_generic_wrapper(&FLAG_wasm_generic_wrapper, true);
// Initialize the environment and create a module builder.
AccountingAllocator allocator;
Zone zone(&allocator, ZONE_NAME);
Isolate* isolate = CcTest::InitIsolateOnce();
HandleScope scope(isolate);
WasmModuleBuilder* builder = zone.New<WasmModuleBuilder>(&zone);
// Define the Wasm function.
TestSignatures sigs;
WasmFunctionBuilder* f = builder->AddFunction(sigs.i_ii());
f->builder()->AddExport(base::CStrVector("main"), f);
byte code[] = {WASM_I32_MUL(WASM_LOCAL_GET(0), WASM_LOCAL_GET(1)),
WASM_END};
f->EmitCode(code, sizeof(code));
// Compile the module.
Handle<WasmInstanceObject> instance =
CompileModule(&zone, isolate, builder);
// Get the exported function and the function data.
Handle<WasmExportedFunction> main_export =
testing::GetExportedFunction(isolate, instance, "main")
.ToHandleChecked();
Handle<WasmExportedFunctionData> main_function_data =
handle(main_export->shared().wasm_exported_function_data(), isolate);
// Check that the generic-wrapper budget has initially a value of
// kGenericWrapperBudget.
CHECK_EQ(main_function_data->wrapper_budget(), kGenericWrapperBudget);
CHECK_GT(kGenericWrapperBudget, 0);
// Call the exported Wasm function.
Handle<Object> params[2] = {SmiHandle(isolate, 6), SmiHandle(isolate, 7)};
SmiCall(isolate, main_export, 2, params, 42);
// Check that the budget has now a value of (kGenericWrapperBudget - 1).
CHECK_EQ(main_function_data->wrapper_budget(), kGenericWrapperBudget - 1);
}
Cleanup();
}
TEST(WrapperReplacement) {
{
// This test assumes use of the generic wrapper.
FlagScope<bool> use_wasm_generic_wrapper(&FLAG_wasm_generic_wrapper, true);
// Initialize the environment and create a module builder.
AccountingAllocator allocator;
Zone zone(&allocator, ZONE_NAME);
Isolate* isolate = CcTest::InitIsolateOnce();
HandleScope scope(isolate);
WasmModuleBuilder* builder = zone.New<WasmModuleBuilder>(&zone);
// Define the Wasm function.
TestSignatures sigs;
WasmFunctionBuilder* f = builder->AddFunction(sigs.i_i());
f->builder()->AddExport(base::CStrVector("main"), f);
byte code[] = {WASM_LOCAL_GET(0), WASM_END};
f->EmitCode(code, sizeof(code));
// Compile the module.
Handle<WasmInstanceObject> instance =
CompileModule(&zone, isolate, builder);
// Get the exported function and the function data.
Handle<WasmExportedFunction> main_export =
testing::GetExportedFunction(isolate, instance, "main")
.ToHandleChecked();
Handle<WasmExportedFunctionData> main_function_data =
handle(main_export->shared().wasm_exported_function_data(), isolate);
// Check that the generic-wrapper budget has initially a value of
// kGenericWrapperBudget.
CHECK_EQ(main_function_data->wrapper_budget(), kGenericWrapperBudget);
CHECK_GT(kGenericWrapperBudget, 0);
// Set the generic-wrapper budget to a value that allows for a few
// more calls through the generic wrapper.
const int remaining_budget =
std::min(static_cast<int>(kGenericWrapperBudget), 2);
main_function_data->set_wrapper_budget(remaining_budget);
// Call the exported Wasm function as many times as required to almost
// exhaust the remaining budget for using the generic wrapper.
Handle<CodeT> wrapper_before_call;
for (int i = remaining_budget; i > 0; --i) {
// Verify that the wrapper to be used is the generic one.
wrapper_before_call = handle(main_function_data->wrapper_code(), isolate);
CHECK(IsGeneric(*wrapper_before_call));
// Call the function.
Handle<Object> params[1] = {SmiHandle(isolate, i)};
SmiCall(isolate, main_export, 1, params, i);
// Verify that the budget has now a value of (i - 1).
CHECK_EQ(main_function_data->wrapper_budget(), i - 1);
}
// Get the wrapper-code object after the wrapper replacement.
CodeT wrapper_after_call = main_function_data->wrapper_code();
// Verify that the budget has been exhausted.
CHECK_EQ(main_function_data->wrapper_budget(), 0);
// Verify that the wrapper-code object has changed and the wrapper is now a
// specific one.
CHECK_NE(wrapper_after_call, *wrapper_before_call);
CHECK(IsSpecific(wrapper_after_call));
}
Cleanup();
}
TEST(EagerWrapperReplacement) {
{
// This test assumes use of the generic wrapper.
FlagScope<bool> use_wasm_generic_wrapper(&FLAG_wasm_generic_wrapper, true);
// Initialize the environment and create a module builder.
AccountingAllocator allocator;
Zone zone(&allocator, ZONE_NAME);
Isolate* isolate = CcTest::InitIsolateOnce();
HandleScope scope(isolate);
WasmModuleBuilder* builder = zone.New<WasmModuleBuilder>(&zone);
// Define three Wasm functions.
// Two of these functions (add and mult) will share the same signature,
// while the other one (id) won't.
TestSignatures sigs;
WasmFunctionBuilder* add = builder->AddFunction(sigs.i_ii());
add->builder()->AddExport(base::CStrVector("add"), add);
byte add_code[] = {WASM_I32_ADD(WASM_LOCAL_GET(0), WASM_LOCAL_GET(1)),
WASM_END};
add->EmitCode(add_code, sizeof(add_code));
WasmFunctionBuilder* mult = builder->AddFunction(sigs.i_ii());
mult->builder()->AddExport(base::CStrVector("mult"), mult);
byte mult_code[] = {WASM_I32_MUL(WASM_LOCAL_GET(0), WASM_LOCAL_GET(1)),
WASM_END};
mult->EmitCode(mult_code, sizeof(mult_code));
WasmFunctionBuilder* id = builder->AddFunction(sigs.i_i());
id->builder()->AddExport(base::CStrVector("id"), id);
byte id_code[] = {WASM_LOCAL_GET(0), WASM_END};
id->EmitCode(id_code, sizeof(id_code));
// Compile the module.
Handle<WasmInstanceObject> instance =
CompileModule(&zone, isolate, builder);
// Get the exported functions.
Handle<WasmExportedFunction> add_export =
testing::GetExportedFunction(isolate, instance, "add")
.ToHandleChecked();
Handle<WasmExportedFunction> mult_export =
testing::GetExportedFunction(isolate, instance, "mult")
.ToHandleChecked();
Handle<WasmExportedFunction> id_export =
testing::GetExportedFunction(isolate, instance, "id").ToHandleChecked();
// Get the function data for all exported functions.
Handle<WasmExportedFunctionData> add_function_data =
handle(add_export->shared().wasm_exported_function_data(), isolate);
Handle<WasmExportedFunctionData> mult_function_data =
handle(mult_export->shared().wasm_exported_function_data(), isolate);
Handle<WasmExportedFunctionData> id_function_data =
handle(id_export->shared().wasm_exported_function_data(), isolate);
// Set the remaining generic-wrapper budget for add to 1,
// so that the next call to it will cause the function to tier up.
add_function_data->set_wrapper_budget(1);
// Verify that the generic-wrapper budgets for all functions are correct.
CHECK_EQ(add_function_data->wrapper_budget(), 1);
CHECK_EQ(mult_function_data->wrapper_budget(), kGenericWrapperBudget);
CHECK_EQ(id_function_data->wrapper_budget(), kGenericWrapperBudget);
// Verify that all functions are set to use the generic wrapper.
CHECK(IsGeneric(add_function_data->wrapper_code()));
CHECK(IsGeneric(mult_function_data->wrapper_code()));
CHECK(IsGeneric(id_function_data->wrapper_code()));
// Call the add function to trigger the tier up.
{
Handle<Object> params[2] = {SmiHandle(isolate, 10),
SmiHandle(isolate, 11)};
SmiCall(isolate, add_export, 2, params, 21);
// Verify that the generic-wrapper budgets for all functions are correct.
CHECK_EQ(add_function_data->wrapper_budget(), 0);
CHECK_EQ(mult_function_data->wrapper_budget(), kGenericWrapperBudget);
CHECK_EQ(id_function_data->wrapper_budget(), kGenericWrapperBudget);
// Verify that the tier-up of the add function replaced the wrapper
// for both the add and the mult functions, but not the id function.
CHECK(IsSpecific(add_function_data->wrapper_code()));
CHECK(IsSpecific(mult_function_data->wrapper_code()));
CHECK(IsGeneric(id_function_data->wrapper_code()));
}
// Call the mult function to verify that the compiled wrapper is used.
{
Handle<Object> params[2] = {SmiHandle(isolate, 6), SmiHandle(isolate, 7)};
SmiCall(isolate, mult_export, 2, params, 42);
// Verify that mult's budget is still intact, which means that the call
// didn't go through the generic wrapper.
CHECK_EQ(mult_function_data->wrapper_budget(), kGenericWrapperBudget);
}
// Call the id function to verify that the generic wrapper is used.
{
Handle<Object> params[1] = {SmiHandle(isolate, 6)};
SmiCall(isolate, id_export, 1, params, 6);
// Verify that id's budget decreased by 1, which means that the call
// used the generic wrapper.
CHECK_EQ(id_function_data->wrapper_budget(), kGenericWrapperBudget - 1);
}
}
Cleanup();
}
TEST(WrapperReplacement_IndirectExport) {
{
// This test assumes use of the generic wrapper.
FlagScope<bool> use_wasm_generic_wrapper(&FLAG_wasm_generic_wrapper, true);
// Initialize the environment and create a module builder.
AccountingAllocator allocator;
Zone zone(&allocator, ZONE_NAME);
Isolate* isolate = CcTest::InitIsolateOnce();
HandleScope scope(isolate);
WasmModuleBuilder* builder = zone.New<WasmModuleBuilder>(&zone);
// Define a Wasm function, but do not add it to the exports.
TestSignatures sigs;
WasmFunctionBuilder* f = builder->AddFunction(sigs.i_i());
byte code[] = {WASM_LOCAL_GET(0), WASM_END};
f->EmitCode(code, sizeof(code));
uint32_t function_index = f->func_index();
// Export a table of indirect functions.
const uint32_t table_size = 2;
const uint32_t table_index =
builder->AddTable(kWasmFuncRef, table_size, table_size);
builder->AddExport(base::CStrVector("exported_table"), kExternalTable, 0);
// Point from the exported table to the Wasm function.
builder->SetIndirectFunction(
table_index, 0, function_index,
WasmModuleBuilder::WasmElemSegment::kRelativeToImports);
// Compile the module.
Handle<WasmInstanceObject> instance =
CompileModule(&zone, isolate, builder);
// Get the exported table.
Handle<WasmTableObject> table(
WasmTableObject::cast(instance->tables().get(table_index)), isolate);
// Get the Wasm function through the exported table.
Handle<Object> function =
WasmTableObject::Get(isolate, table, function_index);
Handle<WasmExportedFunction> indirect_function(
WasmExportedFunction::cast(
WasmInternalFunction::cast(*function).external()),
isolate);
// Get the function data.
Handle<WasmExportedFunctionData> indirect_function_data(
indirect_function->shared().wasm_exported_function_data(), isolate);
// Verify that the generic-wrapper budget has initially a value of
// kGenericWrapperBudget and the wrapper to be used for calls to the
// indirect function is the generic one.
CHECK(IsGeneric(indirect_function_data->wrapper_code()));
CHECK(indirect_function_data->wrapper_budget() == kGenericWrapperBudget);
// Set the remaining generic-wrapper budget for the indirect function to 1,
// so that the next call to it will cause the function to tier up.
indirect_function_data->set_wrapper_budget(1);
// Call the Wasm function.
Handle<Object> params[1] = {SmiHandle(isolate, 6)};
SmiCall(isolate, indirect_function, 1, params, 6);
// Verify that the budget is now exhausted and the generic wrapper has been
// replaced by a specific one.
CHECK_EQ(indirect_function_data->wrapper_budget(), 0);
CHECK(IsSpecific(indirect_function_data->wrapper_code()));
}
Cleanup();
}
#endif
} // namespace test_run_wasm_wrappers
} // namespace wasm
} // namespace internal
} // namespace v8