8f8d2fe4ca
This change fixes the implementation of the previously introduced API `Runtime.setMaxCallStackSizeToCapture` to work correctly and also apply (consistently) to stack traces captured by V8 when exceptions are thrown. It does so in a fully backwards compatible manner. This change thus makes the previous fix for catapult (which landed in http://crrev.com/c/3347789) effective, and therefore ensures that real world performance benchmarks aren't affected by the use of the `Runtime` domain in the catapult test framework. Note this is basically a reland of crrev.com/c/3361839, but without touching the stack traces for console messages (which led to the regressions in crbug/1283516, crbug/1283523, etc.). Fixed: chromium:1280831 Bug: chromium:1283162, chromium:1278650, chromium:1258599 Bug: chromium:1280803, chromium:1280832, chromium:1280818 Doc: https://bit.ly/v8-cheaper-inspector-stack-traces Change-Id: I3dcec7b75d76ca267fac8bd6fcb2cda60d5e60dd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3364086 Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/main@{#78479}
94 lines
1.9 KiB
Plaintext
94 lines
1.9 KiB
Plaintext
Checks that console messages before Runtime.enable include a single stack frame
|
|
|
|
Running test: testEnable
|
|
{
|
|
args : [
|
|
[0] : {
|
|
type : string
|
|
value : Error on toplevel
|
|
}
|
|
]
|
|
executionContextId : <executionContextId>
|
|
stackTrace : {
|
|
callFrames : [
|
|
[0] : {
|
|
columnNumber : 8
|
|
functionName :
|
|
lineNumber : 10
|
|
scriptId : <scriptId>
|
|
url : test.js
|
|
}
|
|
]
|
|
}
|
|
timestamp : <timestamp>
|
|
type : error
|
|
}
|
|
{
|
|
args : [
|
|
[0] : {
|
|
type : string
|
|
value : Hello from foo!
|
|
}
|
|
]
|
|
executionContextId : <executionContextId>
|
|
stackTrace : {
|
|
callFrames : [
|
|
[0] : {
|
|
columnNumber : 10
|
|
functionName : foo
|
|
lineNumber : 2
|
|
scriptId : <scriptId>
|
|
url : test.js
|
|
}
|
|
]
|
|
}
|
|
timestamp : <timestamp>
|
|
type : log
|
|
}
|
|
{
|
|
args : [
|
|
[0] : {
|
|
type : string
|
|
value : Hello from bar!
|
|
}
|
|
]
|
|
executionContextId : <executionContextId>
|
|
stackTrace : {
|
|
callFrames : [
|
|
[0] : {
|
|
columnNumber : 10
|
|
functionName : bar
|
|
lineNumber : 6
|
|
scriptId : <scriptId>
|
|
url : test.js
|
|
}
|
|
]
|
|
}
|
|
timestamp : <timestamp>
|
|
type : trace
|
|
}
|
|
{
|
|
args : [
|
|
[0] : {
|
|
type : string
|
|
value : Hello from foo!
|
|
}
|
|
]
|
|
executionContextId : <executionContextId>
|
|
stackTrace : {
|
|
callFrames : [
|
|
[0] : {
|
|
columnNumber : 10
|
|
functionName : foo
|
|
lineNumber : 2
|
|
scriptId : <scriptId>
|
|
url : test.js
|
|
}
|
|
]
|
|
}
|
|
timestamp : <timestamp>
|
|
type : log
|
|
}
|
|
|
|
Running test: testEnableAfterDiscard
|