5dd39b1de1
Allow Wasm to generate calls directly to Fast API C functions. Also fixes a problem when calling a Fast Api C function with no FastApiCallbackOptions from JS. This is a rebase of https://chromium-review.googlesource.com/c/v8/v8/+/3364356, which was a rebase of the work originally done by devsnek in: https://chromium-review.googlesource.com/c/v8/v8/+/2718666. Bug: chromium:1052746, chromium:1292333 Change-Id: Ic56268e7723f80f7ea9e6799e777786d3a50222f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3440694 Reviewed-by: Maya Lekova <mslekova@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Paolo Severini <paolosev@microsoft.com> Cr-Commit-Position: refs/heads/main@{#79125}
142 lines
4.4 KiB
JavaScript
142 lines
4.4 KiB
JavaScript
// Copyright 2022 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --turbo-fast-api-calls --expose-fast-api
|
|
|
|
load('test/mjsunit/wasm/wasm-module-builder.js');
|
|
|
|
assertThrows(() => d8.test.FastCAPI());
|
|
const fast_c_api = new d8.test.FastCAPI();
|
|
|
|
function buildWasm(name, sig, body) {
|
|
const builder = new WasmModuleBuilder();
|
|
const add_all_no_options = builder.addImport(
|
|
'fast_c_api',
|
|
'add_all_no_options',
|
|
makeSig(
|
|
[kWasmI32, kWasmI32, kWasmI32, kWasmI64, kWasmI64, kWasmF32, kWasmF64],
|
|
[kWasmF64],
|
|
),
|
|
);
|
|
const add_all_no_options_mismatch = builder.addImport(
|
|
'fast_c_api',
|
|
'add_all_no_options',
|
|
makeSig(
|
|
[kWasmI32, kWasmI32, kWasmI32, kWasmI64, kWasmF32, kWasmI64, kWasmF64],
|
|
[kWasmF64],
|
|
),
|
|
);
|
|
const add_all_nested_bound = builder.addImport(
|
|
'fast_c_api',
|
|
'add_all_nested_bound',
|
|
makeSig(
|
|
[kWasmI32, kWasmI32, kWasmI32, kWasmI64, kWasmI64, kWasmF32, kWasmF64],
|
|
[kWasmF64],
|
|
),
|
|
);
|
|
builder
|
|
.addFunction(name, sig)
|
|
.addBody(body({
|
|
add_all_no_options,
|
|
add_all_no_options_mismatch,
|
|
add_all_nested_bound,
|
|
}))
|
|
.exportFunc();
|
|
const x = {};
|
|
const module = builder.instantiate({
|
|
fast_c_api: {
|
|
add_all_no_options: fast_c_api.add_all_no_options.bind(fast_c_api),
|
|
add_all_no_options_mismatch: fast_c_api.add_all_no_options.bind(fast_c_api),
|
|
add_all_nested_bound: fast_c_api.add_all_no_options
|
|
.bind(fast_c_api)
|
|
.bind(x),
|
|
},
|
|
});
|
|
return module.exports[name];
|
|
}
|
|
|
|
// ----------- add_all -----------
|
|
// `add_all` has the following signature:
|
|
// double add_all(bool /*should_fallback*/, int32_t, uint32_t,
|
|
// int64_t, uint64_t, float, double)
|
|
|
|
const max_safe_float = 2**24 - 1;
|
|
const add_all_result = -42 + 45 + Number.MIN_SAFE_INTEGER + Number.MAX_SAFE_INTEGER +
|
|
max_safe_float * 0.5 + Math.PI;
|
|
|
|
const add_all_wasm = buildWasm(
|
|
'add_all_wasm', makeSig([], [kWasmF64]),
|
|
({ add_all_no_options }) => [
|
|
...wasmI32Const(0),
|
|
...wasmI32Const(-42),
|
|
...wasmI32Const(45),
|
|
kExprI64Const, 0x81, 0x80, 0x80, 0x80, 0x80, 0x80, 0x80, 0x70, // Number.MIN_SAFE_INTEGER
|
|
kExprI64Const, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0x0F, // Number.MAX_SAFE_INTEGER
|
|
...wasmF32Const(max_safe_float * 0.5),
|
|
...wasmF64Const(Math.PI),
|
|
kExprCallFunction, add_all_no_options,
|
|
kExprReturn,
|
|
],
|
|
);
|
|
|
|
if (fast_c_api.supports_fp_params) {
|
|
// Test wasm hits fast path.
|
|
fast_c_api.reset_counts();
|
|
assertEquals(add_all_result, add_all_wasm());
|
|
assertEquals(1, fast_c_api.fast_call_count());
|
|
assertEquals(0, fast_c_api.slow_call_count());
|
|
} else {
|
|
// Test wasm hits slow path.
|
|
fast_c_api.reset_counts();
|
|
assertEquals(add_all_result, add_all_wasm());
|
|
assertEquals(0, fast_c_api.fast_call_count());
|
|
assertEquals(1, fast_c_api.slow_call_count());
|
|
}
|
|
|
|
// ----------- Test add_all signature mismatch -----------
|
|
|
|
const add_all_mismatch_wasm = buildWasm(
|
|
'add_all_mismatch_wasm', makeSig([], [kWasmF64]),
|
|
({ add_all_no_options_mismatch }) => [
|
|
...wasmI32Const(0),
|
|
...wasmI32Const(45),
|
|
...wasmI32Const(-42),
|
|
kExprI64Const, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0x0F, // Number.MAX_SAFE_INTEGER
|
|
...wasmF32Const(max_safe_float * 0.5),
|
|
kExprI64Const, 0x81, 0x80, 0x80, 0x80, 0x80, 0x80, 0x80, 0x70, // Number.MIN_SAFE_INTEGER
|
|
...wasmF64Const(Math.PI),
|
|
kExprCallFunction, add_all_no_options_mismatch,
|
|
kExprReturn,
|
|
],
|
|
);
|
|
|
|
// Test that wasm takes slow path.
|
|
fast_c_api.reset_counts();
|
|
add_all_mismatch_wasm();
|
|
assertEquals(0, fast_c_api.fast_call_count());
|
|
assertEquals(1, fast_c_api.slow_call_count());
|
|
|
|
// ----------- Test add_all nested bound function -----------
|
|
|
|
const add_all_nested_bound_wasm = buildWasm(
|
|
'add_all_nested_bound_wasm', makeSig([], [kWasmF64]),
|
|
({ add_all_nested_bound }) => [
|
|
...wasmI32Const(0),
|
|
...wasmI32Const(-42),
|
|
...wasmI32Const(45),
|
|
kExprI64Const, 0x81, 0x80, 0x80, 0x80, 0x80, 0x80, 0x80, 0x70, // Number.MIN_SAFE_INTEGER
|
|
kExprI64Const, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0x0F, // Number.MAX_SAFE_INTEGER
|
|
...wasmF32Const(max_safe_float * 0.5),
|
|
...wasmF64Const(Math.PI),
|
|
kExprCallFunction, add_all_nested_bound,
|
|
kExprReturn,
|
|
],
|
|
);
|
|
|
|
// Test wasm hits slow path.
|
|
fast_c_api.reset_counts();
|
|
assertEquals(add_all_result, add_all_nested_bound_wasm());
|
|
assertEquals(0, fast_c_api.fast_call_count());
|
|
assertEquals(1, fast_c_api.slow_call_count());
|