760c56bddf
Indisputable profit: - correct break location in next task (see tests), - stepOver with async await never lands in random code (see related test and issue), - inspector doesn't store current stepping state in debugger agent and completely trust V8 - step to new inspector-V8 design (I will finish design doc soon). - willExecuteScript and didExecuteScript instrumentation could be removed from code base - reduce probability of future errors. - finally - less code, - stepping implementation in V8 makes another step to follow our stepping strategy (stepOut should do stepInto and break when exit current frame) (another one one page design doc based on @aandrey comment is coming), - knowledge about existing of context groups is still inspector-only. Disputable part is related to super rare scenario when in single isolate we have more then one context group id with enabled debugger agent: - if one agent request break in own context (stepping, pause, e.t.c.) then we ignore all breaks in another agent. From one hand it looks like good: user clicks stepInto and they don't expect that execution could be paused by another instance of DevTools in unobservable from current DevTools way (second DevTools will get paused notification and run nested message loop). From another hand we shouldn't ignore breakpoints or debugger statement never. In general, I think that proposed behavior is rathe feature then issue. - and disadvantage, on attempt to break in non-target context group id we just call StepOut until reach target context group id, step out call could deoptimize code in non related to current debugger agent context. But break could happens only in case of debugger stmt or breakpoint - sound like minor issue. Ignoring break on exception sounds like real issue but by module of rareness of this case I think we can ignore this. Implementation details: - when debugger agent request break for any reason it passes target context group id to V8Debugger - last agent requesting break is preferred. - when V8Debugger gets BreakProgramRequested notification from V8, it checks current context group id against target context group id, if they match then just process break as usual otherwise makes StepOut action, - debug.cc at the end of microtask if last_scheduled_action is StepOut, schedules StepIn and will break on first instruction in next task. BUG=chromium:654022 R=dgozman@chromium.org,yangguo@chromium.org Review-Url: https://codereview.chromium.org/2748503002 Cr-Commit-Position: refs/heads/master@{#44034}
72 lines
987 B
Plaintext
72 lines
987 B
Plaintext
Debugger breaks in next script after stepOut from previous one.
|
|
|
|
Running test: testStepOut
|
|
test (foo.js:12:2)
|
|
(anonymous) (:0:0)
|
|
|
|
(anonymous) (:0:5)
|
|
|
|
(anonymous) (timeout1.js:0:8)
|
|
|
|
foo (timeout2.js:2:2)
|
|
|
|
(anonymous) (timeout3.js:0:8)
|
|
|
|
|
|
Running test: testStepOver
|
|
(anonymous) (:0:0)
|
|
|
|
test (foo.js:12:2)
|
|
(anonymous) (:0:0)
|
|
|
|
test (foo.js:13:0)
|
|
(anonymous) (:0:0)
|
|
|
|
(anonymous) (:0:5)
|
|
|
|
(anonymous) (timeout1.js:0:8)
|
|
|
|
(anonymous) (timeout1.js:0:34)
|
|
|
|
foo (timeout2.js:2:2)
|
|
|
|
foo (timeout2.js:3:0)
|
|
|
|
(anonymous) (timeout3.js:0:8)
|
|
|
|
(anonymous) (timeout3.js:0:34)
|
|
|
|
|
|
Running test: testStepInto
|
|
(anonymous) (:0:0)
|
|
|
|
test (foo.js:9:2)
|
|
(anonymous) (:0:0)
|
|
|
|
test (foo.js:10:2)
|
|
(anonymous) (:0:0)
|
|
|
|
test (foo.js:11:2)
|
|
(anonymous) (:0:0)
|
|
|
|
test (foo.js:12:2)
|
|
(anonymous) (:0:0)
|
|
|
|
test (foo.js:13:0)
|
|
(anonymous) (:0:0)
|
|
|
|
(anonymous) (:0:5)
|
|
|
|
(anonymous) (timeout1.js:0:8)
|
|
|
|
(anonymous) (timeout1.js:0:34)
|
|
|
|
foo (timeout2.js:2:2)
|
|
|
|
foo (timeout2.js:3:0)
|
|
|
|
(anonymous) (timeout3.js:0:8)
|
|
|
|
(anonymous) (timeout3.js:0:34)
|
|
|