38301e7bb9
This reverts commitc7c47c68f2. Reason for revert: breaks TSAN https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN/28738 Original change's description: > Reland "[runtime] Move Context::native_context to the map" > > This is a reland off05bae1e0d> > Previously I presumed that the context read from a frame in the profiler was > a valid context. Turns out that on non-intel we're not guaranteed that the > frame is properly set up. In the case we looked at, the profiler took a > sample right before writing the frame marker indicating a builtin frame, > causing the "context" pointer from that frame to be a bytecode array. Since > we'll read random garbage on the stack as a possible context pointer, I made > the code reading the native context from it a little more defensive. > > Bug: v8:9860 > > Original change's description: > > [runtime] Move Context::native_context to the map > > > > Remove the native context slot from contexts by making context maps > > native-context-specific. Now we require 2 loads to go from a context to the > > native context, but we have 1 field fewer to store when creating contexts. > > > > Change-Id: I3c0d7c50c94060c4129db684f46a567de6f30e8d > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1859629 > > Commit-Queue: Toon Verwaest <verwaest@chromium.org> > > Reviewed-by: Igor Sheludko <ishell@chromium.org> > > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > > Reviewed-by: Maya Lekova <mslekova@chromium.org> > > Reviewed-by: Georg Neis <neis@chromium.org> > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#64296} > > Change-Id: If9461e9b21d35a260d71c79d7f95e518cc429e09 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864930 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Toon Verwaest <verwaest@chromium.org> > Auto-Submit: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64314} TBR=ulan@chromium.org,neis@chromium.org,petermarshall@chromium.org,ishell@chromium.org,verwaest@chromium.org,mslekova@chromium.org,victorgomes@google.com Change-Id: I4f9edc62ea6f9f5857619ff0ad1a63cab4b33cc3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9860 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864937 Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#64316}
58 lines
1.7 KiB
Plaintext
58 lines
1.7 KiB
Plaintext
#
|
|
# Autogenerated by generate-bytecode-expectations.
|
|
#
|
|
|
|
---
|
|
wrap: yes
|
|
|
|
---
|
|
snippet: "
|
|
g = function(){}; eval(''); return g();
|
|
"
|
|
frame size: 10
|
|
parameter count: 1
|
|
bytecode array length: 75
|
|
bytecodes: [
|
|
B(CreateFunctionContext), U8(0), U8(3),
|
|
B(PushContext), R(1),
|
|
B(Ldar), R(this),
|
|
B(StaCurrentContextSlot), U8(4),
|
|
B(CreateMappedArguments),
|
|
B(StaCurrentContextSlot), U8(6),
|
|
B(Ldar), R(0),
|
|
B(StaCurrentContextSlot), U8(5),
|
|
/* 30 E> */ B(StackCheck),
|
|
/* 34 S> */ B(CreateClosure), U8(1), U8(0), U8(2),
|
|
/* 36 E> */ B(StaLookupSlot), U8(2), U8(0),
|
|
/* 52 S> */ B(LdaLookupGlobalSlot), U8(3), U8(0), U8(1),
|
|
B(Star), R(2),
|
|
B(LdaConstant), U8(4),
|
|
B(Star), R(3),
|
|
B(LdaZero),
|
|
B(Star), R(7),
|
|
B(LdaSmi), I8(30),
|
|
B(Star), R(8),
|
|
B(LdaSmi), I8(52),
|
|
B(Star), R(9),
|
|
B(Mov), R(2), R(4),
|
|
B(Mov), R(3), R(5),
|
|
B(Mov), R(closure), R(6),
|
|
B(CallRuntime), U16(Runtime::kResolvePossiblyDirectEval), R(4), U8(6),
|
|
B(Star), R(2),
|
|
/* 52 E> */ B(CallUndefinedReceiver1), R(2), R(3), U8(2),
|
|
/* 62 S> */ B(LdaLookupGlobalSlot), U8(2), U8(4), U8(1),
|
|
B(Star), R(2),
|
|
/* 69 E> */ B(CallUndefinedReceiver0), R(2), U8(6),
|
|
/* 73 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
SCOPE_INFO_TYPE,
|
|
SHARED_FUNCTION_INFO_TYPE,
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["g"],
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["eval"],
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE [""],
|
|
]
|
|
handlers: [
|
|
]
|
|
|