ffee558e14
With this CL, {CreateDefaultPlatform} returns a unique_ptr to indicate
that the caller owns the returned memory. We had several memory leaks
where the memory of the DefaultPlatform did not get deallocated.
In addition, the {TracingController} of the {DefaultPlatform} also gets
received as a unique_ptr. Thereby we document that the {DefaultPlatform}
takes ownership of the {TracingController}. Note that the memory of the
{TracingController} was already owned by the {DefaultPlatform}, but it
was not documented in the interface, and it was used incorrectly in
tests.
This CL fixes the asan issues in
https://chromium-review.googlesource.com/c/v8/v8/+/753583
([platform] Implement TaskRunners in the DefaultPlatform)
R=rmcilroy@chromium.org
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: I0d1a6d3b22bb8289dc050b1977e4f58381cec675
Reviewed-on: https://chromium-review.googlesource.com/755033
Reviewed-by: Adam Klein <adamk@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49349}
95 lines
3.6 KiB
C++
95 lines
3.6 KiB
C++
// Copyright 2014 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef V8_LIBPLATFORM_LIBPLATFORM_H_
|
|
#define V8_LIBPLATFORM_LIBPLATFORM_H_
|
|
|
|
#include "libplatform/libplatform-export.h"
|
|
#include "libplatform/v8-tracing.h"
|
|
#include "v8-platform.h" // NOLINT(build/include)
|
|
#include "v8config.h" // NOLINT(build/include)
|
|
|
|
namespace v8 {
|
|
namespace platform {
|
|
|
|
enum class IdleTaskSupport { kDisabled, kEnabled };
|
|
enum class InProcessStackDumping { kDisabled, kEnabled };
|
|
|
|
enum class MessageLoopBehavior : bool {
|
|
kDoNotWait = false,
|
|
kWaitForWork = true
|
|
};
|
|
|
|
/**
|
|
* Returns a new instance of the default v8::Platform implementation.
|
|
*
|
|
* The caller will take ownership of the returned pointer. |thread_pool_size|
|
|
* is the number of worker threads to allocate for background jobs. If a value
|
|
* of zero is passed, a suitable default based on the current number of
|
|
* processors online will be chosen.
|
|
* If |idle_task_support| is enabled then the platform will accept idle
|
|
* tasks (IdleTasksEnabled will return true) and will rely on the embedder
|
|
* calling v8::platform::RunIdleTasks to process the idle tasks.
|
|
* If |tracing_controller| is nullptr, the default platform will create a
|
|
* v8::platform::TracingController instance and use it.
|
|
*/
|
|
V8_PLATFORM_EXPORT std::unique_ptr<v8::Platform> NewDefaultPlatform(
|
|
int thread_pool_size = 0,
|
|
IdleTaskSupport idle_task_support = IdleTaskSupport::kDisabled,
|
|
InProcessStackDumping in_process_stack_dumping =
|
|
InProcessStackDumping::kEnabled,
|
|
std::unique_ptr<v8::TracingController> tracing_controller = {});
|
|
|
|
V8_PLATFORM_EXPORT V8_DEPRECATE_SOON(
|
|
"Use NewDefaultPlatform instead",
|
|
v8::Platform* CreateDefaultPlatform(
|
|
int thread_pool_size = 0,
|
|
IdleTaskSupport idle_task_support = IdleTaskSupport::kDisabled,
|
|
InProcessStackDumping in_process_stack_dumping =
|
|
InProcessStackDumping::kEnabled,
|
|
v8::TracingController* tracing_controller = nullptr));
|
|
|
|
/**
|
|
* Pumps the message loop for the given isolate.
|
|
*
|
|
* The caller has to make sure that this is called from the right thread.
|
|
* Returns true if a task was executed, and false otherwise. Unless requested
|
|
* through the |behavior| parameter, this call does not block if no task is
|
|
* pending. The |platform| has to be created using |NewDefaultPlatform|.
|
|
*/
|
|
V8_PLATFORM_EXPORT bool PumpMessageLoop(
|
|
v8::Platform* platform, v8::Isolate* isolate,
|
|
MessageLoopBehavior behavior = MessageLoopBehavior::kDoNotWait);
|
|
|
|
V8_PLATFORM_EXPORT void EnsureEventLoopInitialized(v8::Platform* platform,
|
|
v8::Isolate* isolate);
|
|
|
|
/**
|
|
* Runs pending idle tasks for at most |idle_time_in_seconds| seconds.
|
|
*
|
|
* The caller has to make sure that this is called from the right thread.
|
|
* This call does not block if no task is pending. The |platform| has to be
|
|
* created using |NewDefaultPlatform|.
|
|
*/
|
|
V8_PLATFORM_EXPORT void RunIdleTasks(v8::Platform* platform,
|
|
v8::Isolate* isolate,
|
|
double idle_time_in_seconds);
|
|
|
|
/**
|
|
* Attempts to set the tracing controller for the given platform.
|
|
*
|
|
* The |platform| has to be created using |NewDefaultPlatform|.
|
|
*
|
|
*/
|
|
V8_PLATFORM_EXPORT V8_DEPRECATE_SOON(
|
|
"Access the DefaultPlatform directly",
|
|
void SetTracingController(
|
|
v8::Platform* platform,
|
|
v8::platform::tracing::TracingController* tracing_controller));
|
|
|
|
} // namespace platform
|
|
} // namespace v8
|
|
|
|
#endif // V8_LIBPLATFORM_LIBPLATFORM_H_
|