f3568ca400
test262 "negative" test expectations list which exception is thrown. The ES2017 draft specification is very specific about which exception class is thrown from which path, and V8 works hard to be correct with respect to that spec. Previously, the test262 test runner would accept any nonzero status code, such as from a crash, or a FAIL printed out, for a negative test. This patch makes negative tests check for the right answer using a quick-and-dirty parsing of the exception printing from d8 to find the exception class. It invokes d8 in a way to get a status code of 0 from thrown exceptions so that 'negative' tests aren't actually implemented by negating the output. Amazingly, this didn't catch any test262 failures, but I verified the extra checking interactively by changing a negative test to expect a different type and saw it fail. BUG=v8:4803 R=machenbach LOG=Y Review URL: https://codereview.chromium.org/1766503002 Cr-Commit-Position: refs/heads/master@{#34763}
74 lines
2.2 KiB
Python
74 lines
2.2 KiB
Python
# Copyright 2014 the V8 project authors. All rights reserved.
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
# found in the LICENSE file.
|
|
|
|
|
|
import os
|
|
import shutil
|
|
import sys
|
|
|
|
from testrunner.local import testsuite
|
|
from testrunner.objects import testcase
|
|
|
|
SIMDJS_SUITE_PATH = ["data", "src"]
|
|
|
|
|
|
class SimdJsTestSuite(testsuite.TestSuite):
|
|
|
|
def __init__(self, name, root):
|
|
super(SimdJsTestSuite, self).__init__(name, root)
|
|
self.testroot = os.path.join(self.root, *SIMDJS_SUITE_PATH)
|
|
self.ParseTestRecord = None
|
|
|
|
def ListTests(self, context):
|
|
tests = [
|
|
testcase.TestCase(self, 'shell_test_runner'),
|
|
]
|
|
for filename in os.listdir(os.path.join(self.testroot, 'benchmarks')):
|
|
if (not filename.endswith('.js') or
|
|
filename in ['run.js', 'run_browser.js', 'base.js']):
|
|
continue
|
|
name = filename.rsplit('.')[0]
|
|
tests.append(
|
|
testcase.TestCase(self, 'benchmarks/' + name))
|
|
return tests
|
|
|
|
def GetFlagsForTestCase(self, testcase, context):
|
|
return (testcase.flags + context.mode_flags +
|
|
[os.path.join(self.root, "harness-adapt.js"),
|
|
"--harmony", "--harmony-simd",
|
|
os.path.join(self.testroot, testcase.path + ".js"),
|
|
os.path.join(self.root, "harness-finish.js")])
|
|
|
|
def GetSourceForTest(self, testcase):
|
|
filename = os.path.join(self.testroot, testcase.path + ".js")
|
|
with open(filename) as f:
|
|
return f.read()
|
|
|
|
def IsNegativeTest(self, testcase):
|
|
return False
|
|
|
|
def IsFailureOutput(self, testcase):
|
|
if testcase.output.exit_code != 0:
|
|
return True
|
|
return "FAILED!" in testcase.output.stdout
|
|
|
|
def DownloadData(self):
|
|
print "SimdJs download is deprecated. It's part of DEPS."
|
|
|
|
# Clean up old directories and archive files.
|
|
directory_old_name = os.path.join(self.root, "data.old")
|
|
if os.path.exists(directory_old_name):
|
|
shutil.rmtree(directory_old_name)
|
|
|
|
archive_files = [f for f in os.listdir(self.root)
|
|
if f.startswith("ecmascript_simd-")]
|
|
if len(archive_files) > 0:
|
|
print "Clobber outdated test archives ..."
|
|
for f in archive_files:
|
|
os.remove(os.path.join(self.root, f))
|
|
|
|
|
|
def GetSuite(name, root):
|
|
return SimdJsTestSuite(name, root)
|