3cad6bf5d7
This is a reland of c7c47c68f2.
This makes TSAN happy in addition to:
Previously I presumed that the context read from a frame in the profiler was
a valid context. Turns out that on non-intel we're not guaranteed that the
frame is properly set up. In the case we looked at, the profiler took a
sample right before writing the frame marker indicating a builtin frame,
causing the "context" pointer from that frame to be a bytecode array. Since
we'll read random garbage on the stack as a possible context pointer, I made
the code reading the native context from it a little more defensive.
Bug: v8:9860
Tbr: ulan@chromium.org, neis@chromium.org, ishell@chromium.org
Original change's description:
> [runtime] Move Context::native_context to the map
>
> Remove the native context slot from contexts by making context maps
> native-context-specific. Now we require 2 loads to go from a context to the
> native context, but we have 1 field fewer to store when creating contexts.
>
> Change-Id: I3c0d7c50c94060c4129db684f46a567de6f30e8d
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1859629
> Commit-Queue: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Igor Sheludko <ishell@chromium.org>
> Reviewed-by: Peter Marshall <petermarshall@chromium.org>
> Reviewed-by: Maya Lekova <mslekova@chromium.org>
> Reviewed-by: Georg Neis <neis@chromium.org>
> Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#64296}
Change-Id: I4d0ab4cbbb23a9ae616407f17ef8f35a0b68ddb4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864654
Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Georg Neis <neis@chromium.org>
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64360}
291 lines
6.9 KiB
Plaintext
291 lines
6.9 KiB
Plaintext
#
|
|
# Autogenerated by generate-bytecode-expectations.
|
|
#
|
|
|
|
---
|
|
wrap: no
|
|
test function name: test
|
|
private methods: yes
|
|
|
|
---
|
|
snippet: "
|
|
class A {
|
|
static #a() { return 1; }
|
|
static test() { return this.#a(); }
|
|
}
|
|
|
|
var test = A.test;
|
|
test();
|
|
"
|
|
frame size: 4
|
|
parameter count: 1
|
|
bytecode array length: 36
|
|
bytecodes: [
|
|
/* 51 E> */ B(StackCheck),
|
|
/* 56 S> */ B(LdaCurrentContextSlot), U8(4),
|
|
B(TestReferenceEqual), R(this),
|
|
B(Mov), R(this), R(1),
|
|
B(JumpIfTrue), U8(18),
|
|
B(Wide), B(LdaSmi), I16(260),
|
|
B(Star), R(2),
|
|
B(LdaConstant), U8(0),
|
|
B(Star), R(3),
|
|
B(CallRuntime), U16(Runtime::kNewTypeError), R(2), U8(2),
|
|
B(Throw),
|
|
B(LdaCurrentContextSlot), U8(3),
|
|
B(Star), R(0),
|
|
/* 70 E> */ B(CallAnyReceiver), R(0), R(1), U8(1), U8(0),
|
|
/* 73 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["#a"],
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
class B {
|
|
static #b() { return 1; }
|
|
static test() { this.#b = 1; }
|
|
}
|
|
|
|
var test = B.test;
|
|
test();
|
|
"
|
|
frame size: 2
|
|
parameter count: 1
|
|
bytecode array length: 17
|
|
bytecodes: [
|
|
/* 51 E> */ B(StackCheck),
|
|
/* 56 S> */ B(Wide), B(LdaSmi), I16(262),
|
|
B(Star), R(0),
|
|
B(LdaConstant), U8(0),
|
|
B(Star), R(1),
|
|
/* 64 E> */ B(CallRuntime), U16(Runtime::kNewTypeError), R(0), U8(2),
|
|
B(Throw),
|
|
]
|
|
constant pool: [
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["#b"],
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
class C {
|
|
static #c() { return 1; }
|
|
static test() { this.#c++; }
|
|
}
|
|
|
|
var test = C.test;
|
|
test();
|
|
"
|
|
frame size: 2
|
|
parameter count: 1
|
|
bytecode array length: 17
|
|
bytecodes: [
|
|
/* 51 E> */ B(StackCheck),
|
|
/* 56 S> */ B(Wide), B(LdaSmi), I16(262),
|
|
B(Star), R(0),
|
|
B(LdaConstant), U8(0),
|
|
B(Star), R(1),
|
|
B(CallRuntime), U16(Runtime::kNewTypeError), R(0), U8(2),
|
|
B(Throw),
|
|
]
|
|
constant pool: [
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["#c"],
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
class D {
|
|
static get #d() { return 1; }
|
|
static set #d(val) { }
|
|
|
|
static test() {
|
|
this.#d++;
|
|
this.#d = 1;
|
|
return this.#d;
|
|
}
|
|
}
|
|
|
|
var test = D.test;
|
|
test();
|
|
"
|
|
frame size: 5
|
|
parameter count: 1
|
|
bytecode array length: 143
|
|
bytecodes: [
|
|
/* 81 E> */ B(StackCheck),
|
|
/* 90 S> */ B(LdaCurrentContextSlot), U8(3),
|
|
B(Star), R(1),
|
|
B(LdaCurrentContextSlot), U8(4),
|
|
/* 94 E> */ B(TestReferenceEqual), R(this),
|
|
B(Mov), R(this), R(0),
|
|
B(JumpIfTrue), U8(18),
|
|
B(Wide), B(LdaSmi), I16(260),
|
|
B(Star), R(2),
|
|
B(LdaConstant), U8(0),
|
|
B(Star), R(3),
|
|
B(CallRuntime), U16(Runtime::kNewTypeError), R(2), U8(2),
|
|
B(Throw),
|
|
B(CallRuntime), U16(Runtime::kLoadPrivateGetter), R(1), U8(1),
|
|
B(Star), R(2),
|
|
B(CallProperty0), R(2), R(0), U8(0),
|
|
B(Inc), U8(2),
|
|
B(Star), R(2),
|
|
/* 97 E> */ B(CallRuntime), U16(Runtime::kLoadPrivateSetter), R(1), U8(1),
|
|
B(Star), R(3),
|
|
B(CallProperty1), R(3), R(0), R(2), U8(3),
|
|
/* 105 S> */ B(LdaSmi), I8(1),
|
|
B(Star), R(0),
|
|
B(LdaCurrentContextSlot), U8(3),
|
|
B(Star), R(2),
|
|
B(LdaCurrentContextSlot), U8(4),
|
|
/* 109 E> */ B(TestReferenceEqual), R(this),
|
|
B(Mov), R(this), R(1),
|
|
B(JumpIfTrue), U8(18),
|
|
B(Wide), B(LdaSmi), I16(261),
|
|
B(Star), R(3),
|
|
B(LdaConstant), U8(0),
|
|
B(Star), R(4),
|
|
B(CallRuntime), U16(Runtime::kNewTypeError), R(3), U8(2),
|
|
B(Throw),
|
|
B(CallRuntime), U16(Runtime::kLoadPrivateSetter), R(2), U8(1),
|
|
B(Star), R(3),
|
|
B(CallProperty1), R(3), R(1), R(0), U8(5),
|
|
/* 122 S> */ B(LdaCurrentContextSlot), U8(3),
|
|
B(Star), R(1),
|
|
B(LdaCurrentContextSlot), U8(4),
|
|
/* 133 E> */ B(TestReferenceEqual), R(this),
|
|
B(Mov), R(this), R(0),
|
|
B(JumpIfTrue), U8(18),
|
|
B(Wide), B(LdaSmi), I16(260),
|
|
B(Star), R(2),
|
|
B(LdaConstant), U8(0),
|
|
B(Star), R(3),
|
|
B(CallRuntime), U16(Runtime::kNewTypeError), R(2), U8(2),
|
|
B(Throw),
|
|
B(CallRuntime), U16(Runtime::kLoadPrivateGetter), R(1), U8(1),
|
|
B(Star), R(2),
|
|
B(CallProperty0), R(2), R(0), U8(7),
|
|
/* 137 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["#d"],
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
class E {
|
|
static get #e() { return 1; }
|
|
static test() { this.#e++; }
|
|
}
|
|
var test = E.test;
|
|
test();
|
|
"
|
|
frame size: 2
|
|
parameter count: 1
|
|
bytecode array length: 17
|
|
bytecodes: [
|
|
/* 55 E> */ B(StackCheck),
|
|
/* 60 S> */ B(Wide), B(LdaSmi), I16(264),
|
|
B(Star), R(0),
|
|
B(LdaConstant), U8(0),
|
|
B(Star), R(1),
|
|
B(CallRuntime), U16(Runtime::kNewTypeError), R(0), U8(2),
|
|
B(Throw),
|
|
]
|
|
constant pool: [
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["#e"],
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
class F {
|
|
static set #f(val) { }
|
|
static test() { this.#f++; }
|
|
}
|
|
var test = F.test;
|
|
test();
|
|
"
|
|
frame size: 2
|
|
parameter count: 1
|
|
bytecode array length: 17
|
|
bytecodes: [
|
|
/* 48 E> */ B(StackCheck),
|
|
/* 53 S> */ B(Wide), B(LdaSmi), I16(263),
|
|
B(Star), R(0),
|
|
B(LdaConstant), U8(0),
|
|
B(Star), R(1),
|
|
B(CallRuntime), U16(Runtime::kNewTypeError), R(0), U8(2),
|
|
B(Throw),
|
|
]
|
|
constant pool: [
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["#f"],
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
class G {
|
|
static get #d() { return 1; }
|
|
static test() { this.#d = 1; }
|
|
}
|
|
var test = G.test;
|
|
test();
|
|
"
|
|
frame size: 2
|
|
parameter count: 1
|
|
bytecode array length: 17
|
|
bytecodes: [
|
|
/* 55 E> */ B(StackCheck),
|
|
/* 60 S> */ B(Wide), B(LdaSmi), I16(264),
|
|
B(Star), R(0),
|
|
B(LdaConstant), U8(0),
|
|
B(Star), R(1),
|
|
/* 68 E> */ B(CallRuntime), U16(Runtime::kNewTypeError), R(0), U8(2),
|
|
B(Throw),
|
|
]
|
|
constant pool: [
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["#d"],
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
class H {
|
|
set #h(val) { }
|
|
static test() { this.#h; }
|
|
}
|
|
var test = H.test;
|
|
test();
|
|
"
|
|
frame size: 3
|
|
parameter count: 1
|
|
bytecode array length: 17
|
|
bytecodes: [
|
|
/* 41 E> */ B(StackCheck),
|
|
/* 46 S> */ B(Wide), B(LdaSmi), I16(263),
|
|
B(Star), R(1),
|
|
B(LdaConstant), U8(0),
|
|
B(Star), R(2),
|
|
B(CallRuntime), U16(Runtime::kNewTypeError), R(1), U8(2),
|
|
B(Throw),
|
|
]
|
|
constant pool: [
|
|
ONE_BYTE_INTERNALIZED_STRING_TYPE ["#h"],
|
|
]
|
|
handlers: [
|
|
]
|
|
|