99b5f699ab
- Removes JS implementation and InnerArrayFind/InnerArrayFindIndex - Adds TFJ, with TFS for slow continuation path Some quick benchmarks show ~2x improvement for unoptimized code and up to 16% improvement against optimized code (diminishes with larger arrays as iterating dominates). https://github.com/peterwmwong/v8-perf/blob/master/array-find-findIndex/README.md Bug: chromium:791045, v8:1956, v8:5049, v8:7165 Change-Id: Ie16252ed495bbd91fe548b16d5ef6764de791a50 Reviewed-on: https://chromium-review.googlesource.com/804704 Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#49851}
351 lines
9.0 KiB
JavaScript
351 lines
9.0 KiB
JavaScript
// Copyright 2013 the V8 project authors. All rights reserved.
|
|
// Redistribution and use in source and binary forms, with or without
|
|
// modification, are permitted provided that the following conditions are
|
|
// met:
|
|
//
|
|
// * Redistributions of source code must retain the above copyright
|
|
// notice, this list of conditions and the following disclaimer.
|
|
// * Redistributions in binary form must reproduce the above
|
|
// copyright notice, this list of conditions and the following
|
|
// disclaimer in the documentation and/or other materials provided
|
|
// with the distribution.
|
|
// * Neither the name of Google Inc. nor the names of its
|
|
// contributors may be used to endorse or promote products derived
|
|
// from this software without specific prior written permission.
|
|
//
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
assertEquals(1, Array.prototype.find.length);
|
|
|
|
var a = [21, 22, 23, 24];
|
|
assertEquals(undefined, a.find(function() { return false; }));
|
|
assertEquals(21, a.find(function() { return true; }));
|
|
assertEquals(undefined, a.find(function(val) { return 121 === val; }));
|
|
assertEquals(24, a.find(function(val) { return 24 === val; }));
|
|
assertEquals(23, a.find(function(val) { return 23 === val; }), null);
|
|
assertEquals(22, a.find(function(val) { return 22 === val; }), undefined);
|
|
|
|
|
|
//
|
|
// Test predicate is not called when array is empty
|
|
//
|
|
(function() {
|
|
var a = [];
|
|
var l = -1;
|
|
var o = -1;
|
|
var v = -1;
|
|
var k = -1;
|
|
|
|
a.find(function(val, key, obj) {
|
|
o = obj;
|
|
l = obj.length;
|
|
v = val;
|
|
k = key;
|
|
|
|
return false;
|
|
});
|
|
|
|
assertEquals(-1, l);
|
|
assertEquals(-1, o);
|
|
assertEquals(-1, v);
|
|
assertEquals(-1, k);
|
|
})();
|
|
|
|
|
|
//
|
|
// Test predicate is called with correct argumetns
|
|
//
|
|
(function() {
|
|
var a = ["b"];
|
|
var l = -1;
|
|
var o = -1;
|
|
var v = -1;
|
|
var k = -1;
|
|
|
|
var found = a.find(function(val, key, obj) {
|
|
o = obj;
|
|
l = obj.length;
|
|
v = val;
|
|
k = key;
|
|
|
|
return false;
|
|
});
|
|
|
|
assertArrayEquals(a, o);
|
|
assertEquals(a.length, l);
|
|
assertEquals("b", v);
|
|
assertEquals(0, k);
|
|
assertEquals(undefined, found);
|
|
})();
|
|
|
|
|
|
//
|
|
// Test predicate is called array.length times
|
|
//
|
|
(function() {
|
|
var a = [1, 2, 3, 4, 5];
|
|
var l = 0;
|
|
var found = a.find(function() {
|
|
l++;
|
|
return false;
|
|
});
|
|
|
|
assertEquals(a.length, l);
|
|
assertEquals(undefined, found);
|
|
})();
|
|
|
|
|
|
//
|
|
// Test Array.prototype.find works with String
|
|
//
|
|
(function() {
|
|
var a = "abcd";
|
|
var l = -1;
|
|
var o = -1;
|
|
var v = -1;
|
|
var k = -1;
|
|
var found = Array.prototype.find.call(a, function(val, key, obj) {
|
|
o = obj.toString();
|
|
l = obj.length;
|
|
v = val;
|
|
k = key;
|
|
|
|
return false;
|
|
});
|
|
|
|
assertEquals(a, o);
|
|
assertEquals(a.length, l);
|
|
assertEquals("d", v);
|
|
assertEquals(3, k);
|
|
assertEquals(undefined, found);
|
|
|
|
found = Array.prototype.find.apply(a, [function(val, key, obj) {
|
|
o = obj.toString();
|
|
l = obj.length;
|
|
v = val;
|
|
k = key;
|
|
|
|
return true;
|
|
}]);
|
|
|
|
assertEquals(a, o);
|
|
assertEquals(a.length, l);
|
|
assertEquals("a", v);
|
|
assertEquals(0, k);
|
|
assertEquals("a", found);
|
|
})();
|
|
|
|
|
|
//
|
|
// Test Array.prototype.find works with exotic object
|
|
//
|
|
(function() {
|
|
var l = -1;
|
|
var o = -1;
|
|
var v = -1;
|
|
var k = -1;
|
|
var a = {
|
|
prop1: "val1",
|
|
prop2: "val2",
|
|
isValid: function() {
|
|
return this.prop1 === "val1" && this.prop2 === "val2";
|
|
}
|
|
};
|
|
|
|
Array.prototype.push.apply(a, [30, 31, 32]);
|
|
var found = Array.prototype.find.call(a, function(val, key, obj) {
|
|
o = obj;
|
|
l = obj.length;
|
|
v = val;
|
|
k = key;
|
|
|
|
return !obj.isValid();
|
|
});
|
|
|
|
assertArrayEquals(a, o);
|
|
assertEquals(3, l);
|
|
assertEquals(32, v);
|
|
assertEquals(2, k);
|
|
assertEquals(undefined, found);
|
|
})();
|
|
|
|
|
|
//
|
|
// Test array modifications
|
|
//
|
|
(function() {
|
|
var a = [1, 2, 3];
|
|
var found = a.find(function(val) { a.push(val); return false; });
|
|
assertArrayEquals([1, 2, 3, 1, 2, 3], a);
|
|
assertEquals(6, a.length);
|
|
assertEquals(undefined, found);
|
|
|
|
a = [1, 2, 3];
|
|
found = a.find(function(val, key) { a[key] = ++val; return false; });
|
|
assertArrayEquals([2, 3, 4], a);
|
|
assertEquals(3, a.length);
|
|
assertEquals(undefined, found);
|
|
})();
|
|
|
|
|
|
//
|
|
// Test predicate is called for holes
|
|
//
|
|
(function() {
|
|
var a = new Array(30);
|
|
a[11] = 21;
|
|
a[7] = 10;
|
|
a[29] = 31;
|
|
|
|
var count = 0;
|
|
a.find(function() { count++; return false; });
|
|
assertEquals(30, count);
|
|
})();
|
|
|
|
|
|
(function() {
|
|
var a = [0, 1, , 3];
|
|
var count = 0;
|
|
var found = a.find(function(val) { return val === undefined; });
|
|
assertEquals(undefined, found);
|
|
})();
|
|
|
|
|
|
(function() {
|
|
var a = [0, 1, , 3];
|
|
a.__proto__ = {
|
|
__proto__: Array.prototype,
|
|
2: 42,
|
|
};
|
|
var count = 0;
|
|
var found = a.find(function(val) { return val === 42; });
|
|
assertEquals(42, found);
|
|
})();
|
|
|
|
|
|
//
|
|
// Test predicate is called for missing properties
|
|
//
|
|
(function() {
|
|
const obj = {
|
|
"0": 0,
|
|
"2": 2,
|
|
length: 3
|
|
};
|
|
const received = [];
|
|
const predicate = (v) => { received.push(v); return false; };
|
|
const found = Array.prototype.find.call(obj, predicate);
|
|
assertEquals(undefined, found);
|
|
assertArrayEquals([0, undefined, 2], received);
|
|
})();
|
|
|
|
|
|
//
|
|
// Test predicate modifying array prototype
|
|
//
|
|
(function() {
|
|
const a = [0, , 2];
|
|
const received = [];
|
|
const predicate = (v) => {
|
|
a.__proto__ = null;
|
|
received.push(v);
|
|
return false;
|
|
};
|
|
const found = Array.prototype.find.call(a, predicate);
|
|
assertEquals(undefined, found);
|
|
assertArrayEquals([0, undefined, 2], received);
|
|
})();
|
|
|
|
|
|
//
|
|
// Test thisArg
|
|
//
|
|
(function() {
|
|
// Test String as a thisArg
|
|
var found = [1, 2, 3].find(function(val, key) {
|
|
return this.charAt(Number(key)) === String(val);
|
|
}, "321");
|
|
assertEquals(2, found);
|
|
|
|
// Test object as a thisArg
|
|
var thisArg = {
|
|
elementAt: function(key) {
|
|
return this[key];
|
|
}
|
|
};
|
|
Array.prototype.push.apply(thisArg, ["c", "b", "a"]);
|
|
|
|
found = ["a", "b", "c"].find(function(val, key) {
|
|
return this.elementAt(key) === val;
|
|
}, thisArg);
|
|
assertEquals("b", found);
|
|
|
|
// Create a new object in each function call when receiver is a
|
|
// primitive value. See ECMA-262, Annex C.
|
|
a = [];
|
|
[1, 2].find(function() { a.push(this) }, "");
|
|
assertTrue(a[0] !== a[1]);
|
|
|
|
// Do not create a new object otherwise.
|
|
a = [];
|
|
[1, 2].find(function() { a.push(this) }, {});
|
|
assertEquals(a[0], a[1]);
|
|
|
|
// In strict mode primitive values should not be coerced to an object.
|
|
a = [];
|
|
[1, 2].find(function() { 'use strict'; a.push(this); }, "");
|
|
assertEquals("", a[0]);
|
|
assertEquals(a[0], a[1]);
|
|
|
|
})();
|
|
|
|
// Test exceptions
|
|
assertThrows('Array.prototype.find.call(null, function() { })',
|
|
TypeError);
|
|
assertThrows('Array.prototype.find.call(undefined, function() { })',
|
|
TypeError);
|
|
assertThrows('Array.prototype.find.apply(null, function() { }, [])',
|
|
TypeError);
|
|
assertThrows('Array.prototype.find.apply(undefined, function() { }, [])',
|
|
TypeError);
|
|
|
|
assertThrows('[].find(null)', TypeError);
|
|
assertThrows('[].find(undefined)', TypeError);
|
|
assertThrows('[].find(0)', TypeError);
|
|
assertThrows('[].find(true)', TypeError);
|
|
assertThrows('[].find(false)', TypeError);
|
|
assertThrows('[].find("")', TypeError);
|
|
assertThrows('[].find({})', TypeError);
|
|
assertThrows('[].find([])', TypeError);
|
|
assertThrows('[].find(/\d+/)', TypeError);
|
|
|
|
assertThrows('Array.prototype.find.call({}, null)', TypeError);
|
|
assertThrows('Array.prototype.find.call({}, undefined)', TypeError);
|
|
assertThrows('Array.prototype.find.call({}, 0)', TypeError);
|
|
assertThrows('Array.prototype.find.call({}, true)', TypeError);
|
|
assertThrows('Array.prototype.find.call({}, false)', TypeError);
|
|
assertThrows('Array.prototype.find.call({}, "")', TypeError);
|
|
assertThrows('Array.prototype.find.call({}, {})', TypeError);
|
|
assertThrows('Array.prototype.find.call({}, [])', TypeError);
|
|
assertThrows('Array.prototype.find.call({}, /\d+/)', TypeError);
|
|
|
|
assertThrows('Array.prototype.find.apply({}, null, [])', TypeError);
|
|
assertThrows('Array.prototype.find.apply({}, undefined, [])', TypeError);
|
|
assertThrows('Array.prototype.find.apply({}, 0, [])', TypeError);
|
|
assertThrows('Array.prototype.find.apply({}, true, [])', TypeError);
|
|
assertThrows('Array.prototype.find.apply({}, false, [])', TypeError);
|
|
assertThrows('Array.prototype.find.apply({}, "", [])', TypeError);
|
|
assertThrows('Array.prototype.find.apply({}, {}, [])', TypeError);
|
|
assertThrows('Array.prototype.find.apply({}, [], [])', TypeError);
|
|
assertThrows('Array.prototype.find.apply({}, /\d+/, [])', TypeError);
|