ca54b83374
Speculative BigInt addition fails to throw the expected exception when called with non-BigInt inputs when the result of the computation is unused. In paricular, this CL does: - Remove kNoThrow on speculative BigInt operators - Fix AddWithFeedback to not lose type feedback if builtin throws to elide existing deopt loops - Add handling of TypeCheckKind in RepresentationChanger where this was previously ignored Bug: chromium:1073440 Change-Id: I953a5b790fc3b37a6824f0b6546a0488c51fbb3b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2228493 Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: Mythri Alle <mythria@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#68181}
35 lines
838 B
JavaScript
35 lines
838 B
JavaScript
// Copyright 2020 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --opt --allow-natives-syntax --no-always-opt
|
|
|
|
function foo(n) {
|
|
try {
|
|
let v = 0n;
|
|
for (let i = 0; i < n; ++i) {
|
|
v = 3n + v;
|
|
v = i;
|
|
}
|
|
} catch (e) {
|
|
return 1;
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
%PrepareFunctionForOptimization(foo);
|
|
assertEquals(foo(1), 0);
|
|
assertEquals(foo(1), 0);
|
|
%OptimizeFunctionOnNextCall(foo);
|
|
assertEquals(foo(1), 0);
|
|
assertOptimized(foo);
|
|
%PrepareFunctionForOptimization(foo);
|
|
assertEquals(foo(2), 1);
|
|
assertUnoptimized(foo);
|
|
// Check that we learned something and do not loop deoptimizations.
|
|
%OptimizeFunctionOnNextCall(foo);
|
|
assertEquals(foo(1), 0);
|
|
assertOptimized(foo);
|
|
assertEquals(foo(2), 1);
|
|
assertOptimized(foo);
|