86a2720763
The typical use of assertThrowsEquals is to check that a specific object is thrown. However, assertEquals only does a proper equality check for primitive types, not for complex types. Using assertSame does a reference equality check on objects, which is more what you would expect from assertThrowsEquals. For exception kind testing, assertThrowsEquals actually did not work correctly, assertThrows is better for that case. R=clemensh@chromium.org, mythria@chromium.org Change-Id: I24fb22e75fa33ebe90eb4bae40825119a054bba5 Reviewed-on: https://chromium-review.googlesource.com/1087952 Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Mythri Alle <mythria@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#53556} |
||
|---|---|---|
| .. | ||
| dead-code-source-position.js | ||
| dynamic-global-inside-block.js | ||
| ignition-statistics-extension.js | ||
| optimized-stack-trace.js | ||
| osr-from-bytecode.js | ||
| osr-from-generator.js | ||
| print-ast.js | ||
| regress-597565-double-to-object-transition.js | ||
| regress-599001-verifyheap.js | ||
| regress-612386-smi-to-double-transition.js | ||
| regress-616064.js | ||
| regress-629792-source-position-on-jump.js | ||
| regress-662418.js | ||
| regress-664146.js | ||
| regress-672027.js | ||
| stack-trace-source-position.js | ||
| string-concat-external-thin-string.js | ||
| throw-if-hole.js | ||
| throw-if-not-hole.js | ||
| throw-super-not-called.js | ||
| tracing.js | ||