896627dbef
It only had one callsite, and that callsite was useless:
%IsValidSmi(two_31) has never returned {true} on any
configuration we have ever shipped.
Bug: v8:10933
Change-Id: I09cdfd7bbd7960d1ec460ad4bd9f0d21e47f7393
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2434746
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Auto-Submit: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70285}
67 lines
2.4 KiB
JavaScript
67 lines
2.4 KiB
JavaScript
// Copyright 2013 the V8 project authors. All rights reserved.
|
|
// Redistribution and use in source and binary forms, with or without
|
|
// modification, are permitted provided that the following conditions are
|
|
// met:
|
|
//
|
|
// * Redistributions of source code must retain the above copyright
|
|
// notice, this list of conditions and the following disclaimer.
|
|
// * Redistributions in binary form must reproduce the above
|
|
// copyright notice, this list of conditions and the following
|
|
// disclaimer in the documentation and/or other materials provided
|
|
// with the distribution.
|
|
// * Neither the name of Google Inc. nor the names of its
|
|
// contributors may be used to endorse or promote products derived
|
|
// from this software without specific prior written permission.
|
|
//
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
// Flags: --allow-natives-syntax --opt --noalways-opt
|
|
|
|
function mul(a, b) {
|
|
return a * b;
|
|
}
|
|
|
|
|
|
%PrepareFunctionForOptimization(mul);
|
|
mul(-1, 2);
|
|
mul(-1, 2);
|
|
%OptimizeFunctionOnNextCall(mul);
|
|
assertEquals(-2, mul(-1, 2));
|
|
assertOptimized(mul);
|
|
|
|
// Deopt on minus zero.
|
|
assertEquals(-0, mul(-1, 0));
|
|
assertUnoptimized(mul);
|
|
|
|
|
|
function mul2(a, b) {
|
|
return a * b;
|
|
}
|
|
|
|
%PrepareFunctionForOptimization(mul2);
|
|
mul2(-1, 2);
|
|
mul2(-1, 2);
|
|
%OptimizeFunctionOnNextCall(mul2);
|
|
|
|
// -2^30 is in Smi range on most configurations, +2^30 is not.
|
|
var two_30 = 1 << 30;
|
|
assertEquals(two_30, mul2(-two_30, -1));
|
|
|
|
// For good measure, check that overflowing int32 range (or Smi range
|
|
// without pointer compression) works too.
|
|
var two_31 = two_30 * 2;
|
|
assertEquals(two_31, mul2(-two_31, -1));
|
|
|
|
// One of the two situations deoptimized the code.
|
|
assertUnoptimized(mul2);
|