a575608555
This reverts commitdc18b82221
. Reason for revert: still causing failures: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20debug/31566 Original change's description: > Reland^3 "[flags] warn about contradictory flags" > > This is a reland of0ba115e6a9
> Changes: > - Also allow second parameter influenced by --cache to be reassigned. > - Fix --stress-opt to only --always-opt in the last iteration as before. > > Original change's description: > > Reland^2 "[flags] warn about contradictory flags" > > > > This is a reland ofd8f8a7e210
> > Change compared to last reland: > > - Do not check for d8 flag contradictions in the presence of --fuzzing > > - Allow identical re-declaration of --cache=* > > > > Original change's description: > > > Reland "[flags] warn about contradictory flags" > > > > > > This is a reland ofb8f9166664
> > > Difference to previous CL: Additional functionality to specify > > > incompatible flags based on GN variables and extra-flags, used > > > to fix the issues that came up on the waterfall. > > > > > > This also changes the rules regarding repeated flags: While > > > explicitly repeated flags are allowed for boolean values as long > > > as they are identical, repeated flags or explicit flags in the > > > presence of an active implication are disallowed for non-boolean > > > flags. The latter simplifies specifying conflict rules in > > > variants.py. Otherwise a rule like > > > > > > INCOMPATIBLE_FLAGS_PER_EXTRA_FLAG = { > > > "--gc-interval=*": ["--gc-interval=*"], > > > } > > > > > > wouldn't work because specifying the same GC interval twice > > > wouldn't actually count as a conflict. This was an issue with > > > test/mjsunit/wasm/gc-buffer.js, which specifies > > > --gc-interval=500 exactly like the extra flag by the stress bot. > > > > > > Also, this now expands contradictory flags checking to d8 flags > > > for consistency. > > > > > > Original change's description: > > > > [flags] warn about contradictory flags > > > > > > > > Design Doc: https://docs.google.com/document/d/1lkvu8crkK7Ei39qjkPCFijpNyxWXsOktG9GB-7K34jM/ > > > > > > > > Bug: v8:10577 > > > > Change-Id: Ib9cfdffa401c48c895bf31caed5ee03545beddab > > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2154792 > > > > Reviewed-by: Clemens Backes <clemensb@chromium.org> > > > > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > > > > Reviewed-by: Georg Neis <neis@chromium.org> > > > > Reviewed-by: Tamer Tas <tmrts@chromium.org> > > > > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#68168} > > > > > > Bug: v8:10577 > > > Change-Id: I268e590ee18a535b13dee14eeb15ddd0a9ee8341 > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235115 > > > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > > > Reviewed-by: Tamer Tas <tmrts@chromium.org> > > > Reviewed-by: Clemens Backes <clemensb@chromium.org> > > > Reviewed-by: Georg Neis <neis@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#68989} > > > > Bug: v8:10577 > > Change-Id: I31d2794d4f9ff630f3444210100c64d67d881276 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2339464 > > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > > Reviewed-by: Clemens Backes <clemensb@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#69339} > > Bug: v8:10577 > Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng > Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng > Change-Id: I4a69dc57a102782cb453144323e3752ac8278624 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2352770 > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#69433} TBR=machenbach@chromium.org,neis@chromium.org,clemensb@chromium.org,tebbi@chromium.org,tmrts@chromium.org Change-Id: I4ccdd7b931d0ddccbcec1d6cfae8d4874ee49cfc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10577 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2360414 Reviewed-by: Francis McCabe <fgm@chromium.org> Commit-Queue: Francis McCabe <fgm@chromium.org> Cr-Commit-Position: refs/heads/master@{#69438}
89 lines
2.3 KiB
JavaScript
89 lines
2.3 KiB
JavaScript
// Copyright 2015 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
// Flags: --allow-natives-syntax --noverify-heap --noenable-slow-asserts
|
|
// Flags: --opt --no-always-opt
|
|
|
|
// --noverify-heap and --noenable-slow-asserts are set because the test is too
|
|
// slow with it on.
|
|
|
|
// Ensure that keyed stores work, and optimized functions learn if the
|
|
// store required change to dictionary mode. Verify that stores that grow
|
|
// the array into large object space don't cause a deopt.
|
|
(function() {
|
|
var a = [];
|
|
|
|
function foo(a, i) {
|
|
a[i] = 5.3;
|
|
}
|
|
|
|
%PrepareFunctionForOptimization(foo);
|
|
foo(a, 1);
|
|
foo(a, 2);
|
|
foo(a, 3);
|
|
%OptimizeFunctionOnNextCall(foo);
|
|
a[3] = 0;
|
|
foo(a, 3);
|
|
assertEquals(a[3], 5.3);
|
|
foo(a, 50000);
|
|
assertUnoptimized(foo);
|
|
assertTrue(%HasDictionaryElements(a));
|
|
|
|
%PrepareFunctionForOptimization(foo);
|
|
var b = [];
|
|
foo(b, 1);
|
|
foo(b, 2);
|
|
// Put b in dictionary mode.
|
|
b[10000] = 5;
|
|
assertTrue(%HasDictionaryElements(b));
|
|
foo(b, 3);
|
|
%PrepareFunctionForOptimization(foo);
|
|
%OptimizeFunctionOnNextCall(foo);
|
|
foo(b, 50000);
|
|
assertOptimized(foo);
|
|
assertTrue(%HasDictionaryElements(b));
|
|
|
|
// Clearing feedback for the StoreIC in foo is important for runs with
|
|
// flag --stress-opt.
|
|
%ClearFunctionFeedback(foo);
|
|
})();
|
|
|
|
|
|
(function() {
|
|
var a = new Array(10);
|
|
|
|
function foo2(a, i) {
|
|
a[i] = 50;
|
|
}
|
|
|
|
// The KeyedStoreIC will learn GROW_MODE.
|
|
%PrepareFunctionForOptimization(foo2);
|
|
foo2(a, 10);
|
|
foo2(a, 12);
|
|
foo2(a, 31);
|
|
%OptimizeFunctionOnNextCall(foo2);
|
|
foo2(a, 40);
|
|
|
|
assertOptimized(foo2);
|
|
assertTrue(%HasSmiElements(a));
|
|
|
|
// Grow a large array into large object space through the keyed store
|
|
// without deoptimizing. Grow by 9s. If we set elements too sparsely, the
|
|
// array will convert to dictionary mode.
|
|
a = new Array(99999);
|
|
assertTrue(%HasSmiElements(a));
|
|
for (var i = 0; i < 263000; i += 9) {
|
|
foo2(a, i);
|
|
}
|
|
|
|
// Verify that we are over 1 page in size, and foo2 remains optimized.
|
|
// This means we've smoothly transitioned to allocating in large object
|
|
// space.
|
|
assertTrue(%HasSmiElements(a));
|
|
assertTrue(a.length * 4 > (1024 * 1024));
|
|
assertOptimized(foo2);
|
|
|
|
%ClearFunctionFeedback(foo2);
|
|
})();
|