496864f8af
This relands commit d3e9aade0f. The original CL was reverted speculatively but didn't cause the buildbot failure.
Original change's description:
> [Interpreter] Move BinaryOp Smi transformation into BytecodeGenerator.
>
> Perform the transformation to <BinaryOp>Smi for Binary ops which take Smi
> literals in the BytecodeGenerator. This enables us to perform the
> transformation for literals on either side for commutative operations, and
> Avoids having to do the check on every bytecode in the peephole optimizer.
>
> In the process, adds Smi bytecode variants for all binary operations, adding
> - MulSmi
> - DivSmi
> - ModSmi
> - BitwiseXorSmi
> - ShiftRightLogical
>
> BUG=v8:6194
>
> Change-Id: If1484252f5385c16957004b9cac8bfbb1f209219
> Reviewed-on: https://chromium-review.googlesource.com/466246
> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Reviewed-by: Igor Sheludko <ishell@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#44477}
TBR=rmcilroy@chromium.org,machenbach@chromium.org,yangguo@chromium.org,mstarzinger@chromium.org,mythria@chromium.org,v8-reviews@googlegroups.com,ishell@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
BUG=v8:6194
Change-Id: I2ccaefa1ce58d3885f5c2648755985c06f25c1d8
Reviewed-on: https://chromium-review.googlesource.com/472746
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#44511}
120 lines
2.7 KiB
Plaintext
120 lines
2.7 KiB
Plaintext
#
|
|
# Autogenerated by generate-bytecode-expectations.
|
|
#
|
|
|
|
---
|
|
wrap: yes
|
|
|
|
---
|
|
snippet: "
|
|
return [ 1, 2 ];
|
|
"
|
|
frame size: 0
|
|
parameter count: 1
|
|
bytecode array length: 6
|
|
bytecodes: [
|
|
/* 30 E> */ B(StackCheck),
|
|
/* 34 S> */ B(CreateArrayLiteral), U8(0), U8(2), U8(9),
|
|
/* 51 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
CONSTANT_ELEMENTS_PAIR_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
var a = 1; return [ a, a + 1 ];
|
|
"
|
|
frame size: 3
|
|
parameter count: 1
|
|
bytecode array length: 36
|
|
bytecodes: [
|
|
/* 30 E> */ B(StackCheck),
|
|
/* 42 S> */ B(LdaSmi), I8(1),
|
|
B(Star), R(0),
|
|
/* 45 S> */ B(CreateArrayLiteral), U8(0), U8(3), U8(9),
|
|
B(Star), R(2),
|
|
B(LdaZero),
|
|
B(Star), R(1),
|
|
B(Ldar), R(0),
|
|
/* 54 E> */ B(StaKeyedPropertySloppy), R(2), R(1), U8(4),
|
|
B(LdaSmi), I8(1),
|
|
B(Star), R(1),
|
|
B(Ldar), R(0),
|
|
/* 59 E> */ B(AddSmi), I8(1), U8(2),
|
|
B(StaKeyedPropertySloppy), R(2), R(1), U8(4),
|
|
B(Ldar), R(2),
|
|
/* 66 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
CONSTANT_ELEMENTS_PAIR_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
return [ [ 1, 2 ], [ 3 ] ];
|
|
"
|
|
frame size: 0
|
|
parameter count: 1
|
|
bytecode array length: 6
|
|
bytecodes: [
|
|
/* 30 E> */ B(StackCheck),
|
|
/* 34 S> */ B(CreateArrayLiteral), U8(0), U8(4), U8(0),
|
|
/* 62 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
CONSTANT_ELEMENTS_PAIR_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|
|
---
|
|
snippet: "
|
|
var a = 1; return [ [ a, 2 ], [ a + 2 ] ];
|
|
"
|
|
frame size: 5
|
|
parameter count: 1
|
|
bytecode array length: 66
|
|
bytecodes: [
|
|
/* 30 E> */ B(StackCheck),
|
|
/* 42 S> */ B(LdaSmi), I8(1),
|
|
B(Star), R(0),
|
|
/* 45 S> */ B(CreateArrayLiteral), U8(0), U8(9), U8(0),
|
|
B(Star), R(2),
|
|
B(LdaZero),
|
|
B(Star), R(1),
|
|
B(CreateArrayLiteral), U8(1), U8(2), U8(9),
|
|
B(Star), R(4),
|
|
B(LdaZero),
|
|
B(Star), R(3),
|
|
B(Ldar), R(0),
|
|
/* 56 E> */ B(StaKeyedPropertySloppy), R(4), R(3), U8(3),
|
|
B(Ldar), R(4),
|
|
B(StaKeyedPropertySloppy), R(2), R(1), U8(10),
|
|
B(LdaSmi), I8(1),
|
|
B(Star), R(1),
|
|
B(CreateArrayLiteral), U8(2), U8(6), U8(9),
|
|
B(Star), R(4),
|
|
B(LdaZero),
|
|
B(Star), R(3),
|
|
B(Ldar), R(0),
|
|
/* 68 E> */ B(AddSmi), I8(2), U8(5),
|
|
B(StaKeyedPropertySloppy), R(4), R(3), U8(7),
|
|
B(Ldar), R(4),
|
|
B(StaKeyedPropertySloppy), R(2), R(1), U8(10),
|
|
B(Ldar), R(2),
|
|
/* 77 S> */ B(Return),
|
|
]
|
|
constant pool: [
|
|
CONSTANT_ELEMENTS_PAIR_TYPE,
|
|
CONSTANT_ELEMENTS_PAIR_TYPE,
|
|
CONSTANT_ELEMENTS_PAIR_TYPE,
|
|
]
|
|
handlers: [
|
|
]
|
|
|