a7c8a3ea9b
This changes the behavior of SetBreakpointForScript to find more accurate break positions. Previously, setting a breakpoint would only consider the shared function info that contained the requested position for setting a breakpoint. More intuitively, a breakpoint should not necessarily be set in a function that contains the position, but in the closest breakable location that comes after the position we requested. To achieve this we: 1. find the shared function info of the inner most function that contains the requested_position. This function's end position is used to find other shared function infos in step 2. 2. search for all shared function infos that intersect with the range [requested_position, inner_most_function.break_position[. 3. From the shared function infos extracted in 2, find the one that has the closest breakable location to requested_position. Also-By: bmeurer@chromium.org Fixed: chromium:1137141 Change-Id: I4f4c6c3aac1ebea50cbcad9543b539ab1ded2b05 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2742198 Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#73392}
67 lines
1.0 KiB
Plaintext
67 lines
1.0 KiB
Plaintext
Checks if we can set a breakpoint on a one-line inline functions.
|
|
Setting breakpoint on `class X`
|
|
|
|
function foo() {}
|
|
var bar = "bar";
|
|
|
|
class X {
|
|
constructor() {
|
|
|_|this.x = 1;
|
|
}
|
|
[bar] = 2;
|
|
baz = foo();
|
|
}
|
|
new X();
|
|
|
|
Setting breakpoint on constructor, should resolve to same location
|
|
|
|
function foo() {}
|
|
var bar = "bar";
|
|
|
|
class X {
|
|
constructor() {
|
|
|_|this.x = 1;
|
|
}
|
|
[bar] = 2;
|
|
baz = foo();
|
|
}
|
|
new X();
|
|
|
|
Setting breakpoint on computed properties in class
|
|
|
|
function foo() {}
|
|
var bar = "bar";
|
|
|
|
class X {
|
|
constructor() {
|
|
this.x = 1;
|
|
}
|
|
[|_|bar] = 2;
|
|
baz = foo();
|
|
}
|
|
new X();
|
|
|
|
Setting breakpoint on initializer function
|
|
|
|
function foo() {}
|
|
var bar = "bar";
|
|
|
|
class X {
|
|
constructor() {
|
|
this.x = 1;
|
|
}
|
|
[bar] = 2;
|
|
baz = |_|foo();
|
|
}
|
|
new X();
|
|
|
|
Paused on location:
|
|
(anonymous) (testInitializer.js:8:3)
|
|
Paused on location:
|
|
<instance_members_initializer> (testInitializer.js:9:8)
|
|
X (testInitializer.js:5:13)
|
|
(anonymous) (testInitializer.js:11:0)
|
|
Paused on location:
|
|
X (testInitializer.js:6:4)
|
|
(anonymous) (testInitializer.js:11:0)
|