4a19c62fc6
This reverts commit 7458e67c4e
.
Reason for revert: Crash on windows https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Win64%20-%20debug/37698/overview
Original change's description:
> cppgc: Implement basic Member and Persistent checks
>
> Adds check for
> - same heap on assignment
> - header and containment
>
> The verification state is eagerly created for on-heap Member
> references using caged heap and lazily created on first assignment for
> all others.
>
> Bug: chromium:1056170
> Change-Id: I38ee18eeb7ac489f69a46670cc5e5abe07f62dfa
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2878745
> Reviewed-by: Omer Katz <omerkatz@chromium.org>
> Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#74449}
Bug: chromium:1056170
Change-Id: I466522a7d879560c99dabbd96c3b097894743a87
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2880149
Auto-Submit: Zhi An Ng <zhin@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#74450}
147 lines
4.3 KiB
C++
147 lines
4.3 KiB
C++
// Copyright 2020 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef INCLUDE_CPPGC_INTERNAL_POINTER_POLICIES_H_
|
|
#define INCLUDE_CPPGC_INTERNAL_POINTER_POLICIES_H_
|
|
|
|
#include <cstdint>
|
|
#include <type_traits>
|
|
|
|
#include "cppgc/internal/write-barrier.h"
|
|
#include "cppgc/source-location.h"
|
|
#include "v8config.h" // NOLINT(build/include_directory)
|
|
|
|
namespace cppgc {
|
|
namespace internal {
|
|
|
|
class PersistentRegion;
|
|
class CrossThreadPersistentRegion;
|
|
|
|
// Tags to distinguish between strong and weak member types.
|
|
class StrongMemberTag;
|
|
class WeakMemberTag;
|
|
class UntracedMemberTag;
|
|
|
|
struct DijkstraWriteBarrierPolicy {
|
|
static void InitializingBarrier(const void*, const void*) {
|
|
// Since in initializing writes the source object is always white, having no
|
|
// barrier doesn't break the tri-color invariant.
|
|
}
|
|
static void AssigningBarrier(const void* slot, const void* value) {
|
|
WriteBarrier::Params params;
|
|
switch (WriteBarrier::GetWriteBarrierType(slot, value, params)) {
|
|
case WriteBarrier::Type::kGenerational:
|
|
WriteBarrier::GenerationalBarrier(params, slot);
|
|
break;
|
|
case WriteBarrier::Type::kMarking:
|
|
WriteBarrier::DijkstraMarkingBarrier(params, value);
|
|
break;
|
|
case WriteBarrier::Type::kNone:
|
|
break;
|
|
}
|
|
}
|
|
};
|
|
|
|
struct NoWriteBarrierPolicy {
|
|
static void InitializingBarrier(const void*, const void*) {}
|
|
static void AssigningBarrier(const void*, const void*) {}
|
|
};
|
|
|
|
class V8_EXPORT EnabledCheckingPolicy {
|
|
protected:
|
|
EnabledCheckingPolicy();
|
|
void CheckPointer(const void* ptr);
|
|
|
|
private:
|
|
void* impl_;
|
|
};
|
|
|
|
class DisabledCheckingPolicy {
|
|
protected:
|
|
void CheckPointer(const void* raw) {}
|
|
};
|
|
|
|
#if V8_ENABLE_CHECKS
|
|
using DefaultCheckingPolicy = EnabledCheckingPolicy;
|
|
#else
|
|
using DefaultCheckingPolicy = DisabledCheckingPolicy;
|
|
#endif
|
|
|
|
class KeepLocationPolicy {
|
|
public:
|
|
constexpr const SourceLocation& Location() const { return location_; }
|
|
|
|
protected:
|
|
constexpr KeepLocationPolicy() = default;
|
|
constexpr explicit KeepLocationPolicy(const SourceLocation& location)
|
|
: location_(location) {}
|
|
|
|
// KeepLocationPolicy must not copy underlying source locations.
|
|
KeepLocationPolicy(const KeepLocationPolicy&) = delete;
|
|
KeepLocationPolicy& operator=(const KeepLocationPolicy&) = delete;
|
|
|
|
// Location of the original moved from object should be preserved.
|
|
KeepLocationPolicy(KeepLocationPolicy&&) = default;
|
|
KeepLocationPolicy& operator=(KeepLocationPolicy&&) = default;
|
|
|
|
private:
|
|
SourceLocation location_;
|
|
};
|
|
|
|
class IgnoreLocationPolicy {
|
|
public:
|
|
constexpr SourceLocation Location() const { return {}; }
|
|
|
|
protected:
|
|
constexpr IgnoreLocationPolicy() = default;
|
|
constexpr explicit IgnoreLocationPolicy(const SourceLocation&) {}
|
|
};
|
|
|
|
#if CPPGC_SUPPORTS_OBJECT_NAMES
|
|
using DefaultLocationPolicy = KeepLocationPolicy;
|
|
#else
|
|
using DefaultLocationPolicy = IgnoreLocationPolicy;
|
|
#endif
|
|
|
|
struct StrongPersistentPolicy {
|
|
using IsStrongPersistent = std::true_type;
|
|
static V8_EXPORT PersistentRegion& GetPersistentRegion(const void* object);
|
|
};
|
|
|
|
struct WeakPersistentPolicy {
|
|
using IsStrongPersistent = std::false_type;
|
|
static V8_EXPORT PersistentRegion& GetPersistentRegion(const void* object);
|
|
};
|
|
|
|
struct StrongCrossThreadPersistentPolicy {
|
|
using IsStrongPersistent = std::true_type;
|
|
static V8_EXPORT CrossThreadPersistentRegion& GetPersistentRegion(
|
|
const void* object);
|
|
};
|
|
|
|
struct WeakCrossThreadPersistentPolicy {
|
|
using IsStrongPersistent = std::false_type;
|
|
static V8_EXPORT CrossThreadPersistentRegion& GetPersistentRegion(
|
|
const void* object);
|
|
};
|
|
|
|
// Forward declarations setting up the default policies.
|
|
template <typename T, typename WeaknessPolicy,
|
|
typename LocationPolicy = DefaultLocationPolicy,
|
|
typename CheckingPolicy = DisabledCheckingPolicy>
|
|
class BasicCrossThreadPersistent;
|
|
template <typename T, typename WeaknessPolicy,
|
|
typename LocationPolicy = DefaultLocationPolicy,
|
|
typename CheckingPolicy = DefaultCheckingPolicy>
|
|
class BasicPersistent;
|
|
template <typename T, typename WeaknessTag, typename WriteBarrierPolicy,
|
|
typename CheckingPolicy = DefaultCheckingPolicy>
|
|
class BasicMember;
|
|
|
|
} // namespace internal
|
|
|
|
} // namespace cppgc
|
|
|
|
#endif // INCLUDE_CPPGC_INTERNAL_POINTER_POLICIES_H_
|