69383d6366
Reason for revert: Reland since the failure has been fixed in https://codereview.chromium.org/1035523005/ Original issue's description: > Revert of Debugger: deduplicate shared function info when setting script break points. (patchset #4 id:60001 of https://codereview.chromium.org/998253005/) > > Reason for revert: > Code caching failures. > > Original issue's description: > > Debugger: deduplicate shared function info when setting script break points. > > > > Also fix Debug.showBreakPoints for multiple break points at the same location. > > > > BUG=v8:3960 > > LOG=N > > > > Committed: https://crrev.com/73b17a71a22564c0b66d9aa7c00948c748f5b290 > > Cr-Commit-Position: refs/heads/master@{#27444} > > TBR=mstarzinger@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:3960 > > Committed: https://crrev.com/9b29d008dfcc00bf56be8040add1d2c5e404673b > Cr-Commit-Position: refs/heads/master@{#27448} TBR=mstarzinger@chromium.org BUG=v8:3960 LOG=N Review URL: https://codereview.chromium.org/1037013002 Cr-Commit-Position: refs/heads/master@{#27472}
70 lines
2.7 KiB
JavaScript
70 lines
2.7 KiB
JavaScript
// Copyright 2010 the V8 project authors. All rights reserved.
|
|
// Redistribution and use in source and binary forms, with or without
|
|
// modification, are permitted provided that the following conditions are
|
|
// met:
|
|
//
|
|
// * Redistributions of source code must retain the above copyright
|
|
// notice, this list of conditions and the following disclaimer.
|
|
// * Redistributions in binary form must reproduce the above
|
|
// copyright notice, this list of conditions and the following
|
|
// disclaimer in the documentation and/or other materials provided
|
|
// with the distribution.
|
|
// * Neither the name of Google Inc. nor the names of its
|
|
// contributors may be used to endorse or promote products derived
|
|
// from this software without specific prior written permission.
|
|
//
|
|
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
|
|
// Flags: --expose-debug-as debug --noalways-opt
|
|
// Get the Debug object exposed from the debug context global object.
|
|
|
|
// In this test case we edit a script so that techincally function text
|
|
// hasen't been changed. However actually function became one level more nested
|
|
// and must be recompiled because it uses variable from outer scope.
|
|
|
|
|
|
Debug = debug.Debug
|
|
|
|
eval(
|
|
"function TestFunction() {\n"
|
|
+ " var a = 'a';\n"
|
|
+ " var b = 'b';\n"
|
|
+ " var c = 'c';\n"
|
|
+ " function A() {\n"
|
|
+ " return 2013;\n"
|
|
+ " }\n"
|
|
+ " function B() {\n"
|
|
+ " return String([a, c]);\n"
|
|
+ " }\n"
|
|
+ " return B();\n"
|
|
+ "}\n"
|
|
);
|
|
|
|
var res = TestFunction();
|
|
print(res);
|
|
assertEquals('a,c', res);
|
|
|
|
var script = Debug.findScript(TestFunction);
|
|
var new_source = script.source.replace("2013", "b");
|
|
print("new source: " + new_source);
|
|
var change_log = new Array();
|
|
var result = Debug.LiveEdit.SetScriptSource(script, new_source, false, change_log);
|
|
|
|
print("Result: " + JSON.stringify(result) + "\n");
|
|
print("Change log: " + JSON.stringify(change_log) + "\n");
|
|
|
|
var res = TestFunction();
|
|
print(res);
|
|
// This might be 'a,b' without a bug fixed.
|
|
assertEquals('a,c', res);
|