AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity
4aeccdb23e
v8/test/cctest
History
yurys@chromium.org 4aeccdb23e Do not iterate stack handlers in SafeStackFrameIterator 
CPU profiler doesn't use stack handlers so there is no need to iterate through them while traversing stack. This change SafeStackFrameIterator always iterate only frames and removes checks corresponding to the handlers iteration.

The problem described in the bug occurred because of a false assumption in SafeStackFrameIterator that if Isolate::c_entry_fp is not NULL then the top frame on the stack is always a C++ frame. It is false because we may have entered JS code again, in which case JS_ENTRY code stub generated by JSEntryStub::GenerateBody() will save current c_entry_fp value but not reset it to NULL and after that it will create ENTRY stack frame and JS_ENTRY handler on the stack and put the latter into Isolate::handler(top). This means that if we start iterating from c_entry_fp frame and try to compare the frame's sp with Isolate::handler()->address() it will turn out that frame->sp() > handler->address() and the condition in SafeStackFrameIterator::CanIterateHandles is not held.

BUG=252097
R=loislo@chromium.org, svenpanne@chromium.org

Review URL: https://codereview.chromium.org/17589022

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15348 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
2013-06-27 09:28:11 +00:00
..
cctest.cc Change ArrayBuffer API and implementation to use embedder-provided allocator. 2013-06-11 10:41:14 +00:00
cctest.gyp Revert "Improved range analysis for bitwise operations." 2013-06-14 17:25:03 +00:00
cctest.h remove most uses of raw handle constructors 2013-06-13 09:27:09 +00:00
cctest.status MIPS: Fix test-cpu-profiler/SampleWhenFrameIsNotSetup flakiness on MIPS simulator. 2013-06-19 17:20:25 +00:00
gay-fixed.cc Dtoa for fixed notation. 2010-05-05 13:51:27 +00:00
gay-fixed.h Dtoa for fixed notation. 2010-05-05 13:51:27 +00:00
gay-precision.cc Added precision mode to fast-dtoa. 2010-09-20 09:18:00 +00:00
gay-precision.h Added precision mode to fast-dtoa. 2010-09-20 09:18:00 +00:00
gay-shortest.cc Dtoa for fixed notation. 2010-05-05 13:51:27 +00:00
gay-shortest.h Dtoa for fixed notation. 2010-05-05 13:51:27 +00:00
log-eq-of-logging-and-traversal.js Eliminate the need for code delete events in CPU profiler. 2011-09-14 11:47:03 +00:00
test-accessors.cc remove all old style callbacks - patch 1 of many 2013-06-20 08:12:59 +00:00
test-alloc.cc Deprecate FACTORY helper macro. 2013-06-04 10:30:05 +00:00
test-api.cc Allow users of the V8 API to distinguish between unset and undefined HiddenValues 2013-06-26 08:00:05 +00:00
test-assembler-arm.cc Deprecate FACTORY helper macro. 2013-06-04 10:30:05 +00:00
test-assembler-ia32.cc Deprecate FACTORY helper macro. 2013-06-04 10:30:05 +00:00
test-assembler-mips.cc MIPS: Fix cctest/test-assembler-mips on MIPS32R1 architecture. 2013-06-19 17:15:21 +00:00
test-assembler-x64.cc remove most V8_ALLOW_ACCESS_TO_* defines from test classes 2013-05-28 11:54:52 +00:00
test-ast.cc Get rid of ZoneScope completely. 2013-06-26 13:36:16 +00:00
test-bignum-dtoa.cc Fix X64 compilation on Windows. 2011-02-03 11:13:04 +00:00
test-bignum.cc Bignum implementation of Strtod. 2010-11-08 11:49:47 +00:00
test-circular-queue.cc Add missing license headers. 2013-03-07 11:12:26 +00:00
test-compare-nil-ic-stub.cc Migrate Compare ICs to new type rep 2013-06-12 17:20:37 +00:00
test-compiler.cc Fixed more gc stress builder tests. 2013-06-25 11:16:13 +00:00
test-conversions.cc Fix build failure on Linux since r14681. 2013-05-15 13:14:24 +00:00
test-cpu-profiler.cc Do not iterate stack handlers in SafeStackFrameIterator 2013-06-27 09:28:11 +00:00
test-dataflow.cc Get rid of ZoneScope completely. 2013-06-26 13:36:16 +00:00
test-date.cc Added a version of the v8::HandleScope constructor with an Isolate and use that consistently. 2013-03-15 12:06:53 +00:00
test-debug.cc Fixed more gc stress builder tests. 2013-06-25 11:16:13 +00:00
test-declarative-accessors.cc remove most uses of raw handle constructors 2013-06-13 09:27:09 +00:00
test-decls.cc remove all old style callbacks - patch 3 2013-06-20 12:28:27 +00:00
test-deoptimization.cc stop using AsciiValue 2013-05-13 14:18:05 +00:00
test-dictionary.cc Disable stress_compaction flag in several GC tests to meet test 2013-06-19 08:58:09 +00:00
test-disasm-arm.cc remove most V8_ALLOW_ACCESS_TO_* defines from test classes 2013-05-28 11:54:52 +00:00
test-disasm-ia32.cc Deprecate FACTORY helper macro. 2013-06-04 10:30:05 +00:00
test-disasm-mips.cc Unify the way cctest initalizes the VM for each test case. 2013-04-10 08:29:39 +00:00
test-disasm-x64.cc Unify the way cctest initalizes the VM for each test case. 2013-04-10 08:29:39 +00:00
test-diy-fp.cc Add missing license headers. 2013-03-07 11:12:26 +00:00
test-double.cc Add missing license headers. 2013-03-07 11:12:26 +00:00
test-dtoa.cc Fix compilation on 64-bit Windows, update Visual Studio projects. 2011-02-03 13:29:10 +00:00
test-fast-dtoa.cc Add missing license headers. 2013-03-07 11:12:26 +00:00
test-fixed-dtoa.cc Dtoa for fixed notation. 2010-05-05 13:51:27 +00:00
test-flags.cc Ensure removing processed command line arguments. 2012-06-13 15:02:05 +00:00
test-func-name-inference.cc Deprecate FACTORY helper macro. 2013-06-04 10:30:05 +00:00
test-global-handles.cc New GC APIs, try 2. 2013-04-24 15:59:23 +00:00
test-global-object.cc remove most uses of raw handle constructors 2013-06-13 09:27:09 +00:00
test-hashing.cc remove most V8_ALLOW_ACCESS_TO_* defines from test classes 2013-05-28 11:54:52 +00:00
test-hashmap.cc Make the hash map test run faster by doing less work. 2009-05-15 13:49:00 +00:00
test-heap-profiler.cc Handle AccessorPair struct in heap snapshot. 2013-06-25 11:55:33 +00:00
test-heap.cc Added pretenuring support for fast literal allocation in old data space. 2013-06-25 07:47:53 +00:00
test-list.cc Progress towards making Zones independent of Isolates and Threads. 2012-06-04 14:42:58 +00:00
test-liveedit.cc Get rid of ZoneScope completely. 2013-06-26 13:36:16 +00:00
test-lock.cc Add missing license headers. 2013-03-07 11:12:26 +00:00
test-lockers.cc remove most V8_ALLOW_ACCESS_TO_* defines from test classes 2013-05-28 11:54:52 +00:00
test-log-stack-tracer.cc remove all old style callbacks - patch 3 2013-06-20 12:28:27 +00:00
test-log.cc CPUProfiler: fix for test. 2013-06-24 13:03:19 +00:00
test-macro-assembler-x64.cc Make the Isolate parameter mandatory for internal HandleScopes. 2013-02-15 09:27:10 +00:00
test-mark-compact.cc Update boot-up memory use limit after adding DataView. 2013-06-24 07:02:53 +00:00
test-object-observe.cc remove most uses of raw handle constructors 2013-06-13 09:27:09 +00:00
test-parsing.cc Add initial parser support for harmony iteration 2013-06-06 14:38:26 +00:00
test-platform-linux.cc Add missing license headers. 2013-03-07 11:12:26 +00:00
test-platform-macos.cc Add missing license headers. 2013-03-07 11:12:26 +00:00
test-platform-nullos.cc Add missing license headers. 2013-03-07 11:12:26 +00:00
test-platform-tls.cc Add missing license headers. 2013-03-07 11:12:26 +00:00
test-platform-win32.cc Make gyp work with MingW32 2013-04-15 08:33:31 +00:00
test-platform.cc Determine number of available cores on all platforms. 2013-02-15 12:38:59 +00:00
test-profile-generator.cc CPUProfiler: Simplify CodeEntry constructor calls. 2013-06-26 16:04:25 +00:00
test-random.cc Deprecate FACTORY helper macro. 2013-06-04 10:30:05 +00:00
test-regexp.cc Get rid of ZoneScope completely. 2013-06-26 13:36:16 +00:00
test-reloc-info.cc Merge experimental/gc branch to the bleeding_edge. 2011-09-19 18:36:47 +00:00
test-serialize.cc Remove unused counters 2013-06-19 16:50:38 +00:00
test-sockets.cc Add missing license headers. 2013-03-07 11:12:26 +00:00
test-spaces.cc Use MemoryChunk-based allocation for deoptimization entry code 2013-01-29 09:09:55 +00:00
test-strings.cc Get rid of ZoneScope completely. 2013-06-26 13:36:16 +00:00
test-strtod.cc Add missing license headers. 2013-03-07 11:12:26 +00:00
test-symbols.cc remove most V8_ALLOW_ACCESS_TO_* defines from test classes 2013-05-28 11:54:52 +00:00
test-thread-termination.cc remove all old style callbacks - patch 3 2013-06-20 12:28:27 +00:00
test-threads.cc remove most V8_ALLOW_ACCESS_TO_* defines from test classes 2013-05-28 11:54:52 +00:00
test-types.cc Introduce Unsigned32 and RegExp types 2013-06-26 09:51:57 +00:00
test-unbound-queue.cc Add missing license headers. 2013-03-07 11:12:26 +00:00
test-utils.cc Replace OS::MemCopy with OS::MemMove (just as fast but more flexible). 2013-04-16 12:30:51 +00:00
test-version.cc Update V8 to version 3.0 (re-land r5920). 2010-12-07 11:31:57 +00:00
test-weakmaps.cc remove old MakeWeak 2013-06-03 08:17:04 +00:00
test-weaktypedarrays.cc API for DataView. 2013-06-24 11:23:50 +00:00
testcfg.py Remove SCons related files 2013-04-18 11:01:14 +00:00