2d51120a9d
This adds new modes to run gcmole on multiple hosts: - collect: Parse source files and store partial raw call graph in a binary output file. - merge: Read multiple partial call graphs stored by 'collect', merge them and store the gc-suspect information. - check: Use the stored suspect information to check source files for problems. The modes 'collect' and 'check' support sharding parameters, so that each shard runs on a deterministic fraction of the source files. The previous way of running gcmole locally is unchanged as 'full' run. All modes also support the --test-run parameter, running against a test double. The parameter to reuse suspects is removed as the new 'check' mode makes it redundant. This also adds python tests to verify most additions for merging call graphs and for distributing source files to shards. The new API is used on the infra side via the gcmole_v3 config, which we configure now in parallel to the previous version to test for equality. Based on the builders.pyl change, these additions also run on the v8_linux_rel trybot on this CL. Bug: v8:12660 Change-Id: Ibe66292cb00830fa1c23451081a8de4cbc4766a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4075907 Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Liviu Rau <liviurau@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#84674} |
||
---|---|---|
.. | ||
builders.pyl | ||
PRESUBMIT.py | ||
README.md |
Src-side test specifications
Src-side test specifications enable developers to quickly add tests running on specific bots on V8's continuous infrastructure (CI) or tryserver. Features to be tested must live behind runtime flags, which are mapped to named testing variants specified here. Changes to src-side test specifications go through CQ like any other CL and require tests added for specific trybots to pass.
The test specifications are defined in a V8-side python-literal file
infra/testing/builders.pyl
.
The structure of the file is:
{
<buildername>: {
'tests': [
{
'name': <test-spec name>,
'suffix': <step suffix>,
'variant': <variant name>,
'shards': <number of shards>,
'test_args': <list of flags>,
'swarming_task_attrs': {...},
'swarming_dimensions': {...},
},
...
],
'swarming_task_attrs': {...},
'swarming_dimensions': {...},
},
...
}
The <buildername>
is a string name of the builder to execute the tests.
<test-spec name>
is a label defining a test specification matching the
infra-side.
The optional suffix
will be appended to test-step names for disambiguation.
The optional variant
is a testing variant specified
here.
The optional shards
(default 1) can be provided to increase the swarming
shards for long-running tests.
The optional test_args
is a list of string flags that will be passed to the
V8 test driver.
The optional swarming_task_attrs
is a dict allowing to override the defaults
for priority
, expiration
and hard_timeout
.
The optional swarming_dimensions
is a dict allowing to override the defaults
for cpu
, cores
and os
.
Both swarming_task_attrs
and swarming_dimensions
can be defined per builder
and per test, whereas the latter takes precedence.
Example:
{
'v8_linux64_rel_ng_triggered': {
'tests': [
{
'name': 'v8testing',
'suffix': 'stress',
'variant': 'nooptimization',
'shards': 2,
'test_args': ['--gc-stress'],
'swarming_dimensions': {'os': 'Ubuntu-14.4'},
},
],
'swarming_properties': {'priority': 35},
'swarming_dimensions': {'os': 'Ubuntu'},
},
}
Guidelines
Please keep trybots and continuous bots in sync. E.g. add the same configuration for the release and debug CI bots and the corresponding trybot (where applicable). E.g.
tryserver.v8:
v8_linux64_rel_ng_triggered
client.v8:
V8 Linux64
V8 Linux64 - debug
Please only add tests that are expected to pass, or skip failing tests via status file for the selected testing variants only. If you want to add FYI tests (i.e. not closing the tree and not blocking CQ) you can do so for the following set of bots:
tryserver.v8:
v8_linux64_fyi_rel_ng_triggered
client.v8:
V8 Linux64 - fyi
V8 Linux64 - debug - fyi