8c30a2ccc0
V8 test suites return tests by loading them into memory up-front. Up-front loading has memory and loading-time overhead for the testrunner. This CL converts the test-suites to load tests during the test run in parallel. After CL, most test suites start running immediately and all test suites start running after 3 seconds on a modern SSD. This CL eliminates the 200 MiB memory spikes that causes memory problems in mac minis. Overhead of running test262 before CL: Line # Mem usage Increment Line Contents ================================================= 264 225.760 MiB 195.8.000 MiB tests = self._load_testsuite_generators(args, options) ------------------------------------------------- Overhead of running test262 after CL: Line # Mem usage Increment Line Contents ================================================ 264 28.840 MiB 0.000 MiB tests = self._load_testsuite_generators(args, options) ------------------------------------------------- R=machenbach@chromium.org CC=yangguo@chromium.org,sergiyb@chromium.org Bug: v8:8174, v8:8552, v8:8728 Change-Id: Iab540b9410239b05dc80b4a5228db25d8b8fb3b9 Reviewed-on: https://chromium-review.googlesource.com/c/1454478 Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#59408}
83 lines
2.2 KiB
Python
83 lines
2.2 KiB
Python
# Copyright 2017 the V8 project authors. All rights reserved.
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
# found in the LICENSE file.
|
|
|
|
import os
|
|
|
|
from testrunner.local import command
|
|
from testrunner.local import utils
|
|
from testrunner.local import testsuite
|
|
from testrunner.objects import testcase
|
|
|
|
|
|
class VariantsGenerator(testsuite.VariantsGenerator):
|
|
def _get_variants(self, test):
|
|
return self._standard_variant
|
|
|
|
|
|
class TestLoader(testsuite.TestLoader):
|
|
def _list_test_filenames(self):
|
|
shell = os.path.abspath(
|
|
os.path.join(self.test_config.shell_dir, "unittests"))
|
|
if utils.IsWindows():
|
|
shell += ".exe"
|
|
|
|
output = None
|
|
for i in xrange(3): # Try 3 times in case of errors.
|
|
cmd = command.Command(
|
|
cmd_prefix=self.test_config.command_prefix,
|
|
shell=shell,
|
|
args=['--gtest_list_tests'] + self.test_config.extra_flags)
|
|
output = cmd.execute()
|
|
if output.exit_code == 0:
|
|
break
|
|
|
|
print "Test executable failed to list the tests (try %d).\n\nCmd:" % i
|
|
print cmd
|
|
print "\nStdout:"
|
|
print output.stdout
|
|
print "\nStderr:"
|
|
print output.stderr
|
|
print "\nExit code: %d" % output.exit_code
|
|
else:
|
|
raise Exception("Test executable failed to list the tests.")
|
|
|
|
# TODO create an ExecutableTestLoader for refactoring this similar to
|
|
# JSTestLoader.
|
|
test_names = []
|
|
for line in output.stdout.splitlines():
|
|
test_desc = line.strip().split()[0]
|
|
if test_desc.endswith('.'):
|
|
test_case = test_desc
|
|
elif test_case and test_desc:
|
|
test_names.append(test_case + test_desc)
|
|
|
|
return sorted(test_names)
|
|
|
|
|
|
class TestSuite(testsuite.TestSuite):
|
|
def _test_loader_class(self):
|
|
return TestLoader
|
|
|
|
def _test_class(self):
|
|
return TestCase
|
|
|
|
def _variants_gen_class(self):
|
|
return VariantsGenerator
|
|
|
|
|
|
class TestCase(testcase.TestCase):
|
|
def _get_suite_flags(self):
|
|
return (
|
|
["--gtest_filter=" + self.path] +
|
|
["--gtest_random_seed=%s" % self.random_seed] +
|
|
["--gtest_print_time=0"]
|
|
)
|
|
|
|
def get_shell(self):
|
|
return self.suite.name
|
|
|
|
|
|
def GetSuite(*args, **kwargs):
|
|
return TestSuite(*args, **kwargs)
|