4ededa8694
We can reduce the number of type feedback vector slots required, and also reduce IC misses. Review URL: https://codereview.chromium.org/1001533002 Cr-Commit-Position: refs/heads/master@{#27149}
395 lines
13 KiB
C++
395 lines
13 KiB
C++
// Copyright 2014 the V8 project authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "src/v8.h"
|
|
#include "test/cctest/cctest.h"
|
|
|
|
#include "src/api.h"
|
|
#include "src/debug.h"
|
|
#include "src/execution.h"
|
|
#include "src/factory.h"
|
|
#include "src/global-handles.h"
|
|
#include "src/macro-assembler.h"
|
|
#include "src/objects.h"
|
|
|
|
using namespace v8::internal;
|
|
|
|
namespace {
|
|
|
|
TEST(VectorStructure) {
|
|
LocalContext context;
|
|
v8::HandleScope scope(context->GetIsolate());
|
|
Isolate* isolate = CcTest::i_isolate();
|
|
Factory* factory = isolate->factory();
|
|
|
|
// Empty vectors are the empty fixed array.
|
|
FeedbackVectorSpec empty;
|
|
Handle<TypeFeedbackVector> vector = factory->NewTypeFeedbackVector(empty);
|
|
CHECK(Handle<FixedArray>::cast(vector)
|
|
.is_identical_to(factory->empty_fixed_array()));
|
|
// Which can nonetheless be queried.
|
|
CHECK_EQ(0, vector->ic_with_type_info_count());
|
|
CHECK_EQ(0, vector->ic_generic_count());
|
|
CHECK_EQ(0, vector->Slots());
|
|
CHECK_EQ(0, vector->ICSlots());
|
|
|
|
FeedbackVectorSpec one_slot(1, 0);
|
|
vector = factory->NewTypeFeedbackVector(one_slot);
|
|
CHECK_EQ(1, vector->Slots());
|
|
CHECK_EQ(0, vector->ICSlots());
|
|
|
|
FeedbackVectorSpec one_icslot(0, 1);
|
|
if (FLAG_vector_ics) {
|
|
one_icslot.SetKind(0, Code::CALL_IC);
|
|
}
|
|
vector = factory->NewTypeFeedbackVector(one_icslot);
|
|
CHECK_EQ(0, vector->Slots());
|
|
CHECK_EQ(1, vector->ICSlots());
|
|
|
|
FeedbackVectorSpec spec(3, 5);
|
|
if (FLAG_vector_ics) {
|
|
for (int i = 0; i < 5; i++) spec.SetKind(i, Code::CALL_IC);
|
|
}
|
|
vector = factory->NewTypeFeedbackVector(spec);
|
|
CHECK_EQ(3, vector->Slots());
|
|
CHECK_EQ(5, vector->ICSlots());
|
|
|
|
int metadata_length = vector->ic_metadata_length();
|
|
if (!FLAG_vector_ics) {
|
|
CHECK_EQ(0, metadata_length);
|
|
} else {
|
|
CHECK(metadata_length > 0);
|
|
}
|
|
|
|
int index = vector->GetIndex(FeedbackVectorSlot(0));
|
|
|
|
CHECK_EQ(TypeFeedbackVector::kReservedIndexCount + metadata_length, index);
|
|
CHECK(FeedbackVectorSlot(0) == vector->ToSlot(index));
|
|
|
|
index = vector->GetIndex(FeedbackVectorICSlot(0));
|
|
CHECK_EQ(index,
|
|
TypeFeedbackVector::kReservedIndexCount + metadata_length + 3);
|
|
CHECK(FeedbackVectorICSlot(0) == vector->ToICSlot(index));
|
|
|
|
CHECK_EQ(TypeFeedbackVector::kReservedIndexCount + metadata_length + 3 + 5,
|
|
vector->length());
|
|
}
|
|
|
|
|
|
// IC slots need an encoding to recognize what is in there.
|
|
TEST(VectorICMetadata) {
|
|
LocalContext context;
|
|
v8::HandleScope scope(context->GetIsolate());
|
|
if (!FLAG_vector_ics) {
|
|
// If FLAG_vector_ics is false, we only store CALL_ICs in the vector, so
|
|
// there is no need for metadata to describe the slots.
|
|
return;
|
|
}
|
|
Isolate* isolate = CcTest::i_isolate();
|
|
Factory* factory = isolate->factory();
|
|
|
|
FeedbackVectorSpec spec(10, 3 * 10);
|
|
// Set metadata.
|
|
for (int i = 0; i < 30; i++) {
|
|
Code::Kind kind;
|
|
if (i % 3 == 0) {
|
|
kind = Code::CALL_IC;
|
|
} else if (i % 3 == 1) {
|
|
kind = Code::LOAD_IC;
|
|
} else {
|
|
kind = Code::KEYED_LOAD_IC;
|
|
}
|
|
spec.SetKind(i, kind);
|
|
}
|
|
|
|
Handle<TypeFeedbackVector> vector = factory->NewTypeFeedbackVector(spec);
|
|
CHECK_EQ(10, vector->Slots());
|
|
CHECK_EQ(3 * 10, vector->ICSlots());
|
|
|
|
// Meanwhile set some feedback values and type feedback values to
|
|
// verify the data structure remains intact.
|
|
vector->change_ic_with_type_info_count(100);
|
|
vector->change_ic_generic_count(3333);
|
|
vector->Set(FeedbackVectorSlot(0), *vector);
|
|
|
|
// Verify the metadata is correctly set up from the spec.
|
|
for (int i = 0; i < 30; i++) {
|
|
Code::Kind kind = vector->GetKind(FeedbackVectorICSlot(i));
|
|
if (i % 3 == 0) {
|
|
CHECK_EQ(Code::CALL_IC, kind);
|
|
} else if (i % 3 == 1) {
|
|
CHECK_EQ(Code::LOAD_IC, kind);
|
|
} else {
|
|
CHECK_EQ(Code::KEYED_LOAD_IC, kind);
|
|
}
|
|
}
|
|
}
|
|
|
|
|
|
TEST(VectorSlotClearing) {
|
|
LocalContext context;
|
|
v8::HandleScope scope(context->GetIsolate());
|
|
Isolate* isolate = CcTest::i_isolate();
|
|
Factory* factory = isolate->factory();
|
|
|
|
// We only test clearing FeedbackVectorSlots, not FeedbackVectorICSlots.
|
|
// The reason is that FeedbackVectorICSlots need a full code environment
|
|
// to fully test (See VectorICProfilerStatistics test below).
|
|
FeedbackVectorSpec spec(5, 0);
|
|
Handle<TypeFeedbackVector> vector = factory->NewTypeFeedbackVector(spec);
|
|
|
|
// Fill with information
|
|
vector->Set(FeedbackVectorSlot(0), Smi::FromInt(1));
|
|
vector->Set(FeedbackVectorSlot(1), *factory->fixed_array_map());
|
|
Handle<AllocationSite> site = factory->NewAllocationSite();
|
|
vector->Set(FeedbackVectorSlot(2), *site);
|
|
|
|
vector->ClearSlots(NULL);
|
|
|
|
// The feedback vector slots are cleared. AllocationSites are granted
|
|
// an exemption from clearing, as are smis.
|
|
CHECK_EQ(Smi::FromInt(1), vector->Get(FeedbackVectorSlot(0)));
|
|
CHECK_EQ(*TypeFeedbackVector::UninitializedSentinel(isolate),
|
|
vector->Get(FeedbackVectorSlot(1)));
|
|
CHECK(vector->Get(FeedbackVectorSlot(2))->IsAllocationSite());
|
|
}
|
|
|
|
|
|
TEST(VectorICProfilerStatistics) {
|
|
if (i::FLAG_always_opt) return;
|
|
CcTest::InitializeVM();
|
|
LocalContext context;
|
|
v8::HandleScope scope(context->GetIsolate());
|
|
Isolate* isolate = CcTest::i_isolate();
|
|
Heap* heap = isolate->heap();
|
|
|
|
// Make sure function f has a call that uses a type feedback slot.
|
|
CompileRun(
|
|
"function fun() {};"
|
|
"function f(a) { a(); } f(fun);");
|
|
Handle<JSFunction> f = v8::Utils::OpenHandle(
|
|
*v8::Handle<v8::Function>::Cast(CcTest::global()->Get(v8_str("f"))));
|
|
// There should be one IC.
|
|
Handle<Code> code = handle(f->shared()->code(), isolate);
|
|
TypeFeedbackInfo* feedback_info =
|
|
TypeFeedbackInfo::cast(code->type_feedback_info());
|
|
CHECK_EQ(1, feedback_info->ic_total_count());
|
|
CHECK_EQ(0, feedback_info->ic_with_type_info_count());
|
|
CHECK_EQ(0, feedback_info->ic_generic_count());
|
|
Handle<TypeFeedbackVector> feedback_vector =
|
|
handle(f->shared()->feedback_vector(), isolate);
|
|
int ic_slot = 0;
|
|
CallICNexus nexus(feedback_vector, FeedbackVectorICSlot(ic_slot));
|
|
CHECK_EQ(1, feedback_vector->ic_with_type_info_count());
|
|
CHECK_EQ(0, feedback_vector->ic_generic_count());
|
|
|
|
// Now send the information generic.
|
|
CompileRun("f(Object);");
|
|
CHECK_EQ(0, feedback_vector->ic_with_type_info_count());
|
|
CHECK_EQ(1, feedback_vector->ic_generic_count());
|
|
|
|
// A collection will not affect the site.
|
|
heap->CollectAllGarbage(i::Heap::kNoGCFlags);
|
|
CHECK_EQ(0, feedback_vector->ic_with_type_info_count());
|
|
CHECK_EQ(1, feedback_vector->ic_generic_count());
|
|
|
|
// The Array function is special. A call to array remains monomorphic
|
|
// and isn't cleared by gc because an AllocationSite is being held.
|
|
// Clear the IC manually in order to test this case.
|
|
nexus.Clear(*code);
|
|
CompileRun("f(Array);");
|
|
CHECK_EQ(1, feedback_vector->ic_with_type_info_count());
|
|
CHECK_EQ(0, feedback_vector->ic_generic_count());
|
|
|
|
|
|
CHECK(nexus.GetFeedback()->IsAllocationSite());
|
|
heap->CollectAllGarbage(i::Heap::kNoGCFlags);
|
|
CHECK_EQ(1, feedback_vector->ic_with_type_info_count());
|
|
CHECK_EQ(0, feedback_vector->ic_generic_count());
|
|
CHECK(nexus.GetFeedback()->IsAllocationSite());
|
|
}
|
|
|
|
|
|
TEST(VectorCallICStates) {
|
|
if (i::FLAG_always_opt) return;
|
|
CcTest::InitializeVM();
|
|
LocalContext context;
|
|
v8::HandleScope scope(context->GetIsolate());
|
|
Isolate* isolate = CcTest::i_isolate();
|
|
Heap* heap = isolate->heap();
|
|
|
|
// Make sure function f has a call that uses a type feedback slot.
|
|
CompileRun(
|
|
"function foo() { return 17; }"
|
|
"function f(a) { a(); } f(foo);");
|
|
Handle<JSFunction> f = v8::Utils::OpenHandle(
|
|
*v8::Handle<v8::Function>::Cast(CcTest::global()->Get(v8_str("f"))));
|
|
// There should be one IC.
|
|
Handle<TypeFeedbackVector> feedback_vector =
|
|
Handle<TypeFeedbackVector>(f->shared()->feedback_vector(), isolate);
|
|
FeedbackVectorICSlot slot(0);
|
|
CallICNexus nexus(feedback_vector, slot);
|
|
CHECK_EQ(MONOMORPHIC, nexus.StateFromFeedback());
|
|
// CallIC doesn't return map feedback.
|
|
CHECK(!nexus.FindFirstMap());
|
|
|
|
CompileRun("f(function() { return 16; })");
|
|
CHECK_EQ(GENERIC, nexus.StateFromFeedback());
|
|
|
|
// After a collection, state should remain GENERIC.
|
|
heap->CollectAllGarbage(i::Heap::kNoGCFlags);
|
|
CHECK_EQ(GENERIC, nexus.StateFromFeedback());
|
|
|
|
// A call to Array is special, it contains an AllocationSite as feedback.
|
|
// Clear the IC manually in order to test this case.
|
|
nexus.Clear(f->shared()->code());
|
|
CompileRun("f(Array)");
|
|
CHECK_EQ(MONOMORPHIC, nexus.StateFromFeedback());
|
|
CHECK(nexus.GetFeedback()->IsAllocationSite());
|
|
|
|
heap->CollectAllGarbage(i::Heap::kNoGCFlags);
|
|
CHECK_EQ(MONOMORPHIC, nexus.StateFromFeedback());
|
|
}
|
|
|
|
|
|
TEST(VectorLoadICStates) {
|
|
if (i::FLAG_always_opt || !i::FLAG_vector_ics) return;
|
|
CcTest::InitializeVM();
|
|
LocalContext context;
|
|
v8::HandleScope scope(context->GetIsolate());
|
|
Isolate* isolate = CcTest::i_isolate();
|
|
Heap* heap = isolate->heap();
|
|
|
|
// Make sure function f has a call that uses a type feedback slot.
|
|
CompileRun(
|
|
"var o = { foo: 3 };"
|
|
"function f(a) { return a.foo; } f(o);");
|
|
Handle<JSFunction> f = v8::Utils::OpenHandle(
|
|
*v8::Handle<v8::Function>::Cast(CcTest::global()->Get(v8_str("f"))));
|
|
// There should be one IC.
|
|
Handle<TypeFeedbackVector> feedback_vector =
|
|
Handle<TypeFeedbackVector>(f->shared()->feedback_vector(), isolate);
|
|
FeedbackVectorICSlot slot(0);
|
|
LoadICNexus nexus(feedback_vector, slot);
|
|
CHECK_EQ(PREMONOMORPHIC, nexus.StateFromFeedback());
|
|
|
|
CompileRun("f(o)");
|
|
CHECK_EQ(MONOMORPHIC, nexus.StateFromFeedback());
|
|
// Verify that the monomorphic map is the one we expect.
|
|
Handle<JSObject> o = v8::Utils::OpenHandle(
|
|
*v8::Handle<v8::Object>::Cast(CcTest::global()->Get(v8_str("o"))));
|
|
CHECK_EQ(o->map(), nexus.FindFirstMap());
|
|
|
|
// Now go polymorphic.
|
|
CompileRun("f({ blarg: 3, foo: 2 })");
|
|
CHECK_EQ(POLYMORPHIC, nexus.StateFromFeedback());
|
|
|
|
CompileRun(
|
|
"delete o.foo;"
|
|
"f(o)");
|
|
CHECK_EQ(POLYMORPHIC, nexus.StateFromFeedback());
|
|
|
|
CompileRun("f({ blarg: 3, torino: 10, foo: 2 })");
|
|
CHECK_EQ(POLYMORPHIC, nexus.StateFromFeedback());
|
|
MapHandleList maps;
|
|
nexus.FindAllMaps(&maps);
|
|
CHECK_EQ(4, maps.length());
|
|
|
|
// Finally driven megamorphic.
|
|
CompileRun("f({ blarg: 3, gran: 3, torino: 10, foo: 2 })");
|
|
CHECK_EQ(MEGAMORPHIC, nexus.StateFromFeedback());
|
|
CHECK(!nexus.FindFirstMap());
|
|
|
|
// After a collection, state should not be reset to PREMONOMORPHIC.
|
|
heap->CollectAllGarbage(i::Heap::kNoGCFlags);
|
|
CHECK_EQ(MEGAMORPHIC, nexus.StateFromFeedback());
|
|
}
|
|
|
|
|
|
TEST(VectorLoadICSlotSharing) {
|
|
if (i::FLAG_always_opt || !i::FLAG_vector_ics) return;
|
|
CcTest::InitializeVM();
|
|
LocalContext context;
|
|
v8::HandleScope scope(context->GetIsolate());
|
|
Isolate* isolate = CcTest::i_isolate();
|
|
|
|
// Function f has 3 LoadICs, one for each o, but the ICs share the same
|
|
// feedback vector IC slot.
|
|
CompileRun(
|
|
"var o = 10;"
|
|
"function f() {"
|
|
" var x = o + 10;"
|
|
" return o + x + o;"
|
|
"}"
|
|
"f();");
|
|
Handle<JSFunction> f = v8::Utils::OpenHandle(
|
|
*v8::Handle<v8::Function>::Cast(CcTest::global()->Get(v8_str("f"))));
|
|
// There should be one IC slot.
|
|
Handle<TypeFeedbackVector> feedback_vector =
|
|
Handle<TypeFeedbackVector>(f->shared()->feedback_vector(), isolate);
|
|
CHECK_EQ(1, feedback_vector->ICSlots());
|
|
FeedbackVectorICSlot slot(0);
|
|
LoadICNexus nexus(feedback_vector, slot);
|
|
CHECK_EQ(MONOMORPHIC, nexus.StateFromFeedback());
|
|
}
|
|
|
|
|
|
TEST(VectorLoadICOnSmi) {
|
|
if (i::FLAG_always_opt || !i::FLAG_vector_ics) return;
|
|
CcTest::InitializeVM();
|
|
LocalContext context;
|
|
v8::HandleScope scope(context->GetIsolate());
|
|
Isolate* isolate = CcTest::i_isolate();
|
|
Heap* heap = isolate->heap();
|
|
|
|
// Make sure function f has a call that uses a type feedback slot.
|
|
CompileRun(
|
|
"var o = { foo: 3 };"
|
|
"function f(a) { return a.foo; } f(o);");
|
|
Handle<JSFunction> f = v8::Utils::OpenHandle(
|
|
*v8::Handle<v8::Function>::Cast(CcTest::global()->Get(v8_str("f"))));
|
|
// There should be one IC.
|
|
Handle<TypeFeedbackVector> feedback_vector =
|
|
Handle<TypeFeedbackVector>(f->shared()->feedback_vector(), isolate);
|
|
FeedbackVectorICSlot slot(0);
|
|
LoadICNexus nexus(feedback_vector, slot);
|
|
CHECK_EQ(PREMONOMORPHIC, nexus.StateFromFeedback());
|
|
|
|
CompileRun("f(34)");
|
|
CHECK_EQ(MONOMORPHIC, nexus.StateFromFeedback());
|
|
// Verify that the monomorphic map is the one we expect.
|
|
Map* number_map = heap->heap_number_map();
|
|
CHECK_EQ(number_map, nexus.FindFirstMap());
|
|
|
|
// Now go polymorphic on o.
|
|
CompileRun("f(o)");
|
|
CHECK_EQ(POLYMORPHIC, nexus.StateFromFeedback());
|
|
|
|
MapHandleList maps;
|
|
nexus.FindAllMaps(&maps);
|
|
CHECK_EQ(2, maps.length());
|
|
|
|
// One of the maps should be the o map.
|
|
Handle<JSObject> o = v8::Utils::OpenHandle(
|
|
*v8::Handle<v8::Object>::Cast(CcTest::global()->Get(v8_str("o"))));
|
|
bool number_map_found = false;
|
|
bool o_map_found = false;
|
|
for (int i = 0; i < maps.length(); i++) {
|
|
Handle<Map> current = maps[i];
|
|
if (*current == number_map)
|
|
number_map_found = true;
|
|
else if (*current == o->map())
|
|
o_map_found = true;
|
|
}
|
|
CHECK(number_map_found && o_map_found);
|
|
|
|
// The degree of polymorphism doesn't change.
|
|
CompileRun("f(100)");
|
|
CHECK_EQ(POLYMORPHIC, nexus.StateFromFeedback());
|
|
MapHandleList maps2;
|
|
nexus.FindAllMaps(&maps2);
|
|
CHECK_EQ(2, maps2.length());
|
|
}
|
|
}
|